You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/08 13:15:51 UTC
[GitHub] [camel-website] dzekem opened a new pull request #178: Made table
style to be stripped and added padding
dzekem opened a new pull request #178: Made table style to be stripped and added padding
URL: https://github.com/apache/camel-website/pull/178
Added styling to the table by making the table header to have the camel orange background color and made the table to be striped as shown on the screen shot
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #178: Made table style
to be stripped and added padding
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #178: Made table style to be stripped and added padding
URL: https://github.com/apache/camel-website/pull/178#issuecomment-596413332
Perhaps I would mute the colors a bit as well. Here's a quick hack in the CSS inspector:
That makes it a bit apparent that we also need to center align the `td` content.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #178: Made table style
to be stripped and added padding
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #178: Made table style to be stripped and added padding
URL: https://github.com/apache/camel-website/pull/178#issuecomment-596411467
Thanks, it's much better this way! For my taste I would go without table borders as we don't use them in other uses of tables in the documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] oscerd commented on issue #178: Made table style to
be stripped and added padding
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #178: Made table style to be stripped and added padding
URL: https://github.com/apache/camel-website/pull/178#issuecomment-596205642
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #178: Made table style
to be stripped and added padding
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #178: Made table style to be stripped and added padding
URL: https://github.com/apache/camel-website/pull/178#issuecomment-596414204
And I just noticed, we can't make globally scoped rules in CSS. For example the `table` rule added here applies to all tables on the website. We have slightly different design for tables in the documentation. All rules need to be scoped to the `.blog` CSS class. That is instead of the selector `table` the selector needs to be `.blog table`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] oscerd merged pull request #178: Made table style
to be stripped and added padding
Posted by GitBox <gi...@apache.org>.
oscerd merged pull request #178: Made table style to be stripped and added padding
URL: https://github.com/apache/camel-website/pull/178
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services