You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aries.apache.org by Renato Athaydes <re...@athaydes.com> on 2017/10/27 19:00:29 UTC

Protobuf support in Aries RSA

Hi!

I've noticed that most of the code in the aries-rsa/provider/fasbin project
is done, but it's not documented and does not seem to be useable yet. The
code seems to have a few parts unfinished!

Can I ask what's the status of that? If it's not ready yet, what is
missing? Can I provide a pull request on GitHub to complete the
implementation and make it useable?

Regards,

Renato Athaydes

Re: Protobuf support in Aries RSA

Posted by Christian Schneider <ch...@die-schneider.net>.
I am not using protobuf myself but I think some people use it. If you see
potential for improvement or fixes please go ahead.

Ideally first create a jira issue and describe the error or the requirement
and then the proposed solution. So people can review the design before you
put a lot of work into it. If you need any help setting up the dev
environment or how to do the actual PRs let me know.

Christian


2017-10-27 21:00 GMT+02:00 Renato Athaydes <re...@athaydes.com>:

> Hi!
>
> I've noticed that most of the code in the aries-rsa/provider/fasbin project
> is done, but it's not documented and does not seem to be useable yet. The
> code seems to have a few parts unfinished!
>
> Can I ask what's the status of that? If it's not ready yet, what is
> missing? Can I provide a pull request on GitHub to complete the
> implementation and make it useable?
>
> Regards,
>
> Renato Athaydes
>



-- 
-- 
Christian Schneider
http://www.liquid-reality.de
<https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46&URL=http%3a%2f%2fwww.liquid-reality.de>

Computer Scientist
http://www.adobe.com

Re: Protobuf support in Aries RSA

Posted by Johannes Utzig <ju...@gmail.com>.
Hi,

The protobuf part of fastbin should work and there is test cases for it.
It has a few functional limitations compared to the serializing code paths:

1. Async calls aren't supported the same way
2. Streams aren't supported
3. The error handling isn't great
4. Only 0 or 1 parameters allowed

You can find a usage example here:
https://github.com/apache/aries-rsa/blob/master/provider/fastbin/src/test/java/org/apache/aries/rsa/provider/fastbin/InvocationTest.java

Do you have specific ideas on what should be added/changed/improved?
I don't really use protobuf myself, so any help and feedback on the
protobuf parts are welcome.

Best regards,
Johannes

Am 27.10.2017 9:42 nachm. schrieb "Renato Athaydes" <re...@athaydes.com>:

> Hi!
>
> I've noticed that most of the code in the aries-rsa/provider/fasbin project
> is done, but it's not documented and does not seem to be useable yet. The
> code seems to have a few parts unfinished!
>
> Can I ask what's the status of that? If it's not ready yet, what is
> missing? Can I provide a pull request on GitHub to complete the
> implementation and make it useable?
>
> Regards,
>
> Renato Athaydes
>