[GitHub] [spark] viirya commented on a diff in pull request #37415: [SPARK-40020][SQL] Centralize the code of qualifying identifiers in SessionCatalog

[GitBox <gi...@apache.org>]

viirya commented on code in PR #37415:
URL: https://github.com/apache/spark/pull/37415#discussion_r943092133


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/identifiers.scala:
##########
@@ -113,6 +88,7 @@ object AliasIdentifier {
  */
 case class TableIdentifier(table: String, database: Option[String], catalog: Option[String])
   extends CatalystIdentifier {
+  assert(catalog.isEmpty || database.isDefined)

Review Comment:
   This requires `database` must be defined if `catalog` is defined?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org