You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/15 03:18:14 UTC

[GitHub] [apisix] RocFang commented on a change in pull request #4606: fix: correct the return value checking of pcall, since apisix_ngx_cli…

RocFang commented on a change in pull request #4606:
URL: https://github.com/apache/apisix/pull/4606#discussion_r670103118



##########
File path: apisix/plugins/client-control.lua
##########
@@ -48,7 +48,7 @@ end
 
 
 function _M.rewrite(conf, ctx)
-    if not apisix_ngx_client then
+    if not ok then

Review comment:
       @tokers thx. i guess you mean throw an error when failed calling pcall, so this plugin will not be loaded. I agree with that  actually, but only try to make the patch as small as possbile.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org