[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #16255: [client][python] getLastMessageIdAsync C binding

[GitBox <gi...@apache.org>]

Anonymitaet commented on code in PR #16255:
URL: https://github.com/apache/pulsar/pull/16255#discussion_r909029902


##########
pulsar-client-cpp/README.md:
##########
@@ -280,7 +280,7 @@ ${PULSAR_PATH}/pulsar-test-service-stop.sh
 
 ## Requirements for Contributors
 
-It's recommended to install [LLVM](https://llvm.org/builds/) for `clang-tidy` and `clang-format`. Pulsar C++ client use `clang-format` 6.0+ to format files. 
+It's required to install [LLVM](https://llvm.org/builds/) for `clang-tidy` and `clang-format`. Pulsar C++ client use `clang-format` 6.0+ to format files.  `make format` will automatically format the files.

Review Comment:
   ```suggestion
   It's required to install [LLVM](https://llvm.org/builds/) for `clang-tidy` and `clang-format`. Pulsar C++ client use `clang-format` 6.0+ to format files.  `make format` automatically formats the files.
   ```
   
   Write in the simple present tense as much as possible if you are covering facts that were, are, and forever shall be true.
   https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#bookmark=id.e8uqh1awkcnp



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org