You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/10/22 19:54:34 UTC
[GitHub] [iceberg] kbendick opened a new issue #1649: Rewrite PR labeler using Github Action
kbendick opened a new issue #1649:
URL: https://github.com/apache/iceberg/issues/1649
There's a relatively standard github action for labeling PRs.
As discussed in the group meetup yesterday, we were going to try to migrate to GH actions. We can consider migrating the PR labeler as I've not heard back about the current one, which is broken both here and in Spark. I'll keep trying though.
If I don't hear back from the author of the other one by maybe the end of the week, I'll refactor and switch and see if we need to get the repo onboarded via asf infra.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on issue #1649: Rewrite dead PR labeler using standard Github Action
Posted by GitBox <gi...@apache.org>.
kbendick commented on issue #1649:
URL: https://github.com/apache/iceberg/issues/1649#issuecomment-718359206
Check if a file in a nested subdirectory matches: https://github.com/kbendick/iceberg/pull/32 ✅
This test is necessary as there are multiple glob pattern matches listed for files in a directory and files in a subdirectory of a directory, but it appears to make no difference so we can keep the config cleaner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue closed issue #1649: Rewrite PR labeler using standard Github Action as Probot Labeler is EOL
Posted by GitBox <gi...@apache.org>.
rdblue closed issue #1649:
URL: https://github.com/apache/iceberg/issues/1649
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on issue #1649: Rewrite dead PR labeler using standard Github Action
Posted by GitBox <gi...@apache.org>.
kbendick commented on issue #1649:
URL: https://github.com/apache/iceberg/issues/1649#issuecomment-718358674
Check if a file by exact name (in the repo root) matches: https://github.com/kbendick/iceberg/pull/31 ✅
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on issue #1649: Rewrite dead PR labeler using standard Github Action
Posted by GitBox <gi...@apache.org>.
kbendick commented on issue #1649:
URL: https://github.com/apache/iceberg/issues/1649#issuecomment-718359412
The only thing left to add back on and check afaik is that we previously matched on any file that matched the substring `gradle`. I think I know how to get that back into the labeler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on issue #1649: Rewrite PR labeler using standard Github Action as Probot Labeler is EOL
Posted by GitBox <gi...@apache.org>.
kbendick commented on issue #1649:
URL: https://github.com/apache/iceberg/issues/1649#issuecomment-718405302
I've opened a JIRA ticket with the infra team to have them disable the probot labeler and revoke its permissions: https://issues.apache.org/jira/browse/INFRA-21048
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on issue #1649: Rewrite dead PR labeler using standard Github Action
Posted by GitBox <gi...@apache.org>.
kbendick commented on issue #1649:
URL: https://github.com/apache/iceberg/issues/1649#issuecomment-718361054
Check if a file that has `gradle` in the name matches in the repo root: https://github.com/kbendick/iceberg/pull/33 ✅
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on issue #1649: Rewrite dead PR labeler using standard Github Action
Posted by GitBox <gi...@apache.org>.
kbendick commented on issue #1649:
URL: https://github.com/apache/iceberg/issues/1649#issuecomment-714734990
I'll also reach out to ASF Infra to ensure that the permissions that the old Probot Autolabeler requested from any of our repos has been turned off as the developer confirmed they won't be maintaining.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on issue #1649: Rewrite dead PR labeler using standard Github Action
Posted by GitBox <gi...@apache.org>.
kbendick commented on issue #1649:
URL: https://github.com/apache/iceberg/issues/1649#issuecomment-718367781
I've simplified the `gradle` substring match to combine checking subdirectories and top level directories in my forked branch of this repo, which made the following test pass and also allowed the previous test to pass as well.
Check if a file that has `gradle` in the name at all matches in a subdirectory of the repo: https://github.com/kbendick/iceberg/pull/34 ✅
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on issue #1649: Rewrite dead PR labeler using standard Github Action
Posted by GitBox <gi...@apache.org>.
kbendick commented on issue #1649:
URL: https://github.com/apache/iceberg/issues/1649#issuecomment-714731033
This is the "standard" labeler action, but if anybody else has any specific suggestions I'm open to them: https://github.com/actions/labeler
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on issue #1649: Rewrite dead PR labeler using standard Github Action
Posted by GitBox <gi...@apache.org>.
kbendick commented on issue #1649:
URL: https://github.com/apache/iceberg/issues/1649#issuecomment-718356521
Ok. I've added a github action in my personal fork. The asf infra team might have to allow Github Actions on this repo, but it's possible they already have allowed GH Actions on all repos in `apache`. If that's the case, their intervention won't be required (though I'm still going to cut a ticket to have them remove the permissions for the old PR labeler).
I'm now running some tests where I've already merged in the labeler in my personal repo to ensure it's working as expected. I will list them here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on issue #1649: Rewrite PR labeler using Github Action
Posted by GitBox <gi...@apache.org>.
kbendick commented on issue #1649:
URL: https://github.com/apache/iceberg/issues/1649#issuecomment-714730457
Here's the closed issue indicating that the old autolabeler will not be coming back, so we should definitely upgrade both us and then Spark: https://github.com/apache/iceberg/issues/1583
I will do so in the next few days, working it out with the asf infra team.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on issue #1649: Rewrite dead PR labeler using standard Github Action
Posted by GitBox <gi...@apache.org>.
kbendick commented on issue #1649:
URL: https://github.com/apache/iceberg/issues/1649#issuecomment-718356732
Check if a file added directly beneath the root of the flink directory is labeled as flink: https://github.com/kbendick/iceberg/pull/30 ✅
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on issue #1649: Rewrite PR labeler using standard Github Actionn as Probot Labeler is EOL
Posted by GitBox <gi...@apache.org>.
kbendick commented on issue #1649:
URL: https://github.com/apache/iceberg/issues/1649#issuecomment-718393465
I force pushed the current master to my personal fork, so if the tests aren't showing up correctly now that's why. However, the labels that they applied are still in the open PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on issue #1649: Rewrite PR labeler using standard Github Actionn as Probot Labeler is EOL
Posted by GitBox <gi...@apache.org>.
kbendick commented on issue #1649:
URL: https://github.com/apache/iceberg/issues/1649#issuecomment-718374609
Can somebody assign this issue to me? I'm going to reach out to ASF infra as well as on the spark dev emailing list, and I won't to ensure that everything looks correct to any outside observers that might be double checking for security concerns really quickly or something (e.g. the asf infra team). cc @rdblue @aokolnychyi
I will submit a patch for this tonight, but I'll need to folllow up with the infra team to ensure the permissions for the old one are removed (as well as get Github Actions enabled for this repo if they're not already enabled for all of the `apache` github).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on issue #1649: Rewrite dead PR labeler using standard Github Action
Posted by GitBox <gi...@apache.org>.
kbendick commented on issue #1649:
URL: https://github.com/apache/iceberg/issues/1649#issuecomment-718368214
I will put up a PR for the labeler in this repo, as well as email the dev spark list about opening an issue to change their autolabeler, this evening now that I've run all of my tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org