You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/06/09 20:32:07 UTC
[jira] Created: (CASSANDRA-224) Encapsulate SSTable, SequenceFile
better
Encapsulate SSTable, SequenceFile better
----------------------------------------
Key: CASSANDRA-224
URL: https://issues.apache.org/jira/browse/CASSANDRA-224
Project: Cassandra
Issue Type: Improvement
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
All kinds of code needs to know about the inner workings of SSTable to work. A major cause is passing around SSTable filenames instead of objects. Thanks to CASSANDRA-208 I feel like I have a good enough understanding of the code here to refactor more than superficially.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-224) Encapsulate SSTable, SequenceFile
better
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722053#action_12722053 ]
Jonathan Ellis commented on CASSANDRA-224:
------------------------------------------
05
make static methods of SSTable that take a filename and then use the cache to grab an sstable object, simple non-static methods instead
04
encapsulate bloom filter
03
encapsulate index
02
refactor read-only constructor to SSTable.open
01
r/m unused code dealing with sstables, sequencefile, etc.
these patches apply on top of the patches for 79.
> Encapsulate SSTable, SequenceFile better
> ----------------------------------------
>
> Key: CASSANDRA-224
> URL: https://issues.apache.org/jira/browse/CASSANDRA-224
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 0001-CASSANDRA-224-r-m-unused-code-dealing-with-sstables-a.txt, 0002-refactor-read-only-constructor-to-SSTable.open.txt, 0003-encapsulate-index.txt, 0004-encapsulate-bloom-filter.txt, 0005-make-static-methods-of-SSTable-that-take-a-filename-an.txt
>
>
> All kinds of code needs to know about the inner workings of SSTable to work. A major cause is passing around SSTable filenames instead of objects. Thanks to CASSANDRA-208 I feel like I have a good enough understanding of the code here to refactor more than superficially.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-224) Encapsulate SSTable, SequenceFile
better
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-224:
-------------------------------------
Attachment: 0005-make-static-methods-of-SSTable-that-take-a-filename-an.txt
0004-encapsulate-bloom-filter.txt
0003-encapsulate-index.txt
0002-refactor-read-only-constructor-to-SSTable.open.txt
0001-CASSANDRA-224-r-m-unused-code-dealing-with-sstables-a.txt
> Encapsulate SSTable, SequenceFile better
> ----------------------------------------
>
> Key: CASSANDRA-224
> URL: https://issues.apache.org/jira/browse/CASSANDRA-224
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 0001-CASSANDRA-224-r-m-unused-code-dealing-with-sstables-a.txt, 0002-refactor-read-only-constructor-to-SSTable.open.txt, 0003-encapsulate-index.txt, 0004-encapsulate-bloom-filter.txt, 0005-make-static-methods-of-SSTable-that-take-a-filename-an.txt
>
>
> All kinds of code needs to know about the inner workings of SSTable to work. A major cause is passing around SSTable filenames instead of objects. Thanks to CASSANDRA-208 I feel like I have a good enough understanding of the code here to refactor more than superficially.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-224) Encapsulate SSTable, SequenceFile
better
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-224:
-------------------------------------
Component/s: Core
> Encapsulate SSTable, SequenceFile better
> ----------------------------------------
>
> Key: CASSANDRA-224
> URL: https://issues.apache.org/jira/browse/CASSANDRA-224
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 0001-CASSANDRA-224-r-m-unused-code-dealing-with-sstables-a.txt, 0002-refactor-read-only-constructor-to-SSTable.open.txt, 0003-encapsulate-index.txt, 0004-encapsulate-bloom-filter.txt, 0005-make-static-methods-of-SSTable-that-take-a-filename-an.txt
>
>
> All kinds of code needs to know about the inner workings of SSTable to work. A major cause is passing around SSTable filenames instead of objects. Thanks to CASSANDRA-208 I feel like I have a good enough understanding of the code here to refactor more than superficially.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-224) Encapsulate SSTable, SequenceFile
better
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-224:
-------------------------------------
Fix Version/s: 0.4
> Encapsulate SSTable, SequenceFile better
> ----------------------------------------
>
> Key: CASSANDRA-224
> URL: https://issues.apache.org/jira/browse/CASSANDRA-224
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
>
> All kinds of code needs to know about the inner workings of SSTable to work. A major cause is passing around SSTable filenames instead of objects. Thanks to CASSANDRA-208 I feel like I have a good enough understanding of the code here to refactor more than superficially.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-224) Encapsulate SSTable, SequenceFile
better
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723580#action_12723580 ]
Hudson commented on CASSANDRA-224:
----------------------------------
Integrated in Cassandra #118 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/118/])
make static methods of SSTable that take a filename and then use the cache to grab an sstable object, simple non-static methods instead
patch by jbellis; reviewed by Eric Evans for
encapsulate sstable bloom filter
patch by jbellis; reviewed by Eric Evans for
encapsulate sstable index
patch by jbellis; reviewed by Eric Evans for
refactor read-only constructor to SSTable.open
patch by jbellis; reviewed by Eric Evans for
r/m unused code dealing with sstables, and ConcurrentWriter / FastConcurrentWriter. mmap is not faster than write() for sequential I/O, which is what the vast majority of our writes are. mmap _does_ have an advantage when we seek back to the start of a commitlog segment to update the headers after memtable flush, but we do that infrequently enough that it's not worth the disadvantages (primarily, blowing up if we exceed the 4MB size).
patch by jbellis; reviewed by Eric Evans for
> Encapsulate SSTable, SequenceFile better
> ----------------------------------------
>
> Key: CASSANDRA-224
> URL: https://issues.apache.org/jira/browse/CASSANDRA-224
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 0001-CASSANDRA-224-r-m-unused-code-dealing-with-sstables-a.txt, 0002-refactor-read-only-constructor-to-SSTable.open.txt, 0003-encapsulate-index.txt, 0004-encapsulate-bloom-filter.txt, 0005-make-static-methods-of-SSTable-that-take-a-filename-an.txt
>
>
> All kinds of code needs to know about the inner workings of SSTable to work. A major cause is passing around SSTable filenames instead of objects. Thanks to CASSANDRA-208 I feel like I have a good enough understanding of the code here to refactor more than superficially.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-224) Encapsulate SSTable, SequenceFile
better
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723152#action_12723152 ]
Eric Evans commented on CASSANDRA-224:
--------------------------------------
Looks good. Much cleaner. +1
> Encapsulate SSTable, SequenceFile better
> ----------------------------------------
>
> Key: CASSANDRA-224
> URL: https://issues.apache.org/jira/browse/CASSANDRA-224
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 0001-CASSANDRA-224-r-m-unused-code-dealing-with-sstables-a.txt, 0002-refactor-read-only-constructor-to-SSTable.open.txt, 0003-encapsulate-index.txt, 0004-encapsulate-bloom-filter.txt, 0005-make-static-methods-of-SSTable-that-take-a-filename-an.txt
>
>
> All kinds of code needs to know about the inner workings of SSTable to work. A major cause is passing around SSTable filenames instead of objects. Thanks to CASSANDRA-208 I feel like I have a good enough understanding of the code here to refactor more than superficially.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-224) Encapsulate SSTable, SequenceFile
better
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722837#action_12722837 ]
Jonathan Ellis commented on CASSANDRA-224:
------------------------------------------
79 is applied. these should apply to trunk now.
> Encapsulate SSTable, SequenceFile better
> ----------------------------------------
>
> Key: CASSANDRA-224
> URL: https://issues.apache.org/jira/browse/CASSANDRA-224
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 0001-CASSANDRA-224-r-m-unused-code-dealing-with-sstables-a.txt, 0002-refactor-read-only-constructor-to-SSTable.open.txt, 0003-encapsulate-index.txt, 0004-encapsulate-bloom-filter.txt, 0005-make-static-methods-of-SSTable-that-take-a-filename-an.txt
>
>
> All kinds of code needs to know about the inner workings of SSTable to work. A major cause is passing around SSTable filenames instead of objects. Thanks to CASSANDRA-208 I feel like I have a good enough understanding of the code here to refactor more than superficially.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.