You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/11/17 18:09:25 UTC
[GitHub] [accumulo-proxy] DomGarguilo opened a new pull request, #46: Trivial: Use AccumuloITBase unique name method
DomGarguilo opened a new pull request, #46:
URL: https://github.com/apache/accumulo-proxy/pull/46
This PR replaces a stand-in method used to get unique names (created between upgrading JUnit versions) with `AccumuloITBase.getUniqueNames()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-proxy] DomGarguilo commented on pull request #46: Trivial: Use AccumuloITBase unique name method
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on PR #46:
URL: https://github.com/apache/accumulo-proxy/pull/46#issuecomment-1320034126
> If our goal is to no longer depend on Accumulo, except for public API, then we probably don't want to depend on things from Accumulo's test code either. If the tests are updated to use accumulo2-maven-plugin instead of extending our minicluster IT base classes, then they wouldn't have access to this convenience method, so we'd end up re-adding this method later anyway... so it's probably not worth doing this.
That makes sense, closing for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-proxy] DomGarguilo closed pull request #46: Trivial: Use AccumuloITBase unique name method
Posted by GitBox <gi...@apache.org>.
DomGarguilo closed pull request #46: Trivial: Use AccumuloITBase unique name method
URL: https://github.com/apache/accumulo-proxy/pull/46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org