You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2015/09/29 22:37:24 UTC
Review Request 38860: Linked more doc pages from home.md.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38860/
-----------------------------------------------------------
Review request for mesos and Adam B.
Repository: mesos
Description
-------
Also made various cleanups and fixes throughout the docs.
Diffs
-----
docs/allocation-module.md 4ba5ba8c27cccebf0e5fc5064fdc1d6af05d38f0
docs/app-framework-development-guide.md bada7fea8af545f18876cae584f67c9422f45eaf
docs/attributes-resources.md 1ea5dde7cf32af5a0ab93510642863cc952f9780
docs/deploy-scripts.md 58b3a69042746ccdc6515ad652eac50b9c67e8eb
docs/fetcher-cache-internals.md d17b41e7113ce72679734fc0bed16614011b6917
docs/fetcher.md 638f5305a24fe7dbf459c937872a295e8edd5d44
docs/home.md f8c2b62c486dfbce310705de51038247701cf54a
docs/mesos-c++-style-guide.md 570ea6873ffc2cc8ec190ec3aa81986e3f3cbc95
docs/oversubscription.md b1a6c9979025ce33190792a07b8e9618c518430e
docs/persistent-volume.md ae5b0e53997c9cb2a8bab22e0109e6768124f82b
docs/reconciliation.md b50d692d415cf677d23051fdd8a2fddbd4c4d134
docs/scheduler_http_api.md cfac5105109519dcb275e50671906382960ff39b
docs/tools.md 09619f2c162b1765e7718fc314e77b0f77148b97
Diff: https://reviews.apache.org/r/38860/diff/
Testing
-------
Previewed via https://github.com/mesosphere/mesos-website-container
Thanks,
Neil Conway
Re: Review Request 38860: Linked more doc pages from home.md.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38860/#review101042
-----------------------------------------------------------
Ship it!
It took a while to track down some of these 2-character changes in raw RB, but I've reviewed and it all looks good. There are a couple of minor changes, but I'll just make those before I commit.
docs/deploy-scripts.md (line 16)
<https://reviews.apache.org/r/38860/#comment158346>
s/configure Mesos use/configure Mesos to use/
docs/home.md (line 32)
<https://reviews.apache.org/r/38860/#comment158350>
We might want to move other "advanced" features in here like authn/z, SSL, containerizers, rate limiting, network-monitoring, and maintenance. But we can do that later, as needed.
docs/home.md (line 55)
<https://reviews.apache.org/r/38860/#comment158351>
Let's move this below the general Mesos Modules link
- Adam B
On Sept. 29, 2015, 1:37 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38860/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 1:37 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also made various cleanups and fixes throughout the docs.
>
>
> Diffs
> -----
>
> docs/allocation-module.md 4ba5ba8c27cccebf0e5fc5064fdc1d6af05d38f0
> docs/app-framework-development-guide.md bada7fea8af545f18876cae584f67c9422f45eaf
> docs/attributes-resources.md 1ea5dde7cf32af5a0ab93510642863cc952f9780
> docs/deploy-scripts.md 58b3a69042746ccdc6515ad652eac50b9c67e8eb
> docs/fetcher-cache-internals.md d17b41e7113ce72679734fc0bed16614011b6917
> docs/fetcher.md 638f5305a24fe7dbf459c937872a295e8edd5d44
> docs/home.md f8c2b62c486dfbce310705de51038247701cf54a
> docs/mesos-c++-style-guide.md 570ea6873ffc2cc8ec190ec3aa81986e3f3cbc95
> docs/oversubscription.md b1a6c9979025ce33190792a07b8e9618c518430e
> docs/persistent-volume.md ae5b0e53997c9cb2a8bab22e0109e6768124f82b
> docs/reconciliation.md b50d692d415cf677d23051fdd8a2fddbd4c4d134
> docs/scheduler_http_api.md cfac5105109519dcb275e50671906382960ff39b
> docs/tools.md 09619f2c162b1765e7718fc314e77b0f77148b97
>
> Diff: https://reviews.apache.org/r/38860/diff/
>
>
> Testing
> -------
>
> Previewed via https://github.com/mesosphere/mesos-website-container
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 38860: Linked more doc pages from home.md.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38860/#review101040
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38860]
All tests passed.
- Mesos ReviewBot
On Sept. 29, 2015, 8:37 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38860/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 8:37 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also made various cleanups and fixes throughout the docs.
>
>
> Diffs
> -----
>
> docs/allocation-module.md 4ba5ba8c27cccebf0e5fc5064fdc1d6af05d38f0
> docs/app-framework-development-guide.md bada7fea8af545f18876cae584f67c9422f45eaf
> docs/attributes-resources.md 1ea5dde7cf32af5a0ab93510642863cc952f9780
> docs/deploy-scripts.md 58b3a69042746ccdc6515ad652eac50b9c67e8eb
> docs/fetcher-cache-internals.md d17b41e7113ce72679734fc0bed16614011b6917
> docs/fetcher.md 638f5305a24fe7dbf459c937872a295e8edd5d44
> docs/home.md f8c2b62c486dfbce310705de51038247701cf54a
> docs/mesos-c++-style-guide.md 570ea6873ffc2cc8ec190ec3aa81986e3f3cbc95
> docs/oversubscription.md b1a6c9979025ce33190792a07b8e9618c518430e
> docs/persistent-volume.md ae5b0e53997c9cb2a8bab22e0109e6768124f82b
> docs/reconciliation.md b50d692d415cf677d23051fdd8a2fddbd4c4d134
> docs/scheduler_http_api.md cfac5105109519dcb275e50671906382960ff39b
> docs/tools.md 09619f2c162b1765e7718fc314e77b0f77148b97
>
> Diff: https://reviews.apache.org/r/38860/diff/
>
>
> Testing
> -------
>
> Previewed via https://github.com/mesosphere/mesos-website-container
>
>
> Thanks,
>
> Neil Conway
>
>