You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2017/09/07 14:09:16 UTC
[jclouds/jclouds] JCLOUDS-1258: Allow China endpoints in FormSignerV4
(#1142)
The creation of a compute context for a China region failed because the `FormSignerV4` didn't allow China endpoints.
The error happens at constructor injection time when Guice is building all singleton objects. The `IllegalArgumentException` thrown there causes an infinite loop and ends up in an `OutOfMemoryexception`.
@andrewgaul @demobox Despite having only added the China suffix in this commit, I'd rather remove completely this validation, as it provides very little value. If the endpoint does not support V4 signatures, users will probably see a self-explanatory error response coming back. WDYT?
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1142
-- Commit Summary --
* JCLOUDS-1258: Allow China endpoints in FormSignerV4
-- File Changes --
M apis/sts/src/main/java/org/jclouds/aws/filters/FormSignerV4.java (3)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/1142.patch
https://github.com/jclouds/jclouds/pull/1142.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1142
Re: [jclouds/jclouds] JCLOUDS-1258: Allow China endpoints in
FormSignerV4 (#1142)
Posted by Ignasi Barrera <no...@github.com>.
Squashed and merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/1c1f81c3) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/cfdbc810).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1142#issuecomment-328009292
Re: [jclouds/jclouds] JCLOUDS-1258: Allow China endpoints in
FormSignerV4 (#1142)
Posted by Andrew Gaul <no...@github.com>.
andrewgaul approved this pull request.
Agree that we should remove the check -- eventually we will support V4 signer for non-Amazon providers.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1142#pullrequestreview-61236929
Re: [jclouds/jclouds] JCLOUDS-1258: Allow China endpoints in
FormSignerV4 (#1142)
Posted by Ignasi Barrera <no...@github.com>.
Done. Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1142#issuecomment-327826026
Re: [jclouds/jclouds] JCLOUDS-1258: Allow China endpoints in
FormSignerV4 (#1142)
Posted by Ignasi Barrera <no...@github.com>.
@nacx pushed 1 commit.
1a8f45e Remove check
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1142/files/0f536f4f48bcb38b594f455c4826de39c023e136..1a8f45e40ae22fab167298be8a145d5b203f32d9