You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "heguanhui (via GitHub)" <gi...@apache.org> on 2026/05/16 16:57:46 UTC
[PR] [fix](fe) Validate user/role existence in SHOW ROW POLICY command [doris]
heguanhui opened a new pull request, #63317:
URL: https://github.com/apache/doris/pull/63317
### What problem does this PR solve?
Issue Number: close #xxx
Problem Summary: SHOW ROW POLICY FOR <user> and SHOW ROW POLICY FOR ROLE <role> do not validate whether the specified user or role exists. This is inconsistent with CREATE ROW POLICY which does validate, and allows confusing behavior where a non-existent user/role is silently accepted.
### Release note
SHOW ROW POLICY now reports an error when the specified user or role does not exist.
### Check List (For Author)
- Test
- [x] Regression test
- [ ] Unit Test
- [ ] Manual test
- [ ] No need to test
- Behavior changed:
- [x] Yes. SHOW ROW POLICY now throws an error for non-existent user/role instead of silently returning empty results.
- Does this need documentation?
- [x] No.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Validate user/role existence in SHOW ROW POLICY command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63317:
URL: https://github.com/apache/doris/pull/63317#issuecomment-4514410726
<details>
<summary>TPC-H: <b>Total hot run time: 30769 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d7424fa046912436d214e04ae260ea861ee4ab4e, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17862 3886 3867 3867
q2 q3 10745 1392 806 806
q4 4688 476 348 348
q5 7614 2233 2064 2064
q6 252 173 138 138
q7 977 756 637 637
q8 9422 1734 1601 1601
q9 6757 4883 4866 4866
q10 6422 2088 1781 1781
q11 436 276 239 239
q12 690 422 295 295
q13 18213 3368 2789 2789
q14 261 254 238 238
q15 q16 822 781 705 705
q17 990 884 970 884
q18 7037 5723 5550 5550
q19 1223 1339 1044 1044
q20 527 413 262 262
q21 5642 2645 2356 2356
q22 424 355 299 299
Total cold run time: 101004 ms
Total hot run time: 30769 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4179 4085 4085 4085
q2 q3 4463 4896 4273 4273
q4 2126 2222 1385 1385
q5 4377 4225 4254 4225
q6 228 177 128 128
q7 2147 1933 1629 1629
q8 2458 2091 2062 2062
q9 7689 7699 7737 7699
q10 4582 4527 4081 4081
q11 572 396 448 396
q12 795 737 535 535
q13 3315 3615 3044 3044
q14 284 295 272 272
q15 q16 711 749 648 648
q17 1341 1323 1321 1321
q18 7898 7322 7055 7055
q19 1135 1074 1071 1071
q20 2197 2185 1928 1928
q21 5301 4642 4522 4522
q22 524 465 412 412
Total cold run time: 56322 ms
Total hot run time: 50771 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Validate user/role existence in SHOW ROW POLICY command [doris]
Posted by "heguanhui (via GitHub)" <gi...@apache.org>.
heguanhui commented on PR #63317:
URL: https://github.com/apache/doris/pull/63317#issuecomment-4514251852
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Validate user/role existence in SHOW ROW POLICY command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63317:
URL: https://github.com/apache/doris/pull/63317#issuecomment-4467530050
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Validate user/role existence in SHOW ROW POLICY command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63317:
URL: https://github.com/apache/doris/pull/63317#issuecomment-4514464101
<details>
<summary>TPC-DS: <b>Total hot run time: 168818 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d7424fa046912436d214e04ae260ea861ee4ab4e, data reload: false
query5 4353 654 507 507
query6 346 216 202 202
query7 4280 545 306 306
query8 337 224 222 222
query9 8868 3960 3970 3960
query10 501 335 299 299
query11 5773 2743 2238 2238
query12 186 129 133 129
query13 1296 622 405 405
query14 6018 5325 5096 5096
query14_1 4356 4346 4339 4339
query15 211 215 189 189
query16 1039 426 458 426
query17 1170 759 632 632
query18 2695 503 370 370
query19 224 213 167 167
query20 140 134 131 131
query21 229 139 135 135
query22 13641 13530 13419 13419
query23 17057 16356 16026 16026
query23_1 16050 16239 16278 16239
query24 7435 1767 1304 1304
query24_1 1293 1295 1307 1295
query25 577 501 435 435
query26 1324 311 175 175
query27 2688 566 338 338
query28 4461 1965 1935 1935
query29 1039 646 512 512
query30 306 242 207 207
query31 1132 1071 946 946
query32 102 78 74 74
query33 543 357 310 310
query34 1179 1119 635 635
query35 768 781 664 664
query36 1313 1327 1210 1210
query37 155 114 133 114
query38 3219 3140 3076 3076
query39 936 920 891 891
query39_1 880 882 867 867
query40 226 140 124 124
query41 65 61 61 61
query42 110 108 108 108
query43 318 328 282 282
query44
query45 209 205 191 191
query46 1088 1196 706 706
query47 2276 2373 2292 2292
query48 441 431 311 311
query49 631 524 384 384
query50 1029 350 245 245
query51 4394 4329 4290 4290
query52 108 104 89 89
query53 247 286 202 202
query54 317 281 285 281
query55 96 88 87 87
query56 316 307 299 299
query57 1417 1402 1321 1321
query58 296 271 266 266
query59 1551 1610 1413 1413
query60 313 314 309 309
query61 156 150 155 150
query62 672 617 562 562
query63 235 199 206 199
query64 2377 808 618 618
query65
query66 1678 467 345 345
query67 29891 29368 29858 29368
query68
query69 456 340 307 307
query70 1045 971 958 958
query71 299 271 267 267
query72 2947 2775 2359 2359
query73 872 730 422 422
query74 5091 4898 4725 4725
query75 2686 2613 2258 2258
query76 2358 1134 751 751
query77 395 399 324 324
query78 12133 12220 11572 11572
query79 1517 1034 692 692
query80 1307 537 453 453
query81 527 283 243 243
query82 937 158 122 122
query83 319 277 245 245
query84 261 142 107 107
query85 930 567 445 445
query86 458 346 322 322
query87 3419 3399 3193 3193
query88 3534 2663 2628 2628
query89 531 379 327 327
query90 1908 180 180 180
query91 175 173 142 142
query92 85 72 72 72
query93 1621 1399 919 919
query94 707 369 333 333
query95 691 465 349 349
query96 1039 768 351 351
query97 2681 2699 2555 2555
query98 230 225 231 225
query99 1132 1090 978 978
Total cold run time: 253768 ms
Total hot run time: 168818 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Validate user/role existence in SHOW ROW POLICY command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63317:
URL: https://github.com/apache/doris/pull/63317#issuecomment-4515168223
# FE Regression Coverage Report
Increment line coverage ` 10.00% (2/20)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63317_d7424fa046912436d214e04ae260ea861ee4ab4e_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63317_d7424fa046912436d214e04ae260ea861ee4ab4e_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org