You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@geode.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/02/02 21:09:00 UTC

[jira] [Commented] (GEODE-4439) Refactor HandShake.java

    [ https://issues.apache.org/jira/browse/GEODE-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350947#comment-16350947 ] 

ASF subversion and git services commented on GEODE-4439:
--------------------------------------------------------

Commit c1b21c036d4a425b39ecb3fb1024657fd3332a13 in geode's branch refs/heads/develop from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=c1b21c0 ]

GEODE-4439 Refactor HandShake.java

Created ServerSideHandshake and ServerSideHandshakeImpl for servers.

Created ClientSideHandshake and ClientSideHandshakeImpl for clients.

Message encryption/decryption is now in an Encryptor interface.

HandShake is renamed Handshake.


> Refactor HandShake.java
> -----------------------
>
>                 Key: GEODE-4439
>                 URL: https://issues.apache.org/jira/browse/GEODE-4439
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server
>            Reporter: Bruce Schuchardt
>            Assignee: Bruce Schuchardt
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Class HandShake is used by both clients and servers to exchange information and perform encryption/decryption (which is being deprecated).  Many methods are used only by clients and others by servers.  These sometimes even have comments to that effect.  This class should be refactored into two classes, one for clients and one for servers.
> Oh, and please rename it to "Handshake".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)