You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by ro...@apache.org on 2018/01/15 09:56:06 UTC
[7/9] james-project git commit: JAMES-2286 Adding line breaks makes
test reading easier
JAMES-2286 Adding line breaks makes test reading easier
That create implicitly the de-facto team-standard given/when/then blocks.
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/8f197a4d
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/8f197a4d
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/8f197a4d
Branch: refs/heads/master
Commit: 8f197a4df92b182ec6528d96a72ea2b69474b523
Parents: f3b8bb9
Author: benwa <bt...@linagora.com>
Authored: Fri Jan 12 10:06:24 2018 +0700
Committer: benwa <bt...@linagora.com>
Committed: Mon Jan 15 16:54:02 2018 +0700
----------------------------------------------------------------------
.../mailrepository/MailRepositoryContract.java | 24 +++++++++++++++-----
1 file changed, 18 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/james-project/blob/8f197a4d/server/mailrepository/mailrepository-api/src/test/java/org/apache/james/mailrepository/MailRepositoryContract.java
----------------------------------------------------------------------
diff --git a/server/mailrepository/mailrepository-api/src/test/java/org/apache/james/mailrepository/MailRepositoryContract.java b/server/mailrepository/mailrepository-api/src/test/java/org/apache/james/mailrepository/MailRepositoryContract.java
index 737dcda..92cd111 100644
--- a/server/mailrepository/mailrepository-api/src/test/java/org/apache/james/mailrepository/MailRepositoryContract.java
+++ b/server/mailrepository/mailrepository-api/src/test/java/org/apache/james/mailrepository/MailRepositoryContract.java
@@ -78,34 +78,40 @@ public interface MailRepositoryContract {
@Test
default void storeRegularMailShouldNotFail() throws Exception {
MailRepository testee = retrieveRepository();
- Mail email = createMail("mail1");
- testee.store(email);
+ Mail mail = createMail("mail1");
+
+ testee.store(mail);
}
@Test
default void retrieveShouldGetStoredMail() throws Exception {
MailRepository testee = retrieveRepository();
String key1 = "mail1";
- Mail email = createMail(key1);
- testee.store(email);
- assertThat(testee.retrieve(key1)).satisfies(actual -> checkMailEquality(actual, email));
+ Mail mail = createMail(key1);
+
+ testee.store(mail);
+
+ assertThat(testee.retrieve(key1)).satisfies(actual -> checkMailEquality(actual, mail));
}
@Test
default void newlyCreatedRepositoryShouldNotContainAnyMail() throws Exception {
MailRepository testee = retrieveRepository();
+
assertThat(testee.list()).isEmpty();
}
@Test
default void retrievingUnknownMailShouldReturnNull() throws Exception {
MailRepository testee = retrieveRepository();
+
assertThat(testee.retrieve("random")).isNull();
}
@Test
default void removingUnknownMailShouldHaveNoEffect() throws Exception {
MailRepository testee = retrieveRepository();
+
testee.remove("random");
}
@@ -115,8 +121,10 @@ public interface MailRepositoryContract {
String key1 = "mail1";
String key2 = "mail2";
testee.store(createMail(key1));
+
testee.store(createMail(key2));
- assertThat(testee.list()).containsExactly(key1, key2);
+
+ assertThat(testee.list()).containsOnly(key1, key2);
}
@Test
@@ -124,8 +132,10 @@ public interface MailRepositoryContract {
MailRepository testee = retrieveRepository();
String key = "mail1";
testee.store(createMail(key));
+
Mail updatedMail = createMail(key, "modified content");
testee.store(updatedMail);
+
assertThat(testee.list()).hasSize(1);
assertThat(testee.retrieve(key)).satisfies(actual -> checkMailEquality(actual, updatedMail));
}
@@ -136,8 +146,10 @@ public interface MailRepositoryContract {
String key = "mail1";
Mail mail = createMail(key);
testee.store(mail);
+
mail.setAttribute(TEST_ATTRIBUTE, "newValue");
testee.store(mail);
+
assertThat(testee.list()).hasSize(1);
assertThat(testee.retrieve(key)).satisfies(actual -> checkMailEquality(actual, mail));
}
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org