[jira] [Commented] (GUACAMOLE-680) Rearrange How Logouts are Handled

["John Pellman (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GUACAMOLE-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101825#comment-17101825 ] 

John Pellman commented on GUACAMOLE-680:
----------------------------------------

Hi,

I was curious about the current state of this issue.  I recently deployed a Guacamole test server using CAS, and, while definitely not a dealbreaker (this is an amazing piece of software and I'm extremely appreciative all of the voluntary effort that's gone into it), it's a bit inelegant that the sign out button doesn't work as expected.  The linked CAS-specific issue (GUACAMOLE-361) indicates that this issue is blocking its resolution.

I believe I found the relevant dev@ discussion [here|https://mail-archives.apache.org/mod_mbox/guacamole-dev/201812.mbox/%3Cgit-pr-346-guacamole-client%40git.apache.org%3E], and a few other posts eventually led me to the GitHub pull request [here|https://github.com/apache/guacamole-client/pull/346].  It looks like the last activity was this past December and involved a bit of code review.  Does it look like this will require more code review, or does it look like a logout-handling fix is ready to be merged into master?


> Rearrange How Logouts are Handled
> ---------------------------------
>
>                 Key: GUACAMOLE-680
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-680
>             Project: Guacamole
>          Issue Type: Improvement
>          Components: guacamole-client
>            Reporter: Nick Couchman
>            Assignee: Nick Couchman
>            Priority: Minor
>
> Rearrange how the AngularJS application handles logouts, firing a warning event before the logout occurs and then one after the logout (token deletion) has happened.  This is to prep for changes that will allow Single-Sign Out/Single Log-out to happen correctly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)