You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/02 17:57:43 UTC

[GitHub] [pulsar] merlimat commented on a change in pull request #13891: [functions] Distributed log metadata not correctly initialized

merlimat commented on a change in pull request #13891:
URL: https://github.com/apache/pulsar/pull/13891#discussion_r797866198



##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -2579,7 +2580,15 @@ public String getBookkeeperMetadataStoreUrl() {
         } else {
             // Fallback to same metadata service used by broker, adding the "metadata-store" to specify the BK
             // metadata adapter
-            return "metadata-store:" + getMetadataStoreUrl();
+            String suffix;
+            if (StringUtils.isNotBlank(metadataStoreUrl)) {

Review comment:
       wouldn't we have the same issue here if a user configure `metadataStoreUrl=my-zk:2181`? Since we're not requiring it even there.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org