[kudu] 03/04: KUDU-1938 [hms] Add HMS support for VARCHAR pt 5

[ab...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

abukor pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit 85fe726794c1f0f4cc4a3add4afbdf14fc3544ce
Author: Attila Bukor <ab...@apache.org>
AuthorDate: Wed Sep 25 17:13:36 2019 +0200

    KUDU-1938 [hms] Add HMS support for VARCHAR pt 5
    
    Change-Id: If929bd14eb8d1b2e54ea7892c2f85a3b1305c05d
    Reviewed-on: http://gerrit.cloudera.org:8080/14303
    Reviewed-by: Grant Henke <gr...@apache.org>
    Tested-by: Kudu Jenkins
---
 src/kudu/hms/hms_catalog-test.cc | 1 +
 src/kudu/hms/hms_catalog.cc      | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/src/kudu/hms/hms_catalog-test.cc b/src/kudu/hms/hms_catalog-test.cc
index 405b26f..45c9732 100644
--- a/src/kudu/hms/hms_catalog-test.cc
+++ b/src/kudu/hms/hms_catalog-test.cc
@@ -203,6 +203,7 @@ class HmsCatalogTest : public KuduTest {
     b.AddColumn("decimal32_val", DataType::DECIMAL32);
     b.AddColumn("decimal64_val", DataType::DECIMAL64);
     b.AddColumn("decimal128_val", DataType::DECIMAL128);
+    b.AddColumn("varchar_val", DataType::VARCHAR);
     return b.Build();
   }
 
diff --git a/src/kudu/hms/hms_catalog.cc b/src/kudu/hms/hms_catalog.cc
index ccf22ee..a01c4da 100644
--- a/src/kudu/hms/hms_catalog.cc
+++ b/src/kudu/hms/hms_catalog.cc
@@ -330,6 +330,8 @@ string column_to_field_type(const ColumnSchema& column) {
     case DOUBLE: return "double";
     case STRING: return "string";
     case BINARY: return "binary";
+    case VARCHAR: return Substitute("varchar($0)",
+                                    column.type_attributes().length);
     case UNIXTIME_MICROS: return "timestamp";
     default: LOG(FATAL) << "unhandled column type: " << column.TypeToString();
   }