[GitHub] jeongyooneo commented on a change in pull request #30: [NEMO-63] On-demand dynamic optimization metric aggregation

[GitBox <gi...@apache.org>]

jeongyooneo commented on a change in pull request #30: [NEMO-63] On-demand dynamic optimization metric aggregation
URL: https://github.com/apache/incubator-nemo/pull/30#discussion_r194646153
 
 

 ##########
 File path: common/src/main/java/edu/snu/nemo/common/ir/vertex/MetricCollectionBarrierVertex.java
 ##########
 @@ -29,7 +29,9 @@
  */
 public final class MetricCollectionBarrierVertex<T> extends IRVertex {
   // Partition ID to Size data
 
 Review comment:
   It would have been great only if we can extract block id from task id. But unfortunately, currently block id cannot be extracted from task id and vice versa.
   
   Block id requires runtime edge id which cannot be parsed from task id.
   Task id requires stage id which cannot be parsed from block id.
   
   I think this problem will be naturally handled with NEMO-100, via refactoring RuntimeIdGenerator.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services