You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/23 15:11:58 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #4497: kvm: FIX cpucorespersocket is not working on KVM
ustcweizhou opened a new pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497
### Description
This PR fixes the issue that cpu.corespersocket in vm details is not working on kvm.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [X] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4497: kvm: FIX cpucorespersocket is not working on KVM
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497#discussion_r531431541
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -4230,4 +4223,26 @@ public boolean isSecureMode(String bootMode) {
return false;
}
+
+ private void setCpuTopology(CpuModeDef cmd, int vcpus, Map<String, String> details) {
+ // multi cores per socket, for larger core configs
+ int numCoresPerSocket = -1;
+ if (details != null) {
+ final String coresPerSocket = details.get(VmDetailConstants.CPU_CORE_PER_SOCKET);
+ final int intCoresPerSocket = NumbersUtil.parseInt(coresPerSocket, numCoresPerSocket);
+ if (intCoresPerSocket > 0 && vcpus % intCoresPerSocket == 0) {
+ numCoresPerSocket = intCoresPerSocket;
+ }
+ }
+ if (numCoresPerSocket <= 0) {
+ if (vcpus % 6 == 0) {
+ numCoresPerSocket = 6;
+ } else if (vcpus % 4 == 0) {
Review comment:
@sureshanaparti you mean change the current behavior ? No. I am not going to change it
It worked since cloudstack 4.13 in commit 2f53295
https://issues.apache.org/jira/browse/CLOUDSTACK-5521
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4497: kvm: FIX cpucorespersocket is not working on KVM
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497#issuecomment-734721596
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4497: kvm: FIX cpucorespersocket is not working on KVM
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497#discussion_r539073448
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -4230,4 +4223,26 @@ public boolean isSecureMode(String bootMode) {
return false;
}
+
+ private void setCpuTopology(CpuModeDef cmd, int vcpus, Map<String, String> details) {
Review comment:
@sureshanaparti
I was thinking about it. at the end I decided to pass vm details based on two reasons
(1) setCpuTopology is a complete function now. if pass coresPerSocket , we need to get coresPerSocket out of the method.
(2) it is better if add more cpu settings , for example the pr #4178
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4497: kvm: FIX cpucorespersocket is not working on KVM
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497#discussion_r531387493
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -4230,4 +4223,26 @@ public boolean isSecureMode(String bootMode) {
return false;
}
+
+ private void setCpuTopology(CpuModeDef cmd, int vcpus, Map<String, String> details) {
+ // multi cores per socket, for larger core configs
+ int numCoresPerSocket = -1;
+ if (details != null) {
+ final String coresPerSocket = details.get(VmDetailConstants.CPU_CORE_PER_SOCKET);
+ final int intCoresPerSocket = NumbersUtil.parseInt(coresPerSocket, numCoresPerSocket);
+ if (intCoresPerSocket > 0 && vcpus % intCoresPerSocket == 0) {
+ numCoresPerSocket = intCoresPerSocket;
+ }
+ }
+ if (numCoresPerSocket <= 0) {
+ if (vcpus % 6 == 0) {
+ numCoresPerSocket = 6;
+ } else if (vcpus % 4 == 0) {
Review comment:
> @sureshanaparti this is the current behavior.
agree, any plan to address here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4497: kvm: FIX cpucorespersocket is not working on KVM
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497#discussion_r539200417
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -4230,4 +4223,26 @@ public boolean isSecureMode(String bootMode) {
return false;
}
+
+ private void setCpuTopology(CpuModeDef cmd, int vcpus, Map<String, String> details) {
Review comment:
@sureshanaparti yes. but I need to discuss with @div8cn about some details. it will be an improvement in 4.16
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4497: kvm: FIX cpucorespersocket is not working on KVM
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497#issuecomment-741797849
@weizhouapache can you investigate and send a PR fix asap, or revert?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4497: kvm: FIX cpucorespersocket is not working on KVM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497#issuecomment-734938803
<b>Trillian test result (tid-3275)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30597 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4497-t3275-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4497: kvm: FIX cpucorespersocket is not working on KVM
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497#issuecomment-733605341
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4497: kvm: FIX cpucorespersocket is not working on KVM
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497#discussion_r539078136
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -4230,4 +4223,26 @@ public boolean isSecureMode(String bootMode) {
return false;
}
+
+ private void setCpuTopology(CpuModeDef cmd, int vcpus, Map<String, String> details) {
Review comment:
> @sureshanaparti
> I was thinking about it. at the end I decided to pass vm details based on two reasons
> (1) setCpuTopology is a complete function now. if pass coresPerSocket , we need to get coresPerSocket out of the method.
> (2) it is better if add more cpu settings , for example the pr #4178
Ok @weizhouapache so going forward, cpu hyperthreading detail mentioned in PR #4178 will be added to this method, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4497: kvm: FIX cpucorespersocket is not working on KVM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497#issuecomment-734721897
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4497: kvm: FIX cpucorespersocket is not working on KVM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497#issuecomment-733606114
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4497: kvm: FIX cpucorespersocket is not working on KVM
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497#discussion_r539064235
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -4230,4 +4223,26 @@ public boolean isSecureMode(String bootMode) {
return false;
}
+
+ private void setCpuTopology(CpuModeDef cmd, int vcpus, Map<String, String> details) {
Review comment:
@ustcweizhou possible to pass _coresPerSocket_ here, instead complete VM _details_ here ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4497: kvm: FIX cpucorespersocket is not working on KVM
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497#discussion_r539235897
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -4230,4 +4223,26 @@ public boolean isSecureMode(String bootMode) {
return false;
}
+
+ private void setCpuTopology(CpuModeDef cmd, int vcpus, Map<String, String> details) {
Review comment:
@sureshanaparti yes, this is a bug which should be fixed in 4.14 and 4.15.
the other pr is an improvement. it will not impact this pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4497: kvm: FIX cpucorespersocket is not working on KVM
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497#issuecomment-741805618
> @weizhouapache can you investigate and send a PR fix asap, or revert?
@rhtyd I will create a pr soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4497: kvm: FIX cpucorespersocket is not working on KVM
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497#discussion_r539227236
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -4230,4 +4223,26 @@ public boolean isSecureMode(String bootMode) {
return false;
}
+
+ private void setCpuTopology(CpuModeDef cmd, int vcpus, Map<String, String> details) {
Review comment:
> @sureshanaparti yes. but I need to discuss with @div8cn about some details. it will be an improvement in 4.16
OK, Pls update details here. As this PR is targeted for 4.14.1.0, the proposed changes with cpu hyperthreading detail will be targeted for 4.16, Right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4497: kvm: FIX cpucorespersocket is not working on KVM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497#issuecomment-733639872
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2435
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4497: kvm: FIX cpucorespersocket is not working on KVM
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497#discussion_r531034220
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -4230,4 +4223,26 @@ public boolean isSecureMode(String bootMode) {
return false;
}
+
+ private void setCpuTopology(CpuModeDef cmd, int vcpus, Map<String, String> details) {
+ // multi cores per socket, for larger core configs
+ int numCoresPerSocket = -1;
+ if (details != null) {
+ final String coresPerSocket = details.get(VmDetailConstants.CPU_CORE_PER_SOCKET);
+ final int intCoresPerSocket = NumbersUtil.parseInt(coresPerSocket, numCoresPerSocket);
+ if (intCoresPerSocket > 0 && vcpus % intCoresPerSocket == 0) {
+ numCoresPerSocket = intCoresPerSocket;
+ }
+ }
+ if (numCoresPerSocket <= 0) {
+ if (vcpus % 6 == 0) {
+ numCoresPerSocket = 6;
+ } else if (vcpus % 4 == 0) {
Review comment:
@sureshanaparti this is the current behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4497: kvm: FIX cpucorespersocket is not working on KVM
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497#issuecomment-741793169
i have an offering with 3 cores 256 MHz and get a vm with
```
...
<vcpu placement='static'>3</vcpu>
<cputune>
<shares>384</shares>
</cputune>
...
<cpu>
<topology sockets='3' cores='1' threads='1'/>
</cpu>
```
default was
```
...
<vcpu placement='static'>1</vcpu>
<cputune>
<shares>250</shares>
</cputune>
...
<cpu>
<topology sockets='1' cores='1' threads='1'/>
</cpu>
...
...
```
QED
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4497: kvm: FIX cpucorespersocket is not working on KVM
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497#discussion_r531009458
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -4230,4 +4223,26 @@ public boolean isSecureMode(String bootMode) {
return false;
}
+
+ private void setCpuTopology(CpuModeDef cmd, int vcpus, Map<String, String> details) {
+ // multi cores per socket, for larger core configs
+ int numCoresPerSocket = -1;
+ if (details != null) {
+ final String coresPerSocket = details.get(VmDetailConstants.CPU_CORE_PER_SOCKET);
+ final int intCoresPerSocket = NumbersUtil.parseInt(coresPerSocket, numCoresPerSocket);
+ if (intCoresPerSocket > 0 && vcpus % intCoresPerSocket == 0) {
+ numCoresPerSocket = intCoresPerSocket;
+ }
+ }
+ if (numCoresPerSocket <= 0) {
+ if (vcpus % 6 == 0) {
+ numCoresPerSocket = 6;
+ } else if (vcpus % 4 == 0) {
Review comment:
when vcpus are 8, it is considered as 4 cores per socket here, instead 8 cores.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4497: kvm: FIX cpucorespersocket is not working on KVM
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497#discussion_r533089630
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -4230,4 +4223,26 @@ public boolean isSecureMode(String bootMode) {
return false;
}
+
+ private void setCpuTopology(CpuModeDef cmd, int vcpus, Map<String, String> details) {
+ // multi cores per socket, for larger core configs
+ int numCoresPerSocket = -1;
+ if (details != null) {
+ final String coresPerSocket = details.get(VmDetailConstants.CPU_CORE_PER_SOCKET);
+ final int intCoresPerSocket = NumbersUtil.parseInt(coresPerSocket, numCoresPerSocket);
+ if (intCoresPerSocket > 0 && vcpus % intCoresPerSocket == 0) {
+ numCoresPerSocket = intCoresPerSocket;
+ }
+ }
+ if (numCoresPerSocket <= 0) {
+ if (vcpus % 6 == 0) {
+ numCoresPerSocket = 6;
+ } else if (vcpus % 4 == 0) {
Review comment:
> @sureshanaparti you mean change the current behavior ? No. I am not going to change it
> It worked since cloudstack 4.13 in commit [2f53295](https://github.com/apache/cloudstack/commit/2f53295151820c56c683ed280691ebd479d25ec2)
> https://issues.apache.org/jira/browse/CLOUDSTACK-5521
ok @weizhouapache so no change in the behavior. thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #4497: kvm: FIX cpucorespersocket is not working on KVM
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4497: kvm: FIX cpucorespersocket is not working on KVM
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497#issuecomment-741796362
> i have an offering with 3 cores 256 MHz and get a vm with
>
> ```
> ...
> <vcpu placement='static'>3</vcpu>
> <cputune>
> <shares>384</shares>
> </cputune>
> ...
> <cpu>
> <topology sockets='3' cores='1' threads='1'/>
> </cpu>
> ```
>
> default was
>
> ```
> ...
> <vcpu placement='static'>1</vcpu>
> <cputune>
> <shares>250</shares>
> </cputune>
> ...
> <cpu>
> <topology sockets='1' cores='1' threads='1'/>
> </cpu>
> ...
> ...
> ```
>
> QED
@DaanHoogland wait,it might be a bug............
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org