You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by ah...@apache.org on 2017/03/31 14:35:08 UTC

[2/2] git commit: [flex-falcon] [refs/heads/develop] - block some goog classes from the list

block some goog classes from the list


Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/4930a2a5
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/4930a2a5
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/4930a2a5

Branch: refs/heads/develop
Commit: 4930a2a57534c3104a3867c9c40e57cb4498b595
Parents: f0315f6
Author: Alex Harui <ah...@apache.org>
Authored: Fri Mar 31 07:31:13 2017 -0700
Committer: Alex Harui <ah...@apache.org>
Committed: Fri Mar 31 07:31:13 2017 -0700

----------------------------------------------------------------------
 .../org/apache/flex/compiler/internal/graph/GoogDepsWriter.java     | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/4930a2a5/compiler-jx/src/main/java/org/apache/flex/compiler/internal/graph/GoogDepsWriter.java
----------------------------------------------------------------------
diff --git a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/graph/GoogDepsWriter.java b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/graph/GoogDepsWriter.java
index 48937fd..9d3439f 100644
--- a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/graph/GoogDepsWriter.java
+++ b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/graph/GoogDepsWriter.java
@@ -219,6 +219,7 @@ public class GoogDepsWriter {
 			for (ICompilationUnit unit : order)
 			{
 				String name = requireMap2.get(unit);
+				if (isGoogClass(name)) continue;
 				GoogDep dep = depMap.get(name);
 				if (dep == null)
 					System.out.println("No GoogDep for " + name);


Re: [2/2] git commit: [flex-falcon] [refs/heads/develop] - block some goog classes from the list

Posted by Harbs <ha...@gmail.com>.
These commits seem to fix the latest problems, but I’m still having the missing Application dependencies.

Harbs

> On Mar 31, 2017, at 10:35 AM, aharui@apache.org wrote:
> 
> block some goog classes from the list
> 
> 
> Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/4930a2a5
> Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/4930a2a5
> Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/4930a2a5
> 
> Branch: refs/heads/develop
> Commit: 4930a2a57534c3104a3867c9c40e57cb4498b595
> Parents: f0315f6
> Author: Alex Harui <ah...@apache.org>
> Authored: Fri Mar 31 07:31:13 2017 -0700
> Committer: Alex Harui <ah...@apache.org>
> Committed: Fri Mar 31 07:31:13 2017 -0700
> 
> ----------------------------------------------------------------------
> .../org/apache/flex/compiler/internal/graph/GoogDepsWriter.java     | 1 +
> 1 file changed, 1 insertion(+)
> ----------------------------------------------------------------------
> 
> 
> http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/4930a2a5/compiler-jx/src/main/java/org/apache/flex/compiler/internal/graph/GoogDepsWriter.java
> ----------------------------------------------------------------------
> diff --git a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/graph/GoogDepsWriter.java b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/graph/GoogDepsWriter.java
> index 48937fd..9d3439f 100644
> --- a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/graph/GoogDepsWriter.java
> +++ b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/graph/GoogDepsWriter.java
> @@ -219,6 +219,7 @@ public class GoogDepsWriter {
> 			for (ICompilationUnit unit : order)
> 			{
> 				String name = requireMap2.get(unit);
> +				if (isGoogClass(name)) continue;
> 				GoogDep dep = depMap.get(name);
> 				if (dep == null)
> 					System.out.println("No GoogDep for " + name);
>