You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by yi...@apache.org on 2023/09/15 16:10:32 UTC
[hudi] branch master updated: [MINOR] Close record readers in TestHoodieReaderWriterBase after use during tests (#9504)
This is an automated email from the ASF dual-hosted git repository.
yihua pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hudi.git
The following commit(s) were added to refs/heads/master by this push:
new ead5171e2a6 [MINOR] Close record readers in TestHoodieReaderWriterBase after use during tests (#9504)
ead5171e2a6 is described below
commit ead5171e2a6cdb56214667ea5bfeff1b1bcfd461
Author: xuzifu666 <xu...@zepp.com>
AuthorDate: Sat Sep 16 00:10:24 2023 +0800
[MINOR] Close record readers in TestHoodieReaderWriterBase after use during tests (#9504)
Co-authored-by: xuyu <11...@vivo.com>
Co-authored-by: Y Ethan Guo <et...@gmail.com>
---
.../io/storage/TestHoodieReaderWriterBase.java | 30 ++++++++++++----------
1 file changed, 16 insertions(+), 14 deletions(-)
diff --git a/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/io/storage/TestHoodieReaderWriterBase.java b/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/io/storage/TestHoodieReaderWriterBase.java
index 86859ea7ca1..f6e0fa8f416 100644
--- a/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/io/storage/TestHoodieReaderWriterBase.java
+++ b/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/io/storage/TestHoodieReaderWriterBase.java
@@ -92,19 +92,20 @@ public abstract class TestHoodieReaderWriterBase {
Configuration conf = new Configuration();
verifyMetadata(conf);
- HoodieAvroFileReader hoodieReader = createReader(conf);
- BloomFilter filter = hoodieReader.readBloomFilter();
- for (int i = 0; i < NUM_RECORDS; i++) {
- String key = "key" + String.format("%02d", i);
- assertTrue(filter.mightContain(key));
+ try (HoodieAvroFileReader hoodieReader = createReader(conf)) {
+ BloomFilter filter = hoodieReader.readBloomFilter();
+ for (int i = 0; i < NUM_RECORDS; i++) {
+ String key = "key" + String.format("%02d", i);
+ assertTrue(filter.mightContain(key));
+ }
+ assertFalse(filter.mightContain("non-existent-key"));
+ assertEquals(avroSchema, hoodieReader.getSchema());
+ assertEquals(NUM_RECORDS, hoodieReader.getTotalRecords());
+ String[] minMaxRecordKeys = hoodieReader.readMinMaxRecordKeys();
+ assertEquals(2, minMaxRecordKeys.length);
+ assertEquals("key00", minMaxRecordKeys[0]);
+ assertEquals("key" + (NUM_RECORDS - 1), minMaxRecordKeys[1]);
}
- assertFalse(filter.mightContain("non-existent-key"));
- assertEquals(avroSchema, hoodieReader.getSchema());
- assertEquals(NUM_RECORDS, hoodieReader.getTotalRecords());
- String[] minMaxRecordKeys = hoodieReader.readMinMaxRecordKeys();
- assertEquals(2, minMaxRecordKeys.length);
- assertEquals("key00", minMaxRecordKeys[0]);
- assertEquals("key" + (NUM_RECORDS - 1), minMaxRecordKeys[1]);
}
@Test
@@ -156,8 +157,9 @@ public abstract class TestHoodieReaderWriterBase {
public void testWriteReadWithEvolvedSchema(String evolvedSchemaPath) throws Exception {
writeFileWithSimpleSchema();
Configuration conf = new Configuration();
- HoodieAvroFileReader hoodieReader = createReader(conf);
- verifyReaderWithSchema(evolvedSchemaPath, hoodieReader);
+ try (HoodieAvroFileReader hoodieReader = createReader(conf)) {
+ verifyReaderWithSchema(evolvedSchemaPath, hoodieReader);
+ }
}
@Test