You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by di...@apache.org on 2022/04/12 14:33:24 UTC
[superset] branch master updated: Remove TwoTone icons (#19666)
This is an automated email from the ASF dual-hosted git repository.
diegopucci pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 6a3220f905 Remove TwoTone icons (#19666)
6a3220f905 is described below
commit 6a3220f905e6381cc33be83bdd39125b06132bd5
Author: Geido <60...@users.noreply.github.com>
AuthorDate: Tue Apr 12 17:33:12 2022 +0300
Remove TwoTone icons (#19666)
---
superset-frontend/src/components/Icons/AntdEnhanced.tsx | 1 +
superset-frontend/src/components/Icons/IconType.ts | 1 -
superset-frontend/src/components/Icons/Icons.stories.tsx | 5 -----
3 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/superset-frontend/src/components/Icons/AntdEnhanced.tsx b/superset-frontend/src/components/Icons/AntdEnhanced.tsx
index 6d72e00251..484e8ce6e3 100644
--- a/superset-frontend/src/components/Icons/AntdEnhanced.tsx
+++ b/superset-frontend/src/components/Icons/AntdEnhanced.tsx
@@ -23,6 +23,7 @@ import { StyledIcon } from './Icon';
import IconType from './IconType';
const AntdEnhancedIcons = Object.keys(AntdIcons)
+ .filter(k => !k.includes('TwoTone'))
.map(k => ({
[k]: (props: IconType) => (
<StyledIcon component={AntdIcons[k]} {...props} />
diff --git a/superset-frontend/src/components/Icons/IconType.ts b/superset-frontend/src/components/Icons/IconType.ts
index 7371007bf2..41a4089e12 100644
--- a/superset-frontend/src/components/Icons/IconType.ts
+++ b/superset-frontend/src/components/Icons/IconType.ts
@@ -21,7 +21,6 @@ import { IconComponentProps } from '@ant-design/icons/lib/components/Icon';
type AntdIconType = IconComponentProps;
type IconType = AntdIconType & {
iconColor?: string;
- twoToneColor?: string;
iconSize?: 'xs' | 's' | 'm' | 'l' | 'xl' | 'xxl';
};
diff --git a/superset-frontend/src/components/Icons/Icons.stories.tsx b/superset-frontend/src/components/Icons/Icons.stories.tsx
index e2a3944eb4..2012bd9b50 100644
--- a/superset-frontend/src/components/Icons/Icons.stories.tsx
+++ b/superset-frontend/src/components/Icons/Icons.stories.tsx
@@ -78,11 +78,6 @@ InteractiveIcons.argTypes = {
defaultValue: null,
control: { type: 'select', options: palette },
},
- // @TODO twoToneColor is being ignored
- twoToneColor: {
- defaultValue: null,
- control: { type: 'select', options: palette },
- },
theme: {
table: {
disable: true,