You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/12/08 08:09:29 UTC

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5753: server: Fix NPE while deleting a domain

weizhouapache commented on a change in pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#discussion_r764630129



##########
File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -4923,6 +4923,7 @@ public boolean releasePublicIpRange(final long vlanDbId, final long userId, fina
         VlanVO vlan = _vlanDao.findById(vlanDbId);
         if(vlan == null) {
             s_logger.warn("VLAN information for Account '" + caller + "', User '" + userId + "' VLAN '" + vlanDbId + "' is null. This is NPE situation.");
+            return false;

Review comment:
       @ravening 
   return true or false ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org