You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "guoxiangCN (via GitHub)" <gi...@apache.org> on 2023/03/01 15:48:45 UTC

[GitHub] [incubator-kvrocks] guoxiangCN opened a new pull request, #1293: feat: add explicit fallthrough in the replication state transmission

guoxiangCN opened a new pull request, #1293:
URL: https://github.com/apache/incubator-kvrocks/pull/1293

   I found that this project completely adopts c++17, so I'm not going to use the following tedious macro definitions：
   ```
   #if HAS_CPP17_ATTRIBUTE(fallthrough)
   #  define FALLTHROUGH [[fallthrough]]
   #elif defined(__clang__)
   #  define FALLTHROUGH [[clang::fallthrough]]
   #elif GCC_VERSION >= 700 && \
       (!defined(__EDG_VERSION__) || __EDG_VERSION__ >= 520)
   #  define FALLTHROUGH [[gnu::fallthrough]]
   #else
   #  define FALLTHROUGH
   #endif
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1293: feat: add explicit fallthrough in the replication state transmission

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #1293:
URL: https://github.com/apache/incubator-kvrocks/pull/1293#issuecomment-1451282924

   @guoxiangCN Thanks for your contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice merged pull request #1293: feat: add explicit fallthrough in the replication state transmission

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice merged PR #1293:
URL: https://github.com/apache/incubator-kvrocks/pull/1293


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org