You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/08/25 13:33:14 UTC
[GitHub] [doris] GoGoWen opened a new pull request, #12081: [Fix](BE) update pid file after be launch succeed
GoGoWen opened a new pull request, #12081:
URL: https://github.com/apache/doris/pull/12081
# Proposed changes
This pr going to write pid to pid file after be is started. Before the pid will write to pid file even be is start failed, which will cause pid to be overwrite by run "sh start_be.sh --daemon" when the be is already started.
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] GoGoWen commented on pull request #12081: [Fix](BE) update pid file after be launch succeed
Posted by GitBox <gi...@apache.org>.
GoGoWen commented on PR #12081:
URL: https://github.com/apache/doris/pull/12081#issuecomment-1233661936
>
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] GoGoWen commented on pull request #12081: [Fix](BE) update pid file after be launch succeed
Posted by GitBox <gi...@apache.org>.
GoGoWen commented on PR #12081:
URL: https://github.com/apache/doris/pull/12081#issuecomment-1228070098
I think it is no need to wrap write/read pidfile into a function, Because
seems no elsewhere in our code to use it.
camby ***@***.***> 于2022年8月25日周四 22:13写道：
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In be/src/service/doris_main.cpp
> <https://github.com/apache/doris/pull/12081#discussion_r955022656>:
>
> > @@ -488,6 +465,28 @@ int main(int argc, char** argv) {
> }
> #endif
>
> + // open pid file, obtain file lock and save pid
>
> as we need to move the code location, is it better wrap these codes into a
> function?
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/doris/pull/12081#pullrequestreview-1085529071>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ATST3BELCDV7XGW3AUDAVPTV255P7ANCNFSM57TEKHYA>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on a diff in pull request #12081: [Fix](BE) update pid file after be launch succeed
Posted by GitBox <gi...@apache.org>.
cambyzju commented on code in PR #12081:
URL: https://github.com/apache/doris/pull/12081#discussion_r955022656
##########
be/src/service/doris_main.cpp:
##########
@@ -488,6 +465,28 @@ int main(int argc, char** argv) {
}
#endif
+ // open pid file, obtain file lock and save pid
Review Comment:
as we need to move the code location, is it better wrap these codes into a function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12081: [Fix](BE) update pid file after be launch succeed
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12081:
URL: https://github.com/apache/doris/pull/12081#issuecomment-1475448484
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #12081: [Fix](BE) update pid file after be launch succeed
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #12081:
URL: https://github.com/apache/doris/pull/12081#issuecomment-1240401634
when BE is already started, then run "sh start_be.sh --daemon", be.pid file will be overwritten, Do you mean this?
At present, start_be.sh will check if PID process already exists and throw error info if it does.
In some situations, the PID in be.pid file is not the actual PID of doris_be, and if run start_be.sh, the be.pid file will indeed be overwritten， for example， if run this `for i in {1..10};do bash start_be.sh --daemon & done`, the pid in be.pid is probably wrong，and if run start_be.sh again, the be.pid file will indeed be overwritten.
So, it looks like this pr didn't really fix the problem.
any other idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] closed pull request #12081: [Fix](BE) update pid file after be launch succeed
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #12081: [Fix](BE) update pid file after be launch succeed
URL: https://github.com/apache/doris/pull/12081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org