You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "doug-ba (via GitHub)" <gi...@apache.org> on 2024/03/22 21:55:57 UTC
[PR] add ability to use separate disk for zookeeper tx log [pulsar-helm-chart]
doug-ba opened a new pull request, #476:
URL: https://github.com/apache/pulsar-helm-chart/pull/476
Fixes #475
### Motivation
Putting the zookeeper transaction log on a separate volume improves performance.
### Modifications
Adds the ability to optionally add a PVC for the zookeeper transaction log and configure zookeeper to use it.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add ability to use separate disk for zookeeper tx log [pulsar-helm-chart]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #476:
URL: https://github.com/apache/pulsar-helm-chart/pull/476#issuecomment-2018723477
> @lhotari is there any chance you can also review this one?
@doug-ba thanks for the great contributions! I'll provide a review tomorrow since I missed the reviews today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add ability to use separate disk for zookeeper tx log [pulsar-helm-chart]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #476:
URL: https://github.com/apache/pulsar-helm-chart/pull/476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add ability to use separate disk for zookeeper tx log [pulsar-helm-chart]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #476:
URL: https://github.com/apache/pulsar-helm-chart/pull/476#discussion_r1539133218
##########
charts/pulsar/templates/zookeeper-configmap.yaml:
##########
@@ -29,6 +29,9 @@ metadata:
component: {{ .Values.zookeeper.component }}
data:
dataDir: /pulsar/data/zookeeper
+ {{- if .Values.zookeeper.volumes.useSeparateDiskForTxlog }}
+ PULSAR_PREFIX_dataLogDir: data-log
Review Comment:
```suggestion
PULSAR_PREFIX_dataLogDir: /pulsar/data-log
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add ability to use separate disk for zookeeper tx log [pulsar-helm-chart]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #476:
URL: https://github.com/apache/pulsar-helm-chart/pull/476#discussion_r1539133218
##########
charts/pulsar/templates/zookeeper-configmap.yaml:
##########
@@ -29,6 +29,9 @@ metadata:
component: {{ .Values.zookeeper.component }}
data:
dataDir: /pulsar/data/zookeeper
+ {{- if .Values.zookeeper.volumes.useSeparateDiskForTxlog }}
+ PULSAR_PREFIX_dataLogDir: data-log
Review Comment:
Use absolute path:
```suggestion
PULSAR_PREFIX_dataLogDir: /pulsar/data-log
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add ability to use separate disk for zookeeper tx log [pulsar-helm-chart]
Posted by "doug-ba (via GitHub)" <gi...@apache.org>.
doug-ba commented on PR #476:
URL: https://github.com/apache/pulsar-helm-chart/pull/476#issuecomment-2018663967
@lhotari is there any chance you can also review this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org