You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/05/28 01:47:37 UTC
[GitHub] [rocketmq-externals] PatrickkZ opened a new pull request #717: add logstash-output-rocketmq java plugin
PatrickkZ opened a new pull request #717:
URL: https://github.com/apache/rocketmq-externals/pull/717
## What is the purpose of the change
add a logstash-output-rocketmq java plugin
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [✓] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [✓] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [✓] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [✓] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [✓] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] vongosling closed pull request #717: add logstash-output-rocketmq java plugin
Posted by GitBox <gi...@apache.org>.
vongosling closed pull request #717:
URL: https://github.com/apache/rocketmq-externals/pull/717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] vongosling commented on pull request #717: add logstash-output-rocketmq java plugin
Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #717:
URL: https://github.com/apache/rocketmq-externals/pull/717#issuecomment-851113417
see https://github.com/apache/rocketmq-externals/pull/722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] githublaohu commented on pull request #717: [ISSUE #713]add logstash-output-rocketmq java plugin
Posted by GitBox <gi...@apache.org>.
githublaohu commented on pull request #717:
URL: https://github.com/apache/rocketmq-externals/pull/717#issuecomment-877923618
@PatrickkZ 你好，如果看下消息或者邮件，麻烦回复下。我会协助你完成这个pr。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] githublaohu commented on pull request #717: [ISSUE #713]add logstash-output-rocketmq java plugin
Posted by GitBox <gi...@apache.org>.
githublaohu commented on pull request #717:
URL: https://github.com/apache/rocketmq-externals/pull/717#issuecomment-877800749
按照README.md 文档里面的说明，构建项目失败。
`
> Task :compileJava
/leaning/space-work/java-study/rocketmq-externals/logstash-output-rocketmq/src/main/java/org/logstashplugins/RocketMQ.java:3: 错误: 程序包co.elastic.logstash.api不存在
import co.elastic.logstash.api.Configuration;
`
logstash-api这个依赖找不到
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] vongosling edited a comment on pull request #717: add logstash-output-rocketmq java plugin
Posted by GitBox <gi...@apache.org>.
vongosling edited a comment on pull request #717:
URL: https://github.com/apache/rocketmq-externals/pull/717#issuecomment-851309355
You could label this topic as homework@RongtongJin . and pls follow other pr topics([ISSUES #issue number]). This is the first correct step for your participation. @PatrickkZ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] vongosling commented on pull request #717: add logstash-output-rocketmq java plugin
Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #717:
URL: https://github.com/apache/rocketmq-externals/pull/717#issuecomment-851309355
You could label this topic as homework@RongtongJin . and pls follow other pr topics. This is the first correct step for your participation. @PatrickkZ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] githublaohu commented on pull request #717: [ISSUE #713]add logstash-output-rocketmq java plugin
Posted by GitBox <gi...@apache.org>.
githublaohu commented on pull request #717:
URL: https://github.com/apache/rocketmq-externals/pull/717#issuecomment-877783410
1. 麻烦提供下 如果验证这个插件
2. 麻烦，说下一些配置文件的作用
1. 是否能提供下 maven的构建方式，目前整个rocketmq都是maven构建的。
3. 麻烦优化功能与结构
4. 麻烦在文件里面，写入apache 2.0协议头
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] RongtongJin commented on pull request #717: add logstash-output-rocketmq java plugin
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on pull request #717:
URL: https://github.com/apache/rocketmq-externals/pull/717#issuecomment-851238968
Hi, @vongosling，this is a topic of cooperation with universities, so different students will submit logstash related PR for the rocketmq community. We can help review the code and help them merge if they meet the standards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org