You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@samza.apache.org by GitBox <gi...@apache.org> on 2019/03/12 08:30:02 UTC

[GitHub] [samza] dxichen commented on a change in pull request #950: SAMZA-2126: Bug fixes for batch-mode generated stream specs

dxichen commented on a change in pull request #950: SAMZA-2126: Bug fixes for batch-mode generated stream specs
URL: https://github.com/apache/samza/pull/950#discussion_r264557242
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/execution/StreamEdge.java
 ##########
 @@ -75,7 +75,9 @@ StreamSpec getStreamSpec() {
     StreamSpec spec = (partitions == PARTITIONS_UNKNOWN) ?
         streamSpec : streamSpec.copyWithPartitionCount(partitions);
 
-    if (isIntermediate) {
+    // Append unique id to the batch intermediate streams
+    // Check the physical stream name is already generated first
+    if (isIntermediate && spec.getId().equals(spec.getPhysicalName())) {
 
 Review comment:
   Could there be a case where the Id and the physical name are not set to the same value for batch? In either case, we should add a comment about how we can guarantee this block is only for batch. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services