You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/05/22 23:36:52 UTC
Review Request 21829: Uninlined large function from usage.hpp
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21829/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Till Toenshoff.
Repository: mesos-git
Description
-------
see summary. This also causes problems when building executables that link against libmesos and include mesos_containerizer.hpp
Diffs
-----
src/Makefile.am ae576c5eca2eb8787b5a742cd7c5651904f360b2
src/usage/usage.hpp af04a6ae5191a154904ca26fb19dd594c4da9246
Diff: https://reviews.apache.org/r/21829/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 21829: Uninlined large function from usage.hpp
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21829/
-----------------------------------------------------------
(Updated May 27, 2014, 3:08 p.m.)
Review request for mesos, Benjamin Hindman and Till Toenshoff.
Changes
-------
removed comment
Bugs: MESOS-1412
https://issues.apache.org/jira/browse/MESOS-1412
Repository: mesos-git
Description
-------
see summary. This also causes problems when building executables that link against libmesos and include mesos_containerizer.hpp
Diffs (updated)
-----
src/Makefile.am ae576c5eca2eb8787b5a742cd7c5651904f360b2
src/usage/usage.hpp af04a6ae5191a154904ca26fb19dd594c4da9246
src/usage/usage.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/21829/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 21829: Uninlined large function from usage.hpp
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21829/#review44056
-----------------------------------------------------------
Ship it!
src/usage/usage.cpp
<https://reviews.apache.org/r/21829/#comment78366>
Kill this. The same comment exists in the header file.
- Vinod Kone
On May 22, 2014, 9:51 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21829/
> -----------------------------------------------------------
>
> (Updated May 22, 2014, 9:51 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
>
>
> Bugs: MESOS-1412
> https://issues.apache.org/jira/browse/MESOS-1412
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary. This also causes problems when building executables that link against libmesos and include mesos_containerizer.hpp
>
>
> Diffs
> -----
>
> src/Makefile.am ae576c5eca2eb8787b5a742cd7c5651904f360b2
> src/usage/usage.hpp af04a6ae5191a154904ca26fb19dd594c4da9246
> src/usage/usage.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21829/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 21829: Uninlined large function from usage.hpp
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21829/
-----------------------------------------------------------
(Updated May 22, 2014, 2:51 p.m.)
Review request for mesos, Benjamin Hindman and Till Toenshoff.
Changes
-------
adding bug reference - no functional change.
Bugs: MESOS-1412
https://issues.apache.org/jira/browse/MESOS-1412
Repository: mesos-git
Description
-------
see summary. This also causes problems when building executables that link against libmesos and include mesos_containerizer.hpp
Diffs
-----
src/Makefile.am ae576c5eca2eb8787b5a742cd7c5651904f360b2
src/usage/usage.hpp af04a6ae5191a154904ca26fb19dd594c4da9246
src/usage/usage.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/21829/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 21829: Uninlined large function from usage.hpp
Posted by Dominic Hamon <dh...@twopensource.com>.
True, but adding inline to a large function like this makes me antsy.
Moving it to its own source file also reduces the dependency requirements
when including the header.
On Thu, May 22, 2014 at 2:49 PM, Benjamin Mahler
<be...@gmail.com>wrote:
> What were the linking problems here? It just looks like the 'inline'
> keyword was missing?
>
>
> On Thu, May 22, 2014 at 2:45 PM, Till Toenshoff <to...@me.com> wrote:
>
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/21829/#review43784
>> -----------------------------------------------------------
>>
>> Ship it!
>>
>>
>> Ship it!
>>
>> Thanks for this quick and proper fix, Dominic.
>>
>> - Till Toenshoff
>>
>>
>> On May 22, 2014, 9:40 p.m., Dominic Hamon wrote:
>> >
>> > -----------------------------------------------------------
>> > This is an automatically generated e-mail. To reply, visit:
>> > https://reviews.apache.org/r/21829/
>> > -----------------------------------------------------------
>> >
>> > (Updated May 22, 2014, 9:40 p.m.)
>> >
>> >
>> > Review request for mesos, Benjamin Hindman and Till Toenshoff.
>> >
>> >
>> > Repository: mesos-git
>> >
>> >
>> > Description
>> > -------
>> >
>> > see summary. This also causes problems when building executables that
>> link against libmesos and include mesos_containerizer.hpp
>> >
>> >
>> > Diffs
>> > -----
>> >
>> > src/Makefile.am ae576c5eca2eb8787b5a742cd7c5651904f360b2
>> > src/usage/usage.hpp af04a6ae5191a154904ca26fb19dd594c4da9246
>> > src/usage/usage.cpp PRE-CREATION
>> >
>> > Diff: https://reviews.apache.org/r/21829/diff/
>> >
>> >
>> > Testing
>> > -------
>> >
>> > make check
>> >
>> >
>> > Thanks,
>> >
>> > Dominic Hamon
>> >
>> >
>>
>>
>
Re: Review Request 21829: Uninlined large function from usage.hpp
Posted by Benjamin Mahler <be...@gmail.com>.
What were the linking problems here? It just looks like the 'inline'
keyword was missing?
On Thu, May 22, 2014 at 2:45 PM, Till Toenshoff <to...@me.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21829/#review43784
> -----------------------------------------------------------
>
> Ship it!
>
>
> Ship it!
>
> Thanks for this quick and proper fix, Dominic.
>
> - Till Toenshoff
>
>
> On May 22, 2014, 9:40 p.m., Dominic Hamon wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/21829/
> > -----------------------------------------------------------
> >
> > (Updated May 22, 2014, 9:40 p.m.)
> >
> >
> > Review request for mesos, Benjamin Hindman and Till Toenshoff.
> >
> >
> > Repository: mesos-git
> >
> >
> > Description
> > -------
> >
> > see summary. This also causes problems when building executables that
> link against libmesos and include mesos_containerizer.hpp
> >
> >
> > Diffs
> > -----
> >
> > src/Makefile.am ae576c5eca2eb8787b5a742cd7c5651904f360b2
> > src/usage/usage.hpp af04a6ae5191a154904ca26fb19dd594c4da9246
> > src/usage/usage.cpp PRE-CREATION
> >
> > Diff: https://reviews.apache.org/r/21829/diff/
> >
> >
> > Testing
> > -------
> >
> > make check
> >
> >
> > Thanks,
> >
> > Dominic Hamon
> >
> >
>
>
Re: Review Request 21829: Uninlined large function from usage.hpp
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21829/#review43784
-----------------------------------------------------------
Ship it!
Ship it!
Thanks for this quick and proper fix, Dominic.
- Till Toenshoff
On May 22, 2014, 9:40 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21829/
> -----------------------------------------------------------
>
> (Updated May 22, 2014, 9:40 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary. This also causes problems when building executables that link against libmesos and include mesos_containerizer.hpp
>
>
> Diffs
> -----
>
> src/Makefile.am ae576c5eca2eb8787b5a742cd7c5651904f360b2
> src/usage/usage.hpp af04a6ae5191a154904ca26fb19dd594c4da9246
> src/usage/usage.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21829/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 21829: Uninlined large function from usage.hpp
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21829/
-----------------------------------------------------------
(Updated May 22, 2014, 2:40 p.m.)
Review request for mesos, Benjamin Hindman and Till Toenshoff.
Changes
-------
added missing new file.
Repository: mesos-git
Description
-------
see summary. This also causes problems when building executables that link against libmesos and include mesos_containerizer.hpp
Diffs (updated)
-----
src/Makefile.am ae576c5eca2eb8787b5a742cd7c5651904f360b2
src/usage/usage.hpp af04a6ae5191a154904ca26fb19dd594c4da9246
src/usage/usage.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/21829/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 21829: Uninlined large function from usage.hpp
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21829/
-----------------------------------------------------------
(Updated May 22, 2014, 2:39 p.m.)
Review request for mesos, Benjamin Hindman and Till Toenshoff.
Repository: mesos-git
Description
-------
see summary. This also causes problems when building executables that link against libmesos and include mesos_containerizer.hpp
Diffs (updated)
-----
src/Makefile.am ae576c5eca2eb8787b5a742cd7c5651904f360b2
src/usage/usage.hpp af04a6ae5191a154904ca26fb19dd594c4da9246
Diff: https://reviews.apache.org/r/21829/diff/
Testing
-------
make check
Thanks,
Dominic Hamon