You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Swapnil M Mane (JIRA)" <ji...@apache.org> on 2019/04/23 05:27:00 UTC

[jira] [Comment Edited] (OFBIZ-10939) @Override annotations should be used when possible

    [ https://issues.apache.org/jira/browse/OFBIZ-10939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823691#comment-16823691 ] 

Swapnil M Mane edited comment on OFBIZ-10939 at 4/23/19 5:26 AM:
-----------------------------------------------------------------

Hi [~mthl] ,
On cursory view, the patch looks good to me, +1 to proceed with this change.
Thanks for your work!


was (Author: swapnilmmane):
Hi [~mthl] ,
On cursery view, the patch looks good to me, +1 to proceed with this change.
Thanks for your work!

> @Override annotations should be used when possible
> --------------------------------------------------
>
>                 Key: OFBIZ-10939
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10939
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Assignee: Mathieu Lirzin
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-10939_Use-the-Override-annotation.patch
>
>
> The ‘@Override’ annotation helps readers to understand that the method
> at hand is overriding a super class or implementing an interface.
> Additionally it allows the compiler to check if the methods annotated
> with ‘@Override’ are actually implementing an abstract method.
> Using that annotation makes ‘@see foo.bar.ParentClass#myMethod’
> comments useless.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)