[GitHub] [airflow] nuclearpinguin commented on a change in pull request #5766: [AIRFLOW-4230] BigQuery schema update options should be a list

[GitBox <gi...@apache.org>]

nuclearpinguin commented on a change in pull request #5766: [AIRFLOW-4230] BigQuery schema update options should be a list
URL: https://github.com/apache/airflow/pull/5766#discussion_r312427302
 
 

 ##########
 File path: airflow/contrib/hooks/bigquery_hook.py
 ##########
 @@ -737,7 +737,7 @@ def run_query(self,
         :type labels: dict
         :param schema_update_options: Allows the schema of the destination
             table to be updated as a side effect of the query job.
-        :type schema_update_options: tuple
+        :type schema_update_options: list
 
 Review comment:
   In fact this could be set, list or tuple. Main problem is that there is a type validation preformed in `run_query` method. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services