You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "abraham-menyhart (via GitHub)" <gi...@apache.org> on 2023/07/04 11:10:24 UTC
[GitHub] [fineract] abraham-menyhart opened a new pull request, #3286: FINERACT-1724: Approval limit calculation modification
abraham-menyhart opened a new pull request, #3286:
URL: https://github.com/apache/fineract/pull/3286
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #3286: FINERACT-1724: Approval limit calculation modification
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #3286:
URL: https://github.com/apache/fineract/pull/3286#discussion_r1252687168
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -2668,8 +2668,11 @@ private void compareDisbursedToApprovedOrProposedPrincipal(BigDecimal disbursedA
if (this.loanProduct().isDisallowExpectedDisbursements() && this.loanProduct().isAllowApprovedDisbursedAmountsOverApplied()) {
BigDecimal maxDisbursedAmount = getOverAppliedMax();
- if (disbursedAmount.compareTo(maxDisbursedAmount) > 0) {
- final String errorMessage = "Loan disbursal amount can't be greater than maximum applied loan amount calculation.";
+ if (totalDisbursed.compareTo(maxDisbursedAmount) > 0) {
Review Comment:
Are you sure the `totalDisbursed` is containing this "newly" disbursed amount already?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] abraham-menyhart commented on pull request #3286: FINERACT-1724: Approval limit calculation modification
Posted by "abraham-menyhart (via GitHub)" <gi...@apache.org>.
abraham-menyhart commented on PR #3286:
URL: https://github.com/apache/fineract/pull/3286#issuecomment-1621521447
> Please see my comments and please add test cases which validate your fix!
@adamsaghy can you please recheck? I added an integration test to validate this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] abraham-menyhart commented on pull request #3286: FINERACT-1724: Approval limit calculation modification
Posted by "abraham-menyhart (via GitHub)" <gi...@apache.org>.
abraham-menyhart commented on PR #3286:
URL: https://github.com/apache/fineract/pull/3286#issuecomment-1620047699
I'll write test cases in the fineract-test repository.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy merged pull request #3286: FINERACT-1724: Approval limit calculation modification
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #3286:
URL: https://github.com/apache/fineract/pull/3286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] abraham-menyhart commented on a diff in pull request #3286: FINERACT-1724: Approval limit calculation modification
Posted by "abraham-menyhart (via GitHub)" <gi...@apache.org>.
abraham-menyhart commented on code in PR #3286:
URL: https://github.com/apache/fineract/pull/3286#discussion_r1252803338
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -2668,8 +2668,11 @@ private void compareDisbursedToApprovedOrProposedPrincipal(BigDecimal disbursedA
if (this.loanProduct().isDisallowExpectedDisbursements() && this.loanProduct().isAllowApprovedDisbursedAmountsOverApplied()) {
BigDecimal maxDisbursedAmount = getOverAppliedMax();
- if (disbursedAmount.compareTo(maxDisbursedAmount) > 0) {
- final String errorMessage = "Loan disbursal amount can't be greater than maximum applied loan amount calculation.";
+ if (totalDisbursed.compareTo(maxDisbursedAmount) > 0) {
Review Comment:
Yes, I just double checked it, and it does contain the newly disbursed amount as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org