You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "TakaHiR07 (via GitHub)" <gi...@apache.org> on 2023/06/09 03:18:27 UTC
[GitHub] [pulsar] TakaHiR07 opened a new pull request, #19815: [fix] [txn] fix consumer can receive aborted txn message when readType is replay
TakaHiR07 opened a new pull request, #19815:
URL: https://github.com/apache/pulsar/pull/19815
Master Issue: #19814
### Motivation
When server try to dispatch message in PersistentDispatcherMultipleConsumers, if consumer restart, the entries may skip filterEntriesForConsumer() and directly go to "No consumers found with available permits, storing {} positions for later replay".
Then when consumer replay entries, the entries would also skip filterEntriesForConsumer(), so the aborted txn message would not be filtered.
### Modifications
also filter the aborted txn message in filterEntriesForConsumer() when readType is replay
### Does this pull request potentially affect one of the following parts:
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
- [ ] `doc`
- [ ] `doc-required`
- [x] `doc-not-needed`
- [ ] `doc-complete`
### Matching PR in forked repository
PR in forked repository: https://github.com/TakaHiR07/pulsar/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyepianzhou closed pull request #19815: [fix] [txn] fix consumer can receive aborted txn message when readType is replay
Posted by "liangyepianzhou (via GitHub)" <gi...@apache.org>.
liangyepianzhou closed pull request #19815: [fix] [txn] fix consumer can receive aborted txn message when readType is replay
URL: https://github.com/apache/pulsar/pull/19815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #19815: [fix] [txn] fix consumer can receive aborted txn message when readType is replay
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19815:
URL: https://github.com/apache/pulsar/pull/19815#issuecomment-1501992460
## [Codecov](https://codecov.io/gh/apache/pulsar/pull/19815?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19815](https://codecov.io/gh/apache/pulsar/pull/19815?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (97ca951) into [master](https://codecov.io/gh/apache/pulsar/commit/eb3169937e93d87d7587331aab18077849e14ca7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eb31699) will **decrease** coverage by `29.57%`.
> The diff coverage is `5.69%`.
[](https://codecov.io/gh/apache/pulsar/pull/19815?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19815 +/- ##
=============================================
- Coverage 61.78% 32.21% -29.57%
+ Complexity 25988 293 -25695
=============================================
Files 1853 1682 -171
Lines 136062 128777 -7285
Branches 14974 14405 -569
=============================================
- Hits 84064 41486 -42578
- Misses 44334 81163 +36829
+ Partials 7664 6128 -1536
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.43% <5.69%> (?)` | |
| systests | `25.33% <5.69%> (+0.10%)` | :arrow_up: |
| unittests | `19.22% <5.27%> (-40.19%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/19815?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java](https://codecov.io/gh/apache/pulsar/pull/19815?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL01hbmFnZWRMZWRnZXJJbXBsLmphdmE=) | `45.34% <0.00%> (-33.64%)` | :arrow_down: |
| [...org/apache/bookkeeper/mledger/impl/OpAddEntry.java](https://codecov.io/gh/apache/pulsar/pull/19815?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL09wQWRkRW50cnkuamF2YQ==) | `53.33% <0.00%> (-14.20%)` | :arrow_down: |
| [...er/mledger/intercept/ManagedLedgerInterceptor.java](https://codecov.io/gh/apache/pulsar/pull/19815?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbnRlcmNlcHQvTWFuYWdlZExlZGdlckludGVyY2VwdG9yLmphdmE=) | `33.33% <0.00%> (-66.67%)` | :arrow_down: |
| [...pulsar/broker/admin/impl/PersistentTopicsBase.java](https://codecov.io/gh/apache/pulsar/pull/19815?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi9pbXBsL1BlcnNpc3RlbnRUb3BpY3NCYXNlLmphdmE=) | `8.65% <0.00%> (-50.66%)` | :arrow_down: |
| [...broker/intercept/ManagedLedgerInterceptorImpl.java](https://codecov.io/gh/apache/pulsar/pull/19815?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9pbnRlcmNlcHQvTWFuYWdlZExlZGdlckludGVyY2VwdG9ySW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...xtensions/channel/ServiceUnitStateChannelImpl.java](https://codecov.io/gh/apache/pulsar/pull/19815?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9sb2FkYmFsYW5jZS9leHRlbnNpb25zL2NoYW5uZWwvU2VydmljZVVuaXRTdGF0ZUNoYW5uZWxJbXBsLmphdmE=) | `0.67% <0.00%> (+0.14%)` | :arrow_up: |
| [...tensions/filter/AntiAffinityGroupPolicyFilter.java](https://codecov.io/gh/apache/pulsar/pull/19815?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9sb2FkYmFsYW5jZS9leHRlbnNpb25zL2ZpbHRlci9BbnRpQWZmaW5pdHlHcm91cFBvbGljeUZpbHRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...r/loadbalance/extensions/manager/SplitManager.java](https://codecov.io/gh/apache/pulsar/pull/19815?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9sb2FkYmFsYW5jZS9leHRlbnNpb25zL21hbmFnZXIvU3BsaXRNYW5hZ2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...er/loadbalance/extensions/models/SplitCounter.java](https://codecov.io/gh/apache/pulsar/pull/19815?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9sb2FkYmFsYW5jZS9leHRlbnNpb25zL21vZGVscy9TcGxpdENvdW50ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/loadbalance/extensions/models/SplitDecision.java](https://codecov.io/gh/apache/pulsar/pull/19815?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9sb2FkYmFsYW5jZS9leHRlbnNpb25zL21vZGVscy9TcGxpdERlY2lzaW9uLmphdmE=) | `0.00% <ø> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/pulsar/pull/19815?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [1246 files with indirect coverage changes](https://codecov.io/gh/apache/pulsar/pull/19815/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #19815: [fix] [txn] fix consumer can receive aborted txn message when readType is replay
Posted by "poorbarcode (via GitHub)" <gi...@apache.org>.
poorbarcode commented on PR #19815:
URL: https://github.com/apache/pulsar/pull/19815#issuecomment-1501931746
@congbobo184 Could you take a look again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #19815: [fix] [txn] fix consumer can receive aborted txn message when readType is replay
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- closed pull request #19815: [fix] [txn] fix consumer can receive aborted txn message when readType is replay
URL: https://github.com/apache/pulsar/pull/19815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on pull request #19815: [fix] [txn] fix consumer can receive aborted txn message when readType is replay
Posted by "congbobo184 (via GitHub)" <gi...@apache.org>.
congbobo184 commented on PR #19815:
URL: https://github.com/apache/pulsar/pull/19815#issuecomment-1469631066
nice cath! could you please add a test for it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #19815: [fix] [txn] fix consumer can receive aborted txn message when readType is replay
Posted by "poorbarcode (via GitHub)" <gi...@apache.org>.
poorbarcode commented on PR #19815:
URL: https://github.com/apache/pulsar/pull/19815#issuecomment-1501913244
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] TakaHiR07 commented on pull request #19815: [fix] [txn] fix consumer can receive aborted txn message when readType is replay
Posted by "TakaHiR07 (via GitHub)" <gi...@apache.org>.
TakaHiR07 commented on PR #19815:
URL: https://github.com/apache/pulsar/pull/19815#issuecomment-1469661373
> nice cath! could you please add a test for it ?
Ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #19815: [fix] [txn] fix consumer can receive aborted txn message when readType is replay
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19815:
URL: https://github.com/apache/pulsar/pull/19815#issuecomment-1544990498
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #19815: [fix] [txn] fix consumer can receive aborted txn message when readType is replay
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #19815:
URL: https://github.com/apache/pulsar/pull/19815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #19815: [fix] [txn] fix consumer can receive aborted txn message when readType is replay
Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on PR #19815:
URL: https://github.com/apache/pulsar/pull/19815#issuecomment-1610271797
As discussed on the mailing list https://lists.apache.org/thread/w4jzk27qhtosgsz7l9bmhf1t7o9mxjhp, there is no plan to release 2.9.6, so I am going to remove the release/2.9.6 label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #19815: [fix] [txn] fix consumer can receive aborted txn message when readType is replay
Posted by "poorbarcode (via GitHub)" <gi...@apache.org>.
poorbarcode commented on PR #19815:
URL: https://github.com/apache/pulsar/pull/19815#issuecomment-1476239813
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] TakaHiR07 commented on pull request #19815: [fix] [txn] fix consumer can receive aborted txn message when readType is replay
Posted by "TakaHiR07 (via GitHub)" <gi...@apache.org>.
TakaHiR07 commented on PR #19815:
URL: https://github.com/apache/pulsar/pull/19815#issuecomment-1471445702
> nice cath! could you please add a test for it ?
Having done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #19815: [fix] [txn] fix consumer can receive aborted txn message when readType is replay
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- closed pull request #19815: [fix] [txn] fix consumer can receive aborted txn message when readType is replay
URL: https://github.com/apache/pulsar/pull/19815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org