You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@doris.apache.org by GitBox <gi...@apache.org> on 2019/04/08 07:20:43 UTC

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #887: Fix BE unit tests

chaoyli commented on a change in pull request #887: Fix BE unit tests
URL: https://github.com/apache/incubator-doris/pull/887#discussion_r272908771
 
 

 ##########
 File path: be/src/olap/row_block.cpp
 ##########
 @@ -38,18 +38,33 @@ namespace doris {
 
 RowBlock::RowBlock(const TabletSchema* schema) :
         _capacity(0),
-        _schema(schema) {
+        _schema(schema),
+        _columns(nullptr) {
+    if (_schema != nullptr) {
 
 Review comment:
   if _schema is nullptr, all following operations is no-sense.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org