You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by on...@apache.org on 2016/06/19 22:00:44 UTC
svn commit: r1749210 - in /poi/trunk/src:
java/org/apache/poi/hssf/usermodel/HSSFSheet.java
testcases/org/apache/poi/ss/usermodel/BaseTestSheetUpdateArrayFormulas.java
Author: onealj
Date: Sun Jun 19 22:00:44 2016
New Revision: 1749210
URL: http://svn.apache.org/viewvc?rev=1749210&view=rev
Log:
bug 56958: patch from Yaniv Kunda: check that cells containing array formulas do not belong to a merged region
Modified:
poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java
poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestSheetUpdateArrayFormulas.java
Modified: poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java?rev=1749210&r1=1749209&r2=1749210&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java Sun Jun 19 22:00:44 2016
@@ -749,9 +749,7 @@ public final class HSSFSheet implements
if (cell.isPartOfArrayFormulaGroup()) {
CellRangeAddress arrayRange = cell.getArrayFormulaRange();
- if (arrayRange.getNumberOfCells() > 1 &&
- (arrayRange.isInRange(region.getFirstRow(), region.getFirstColumn()) ||
- arrayRange.isInRange(region.getFirstRow(), region.getFirstColumn()))) {
+ if (arrayRange.getNumberOfCells() > 1 && region.intersects(arrayRange)) {
String msg = "The range " + region.formatAsString() + " intersects with a multi-cell array formula. " +
"You cannot merge cells of an array.";
throw new IllegalStateException(msg);
Modified: poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestSheetUpdateArrayFormulas.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestSheetUpdateArrayFormulas.java?rev=1749210&r1=1749209&r2=1749210&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestSheetUpdateArrayFormulas.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestSheetUpdateArrayFormulas.java Sun Jun 19 22:00:44 2016
@@ -27,6 +27,7 @@ import static org.junit.Assert.assertTru
import static org.junit.Assert.fail;
import java.io.IOException;
+import java.util.Arrays;
import org.apache.poi.ss.ITestDataProvider;
import org.apache.poi.ss.formula.FormulaParseException;
@@ -467,7 +468,7 @@ public abstract class BaseTestSheetUpdat
}
@Test
- public void testModifyArrayCells_mergeCells() throws IOException {
+ public void testModifyArrayCells_mergeCellsSingle() throws IOException {
Workbook workbook = _testDataProvider.createWorkbook();
Sheet sheet = workbook.createSheet();
assertEquals(0, sheet.getNumMergedRegions());
@@ -481,19 +482,55 @@ public abstract class BaseTestSheetUpdat
assertEquals(Cell.CELL_TYPE_FORMULA, scell.getCellType());
assertTrue(scell.isPartOfArrayFormulaGroup());
assertEquals(1, sheet.getNumMergedRegions());
+
+ workbook.close();
+ }
+
+ @Test
+ public void testModifyArrayCells_mergeCellsMulti() throws IOException {
+ Workbook workbook = _testDataProvider.createWorkbook();
+ Sheet sheet = workbook.createSheet();
+ int expectedNumMergedRegions = 0;
+ assertEquals(expectedNumMergedRegions, sheet.getNumMergedRegions());
- //we cannot merge cells included in an array formula
- sheet.setArrayFormula("A1:A3*B1:B3", CellRangeAddress.valueOf("C1:C3"));
- CellRangeAddress cra = CellRangeAddress.valueOf("C1:C3");
- try {
- sheet.addMergedRegion(cra);
- fail("expected exception");
- } catch (IllegalStateException e){
- String msg = "The range "+cra.formatAsString()+" intersects with a multi-cell array formula. You cannot merge cells of an array.";
- assertEquals(msg, e.getMessage());
+ // we cannot merge cells included in an array formula
+ sheet.setArrayFormula("A1:A4*B1:B4", CellRangeAddress.valueOf("C2:F5"));
+ for (String ref : Arrays.asList(
+ "C2:F5", // identity
+ "D3:E4", "B1:G6", // contains
+ "B1:C2", "F1:G2", "F5:G6", "B5:C6", // 1x1 corner intersection
+ "B1:C6", "B1:G2", "F1:G6", "B5:G6", // 1-row/1-column intersection
+ "B1:D3", "E1:G3", "E4:G6", "B4:D6", // 2x2 corner intersection
+ "B1:D6", "B1:G3", "E1:G6", "B4:G6" // 2-row/2-column intersection
+ )) {
+ CellRangeAddress cra = CellRangeAddress.valueOf(ref);
+ try {
+ sheet.addMergedRegion(cra);
+ fail("expected exception with ref " + ref);
+ } catch (IllegalStateException e) {
+ String msg = "The range "+cra.formatAsString()+" intersects with a multi-cell array formula. You cannot merge cells of an array.";
+ assertEquals(msg, e.getMessage());
+ }
}
//the number of merged regions remains the same
- assertEquals(1, sheet.getNumMergedRegions());
+ assertEquals(expectedNumMergedRegions, sheet.getNumMergedRegions());
+
+ // we can merge non-intersecting cells
+ for (String ref : Arrays.asList(
+ "C1:F1", //above
+ "G2:G5", //right
+ "C6:F6", //bottom
+ "B2:B5", "H7:J9")) {
+ CellRangeAddress cra = CellRangeAddress.valueOf(ref);
+ try {
+ sheet.addMergedRegion(cra);
+ expectedNumMergedRegions++;
+ assertEquals(expectedNumMergedRegions, sheet.getNumMergedRegions());
+ } catch (IllegalStateException e) {
+ fail("did not expect exception with ref: " + ref + "\n" + e.getMessage());
+ }
+ }
+
workbook.close();
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org