You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Christian Schneider (JIRA)" <ji...@apache.org> on 2008/05/18 01:05:43 UTC
[jira] Created: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Break dependency cycle between camel and camel.impl
---------------------------------------------------
Key: CAMEL-527
URL: https://issues.apache.org/activemq/browse/CAMEL-527
Project: Apache Camel
Issue Type: Improvement
Components: camel-core
Affects Versions: 1.3.0
Reporter: Christian Schneider
Fix For: 1.4.0
Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43228#action_43228 ]
Hadrian Zbarcea commented on CAMEL-527:
---------------------------------------
Not sure. I know we impacted activemq and servicemix. What I'd suggest is to send a message on the users mailing list, assuming that those who use camel and may be impacted subscribed to that list, send urls to the jiras related to refactoring and ask them to subscribe to those jiras if they want to and shout if they think what we do impacts them in a negative way.
I will send such a mail later today if no one objects.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: producertemplate.patch, servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43232#action_43232 ]
Claus Ibsen commented on CAMEL-527:
-----------------------------------
Hadrian, if the breaking API was the we moved CamelTemplate to impl package, we could move it back again?
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: producertemplate.patch, servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42990#action_42990 ]
Claus Ibsen commented on CAMEL-527:
-----------------------------------
Christian, I would like to get the license for the great product s101. You can get in touch with my by email if you do not want to discuss on this public form
davsclaus at apache dot org
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42962#action_42962 ]
Claus Ibsen commented on CAMEL-527:
-----------------------------------
Christian, why should ServiceHelper be moved to the camel package? Why cant it stay in camel.util as all the other helper classes does?
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Fix For: 1.4.0
>
> Attachments: servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43005#action_43005 ]
Christian Schneider commented on CAMEL-527:
-------------------------------------------
I have only checked and compiled camel-core. There I changed all references to CamelTemplate. If you say you want to keep CamelTemplate does this mean you want to keep a copy of the DefaultProducertTemplate in camel named CamelTemplate and mark this class as deprecated? I think this could be a good thing. We could describe in the comments of the deprecated class how to get a ProducerTemplate from CamelContext so people learn how they should chaange their code.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: producertemplate.patch, servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42966#action_42966 ]
Christian Schneider commented on CAMEL-527:
-------------------------------------------
The problem with ServiceHelper is that ServiceSupport uses ServiceHelper. So we get a new dependency between camel and util. Currently there are 12 references from camel to util and 245 references from util to camel. So I think util needs camel but we have a chance to cut the other direction. 2 of the 12 references from camel to util come from ServiceSupport the other 10 come from CamelTemplate. So I thought we could start with ServiceHelper and solve the problem with CamelTemplate in a new issue.
The alternative would be to try to move the whole Service thing to util. This would be ServiceHelper, ServiceSupport and Service. The problem with this is that Service is referenced from many classes in Camel. So we would make the cycle between camel and util even worse.
I think the problem with all this is that we need a util package that does not depend on camel. Somthing like base utils. Then we could move utility classes like ServiceSupport ... to this package. Our current util is to much dependent from Camel that we can hope to make it standalone.
Btw. I am using structure101 to analyse the dependencies. Do you also use this or another tool already? Normally the tool costs about 600$ but as Camel is an open source project we can get it free. If you are interested in the tool I can give you the contact from headway where I got my license. See http://activemq.apache.org/camel/acknowledgment.html
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Claus Ibsen
> Fix For: 1.4.0
>
> Attachments: servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43001#action_43001 ]
Christian Schneider commented on CAMEL-527:
-------------------------------------------
I have added a patch for the CamelTemplate stuff. I think it should work out quite well. The CamelTemplate is gone in this patch this of course means people have to adapt their code. But even if we only had moved CamelTemplate they would have to change their code as the import is from a different package. I think this way it is much cleaner and the implementation is much better encapsulated. If we document this step well it should be no big problem for people. I think the idea of decribing what we changed in Release notes and wiki is a very important thing.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: producertemplate.patch, servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen reassigned CAMEL-527:
---------------------------------
Assignee: Hadrian Zbarcea (was: Claus Ibsen)
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43235#action_43235 ]
Christian Schneider commented on CAMEL-527:
-------------------------------------------
I think moving the CamelTemplate back could be a good idea. So people do not have to change right now. But we leave it deprecated so people know it will disappear soon.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: producertemplate.patch, servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43212#action_43212 ]
Claus Ibsen commented on CAMEL-527:
-----------------------------------
Sending camel-core\src\main\java\org\apache\camel\CamelContext.java
Sending camel-core\src\main\java\org\apache\camel\EndpointInject.java
Sending camel-core\src\main\java\org\apache\camel\impl\CamelTemplate.java
Sending camel-core\src\main\java\org\apache\camel\impl\DefaultCamelContext.java
Adding camel-core\src\main\java\org\apache\camel\impl\DefaultProducerTemplate.java
Sending camel-core\src\test\java\org\apache\camel\ContextTestSupport.java
Sending camel-core\src\test\java\org\apache\camel\component\file\DirectoryCreateIssueTest.java
Sending camel-core\src\test\java\org\apache\camel\component\vm\VmRouteTest.java
Sending camel-core\src\test\java\org\apache\camel\impl\StringDataFormatTest.java
Sending camel-core\src\test\java\org\apache\camel\processor\SetOutBodyTest.java
Sending camel-core\src\test\java\org\apache\camel\processor\TryProcessorHandleTest.java
Sending camel-core\src\test\java\org\apache\camel\processor\aggregator\AlbertoAggregatorTest.java
Sending components\camel-jms\src\test\java\org\apache\camel\component\jms\JmsRouteRequestReplyTest.java
Transmitting file data .............
Committed revision 662986.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: producertemplate.patch, servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43229#action_43229 ]
Claus Ibsen commented on CAMEL-527:
-----------------------------------
Good idea Hadrian.
Myabe some of the bigger changes should be target for Camel 2.0? To cater for ActiveMQ and SericeMix being able to work with less hazzle from us.
Maybe we could also get some feedback what the impacts was in ActiveMQ and/or SerivceMix?
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: producertemplate.patch, servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42999#action_42999 ]
Hadrian Zbarcea commented on CAMEL-527:
---------------------------------------
@Claus
Having a plan is good, for now I only went after the low hanging fruits.
I like the ProducerTemplate factory idea. Not sure about renaming CamelTemplate. I think I'd leave it as CamelContext as people may be used to it by now.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42989#action_42989 ]
Claus Ibsen commented on CAMEL-527:
-----------------------------------
CamelTemplate already have an interface = ProducerTemplate in the org.apache.camel package.
So what is needed is how the end-users retrieve an instance of the ProducerTemplate?
CamelTemplate is however much used in the documentation and examples how to use Camel so if its changed to ProducerTemplate then it can also confuse people, even though ProducerTemplate is what CamelTemplate is used for - to easily produce and send exchanges.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Claus Ibsen
> Fix For: 1.4.0
>
> Attachments: servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen reassigned CAMEL-527:
---------------------------------
Assignee: Claus Ibsen
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Claus Ibsen
> Fix For: 1.4.0
>
> Attachments: servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42983#action_42983 ]
Christian Schneider commented on CAMEL-527:
-------------------------------------------
I have another idea how to solve the cycle. The references from camel to impl go from CamelTemplate to ServiceSupport. So we could move CamelTemplate to impl. Perhaps it would be a good idea to also create an interface for CamelTemplate in camel and a way to retrieve the CamelTemplate without knowing the concrete implementation. This part would solve the cycle between camel and impl.
ServiceSupport is also referenced from util.ProducerCache. As util should not reference impl we should move ProducerCache to impl. As ProducerCache is currently only referenced from CamelTemplate and the processor package this should be ok.
What do you think about this change? Is impl a good place for CamelTemplate? I am not sure about it myself as CamelTemplate is visible to Camel users. If we create an interface for CamelTemplate I think it should be ok.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Claus Ibsen
> Fix For: 1.4.0
>
> Attachments: servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43210#action_43210 ]
Claus Ibsen commented on CAMEL-527:
-----------------------------------
I am currently working on the ProducerTemplate patch, testing it before comitting it.
I have marked the old CamelTemplate as @deprecated and hinted to use ProducerTemplate instead that can be fetch using the CamelContext.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: producertemplate.patch, servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43298#action_43298 ]
Hadrian Zbarcea commented on CAMEL-527:
---------------------------------------
Wow, forgot to add a comment after committing the patch. Sorry and thanks Claus!
I actually removed the use of CamelTemplate from our code too and made CamelTemplate extend from DefaultProducerTemplate vs just being a copy.
I think we can close this, yes, there are no other tangles now. This was a big chunk of work, thanks everybody!
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: producertemplate.patch, servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hadrian Zbarcea resolved CAMEL-527.
-----------------------------------
Resolution: Fixed
As per Claus proposal, this can be closed, we have at least to other issues where we can continue the untangling work.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: producertemplate.patch, servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42994#action_42994 ]
Christian Schneider commented on CAMEL-527:
-------------------------------------------
@Hadrian: I have also seen the other cycles and thought to address them one after the other in jira issues. Do you think this is a good idea or should we rather make a plan first?
About the ProducerTemplate: For me ProducerTemplate looks great. I also have an idea how to create it. What about a factory method in CamelContext?
Like:
ProducerTemplate pt = camelContext.createProducerTemplate();
Inside the unit tests it seems there are only a few places where CamelTemplate is used directly. I think it is a good idea to stay with the name ProducerTemplate as it cleary states what you can do with it. CamelTemplate is too general.
We could then rename CamelTemplate to DefaultProducerTemplate and move it to impl. It will then be referenced only from DefaultCamelContext.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43211#action_43211 ]
Claus Ibsen commented on CAMEL-527:
-----------------------------------
I do even think we could delegate all method calls from CamelTemplate to DefaultProducerTemplate as CamelContext requires a CamelContext in its constructors. Then we can ensure that the codebase is not duplicated.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: producertemplate.patch, servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42988#action_42988 ]
Hadrian Zbarcea commented on CAMEL-527:
---------------------------------------
That would work. I took care of that, but there are a few others to sort out. I think we can remove language -> component, model -> component and model -> language. I am not sure what we can do with camel <-> model because of RouteType.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Claus Ibsen
> Fix For: 1.4.0
>
> Attachments: servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43004#action_43004 ]
Claus Ibsen commented on CAMEL-527:
-----------------------------------
We could mark CamelTemplate as @deprecated and remove it in Camel 1.5?
Christian have you compiled all the components as well to check if they use CamelTemplate - in eg. their unit tests?
Otherwise the patch looks good.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: producertemplate.patch, servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43007#action_43007 ]
Claus Ibsen commented on CAMEL-527:
-----------------------------------
Yes I would leave it as it and remove it in a future release (either Camel 1.5 or Camel 2.0).
We just need to make sure that we change all the components code as well to use ProducerTemplate and not the @deprecated CamelTemplate so when its due time it can be safely deleted from the code base.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: producertemplate.patch, servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42980#action_42980 ]
Hadrian Zbarcea commented on CAMEL-527:
---------------------------------------
fwiw, I don't think moving ServiceSupport and ServiceHelper to oac is a good idea.
My S101 shows 76 deps from impl->util and 13, from util->impl, so impl should depend on util I guess. In that case the dependency between ServiceHelper and ServiceSupport is ok the way it is.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Claus Ibsen
> Fix For: 1.4.0
>
> Attachments: servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43010#action_43010 ]
Christian Schneider commented on CAMEL-527:
-------------------------------------------
Sounds good to me
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: producertemplate.patch, servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43227#action_43227 ]
Christian Schneider commented on CAMEL-527:
-------------------------------------------
Any idea how to organize this? A mail to the respective developer lists? Which projects would you suggest to ask when we propose architectural changes that affect other projects? As soon as we know who to ask we could document this in the wiki for the future.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: producertemplate.patch, servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CAMEL-527) Break dependency cycle
between camel and camel.impl
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42988#action_42988 ]
hadrian edited comment on CAMEL-527 at 5/23/08 4:13 PM:
----------------------------------------------------------------
That would work. I took care of that, but there are a few others to sort out. I think we can remove language >> component, model >> component and model >> language. I am not sure what we can do with camel >> model because of RouteType.
was (Author: hadrian):
That would work. I took care of that, but there are a few others to sort out. I think we can remove language -> component, model -> component and model -> language. I am not sure what we can do with camel <-> model because of RouteType.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Claus Ibsen
> Fix For: 1.4.0
>
> Attachments: servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider updated CAMEL-527:
--------------------------------------
Attachment: servicehelper.patch
I have added a patch that moves ServiceHelper and ServiceSupport to the camel package like described before.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Fix For: 1.4.0
>
> Attachments: servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43015#action_43015 ]
Claus Ibsen commented on CAMEL-527:
-----------------------------------
I added a draft for the release notes
http://cwiki.apache.org/confluence/display/CAMEL/Camel+1.4.0+Release
We should state here the change of the @deprecatation of CamelTemplate and ProducerTemplate should be used instead, also with a small code sample how to get hold of a ProducerTemplate using the new method from CamelContext.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: producertemplate.patch, servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42995#action_42995 ]
Claus Ibsen commented on CAMEL-527:
-----------------------------------
@Christian
I really like your plan with the CamelTemplate moving and renaming and the factory on the CamelContext. This is +1 from me.
We should just rememeber to update all the wiki documentation that shows you can use CamelTemplate - especially the quick start guides etc.
And I do think we should start on a Camel 1.4 release notes where we state some of these new refactorings.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42859#action_42859 ]
Christian Schneider commented on CAMEL-527:
-------------------------------------------
Perhaps this was a little short sighted of me. I thought the util package would be self contained. It seems util uses camel and even camel.impl. So putting the classes there would be no good idea.
So my suggestion is to move ServiceSupport and ServiceHelper to camel this brings some more bloat to camel but at least it removes the cycle.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Fix For: 1.4.0
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43289#action_43289 ]
Claus Ibsen commented on CAMEL-527:
-----------------------------------
Hadrian, should we close this ticket now that CamelTemplate is moved back and we have fixed a few tangles that hopefully doesn't cause trouble for ServiceMix and ActiveMQ?
There are lot of other patches from Christian that we could potentially use, or postpone to Camel 2.0?
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: producertemplate.patch, servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43222#action_43222 ]
Hadrian Zbarcea commented on CAMEL-527:
---------------------------------------
Hi,
I think this kind of changes have a big impact on other projects using
camel, such as activemq and servicemix. Not only code changes are
required in these projects, but their ability to work with different
versions of camel. This has a cascading effect on users of such
projects who may have to consider updating to camel 1.4 too.
I would suggest asking their opinion in the future before making such
changes.
My $0.02,
Hadrian
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: producertemplate.patch, servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (CAMEL-527) Break dependency cycle between
camel and camel.impl
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on CAMEL-527 started by Claus Ibsen.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Claus Ibsen
> Fix For: 1.4.0
>
> Attachments: servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43278#action_43278 ]
Claus Ibsen commented on CAMEL-527:
-----------------------------------
Hadrian has moved it back.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: producertemplate.patch, servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-527) Break dependency cycle between camel
and camel.impl
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider updated CAMEL-527:
--------------------------------------
Attachment: producertemplate.patch
Move CamelTemplate to impl and rename it to DefaultProducerTemplate. Add a factory method createProducerTemplate to CamelContext. Make DefaultProducertTemplate private so it can“t be instantiated from outside impl. Change the Tests so they use the new factory method instead of diectly instantiating CamelTemplate.
> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
> Key: CAMEL-527
> URL: https://issues.apache.org/activemq/browse/CAMEL-527
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Christian Schneider
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: producertemplate.patch, servicehelper.patch
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl.
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.