[GitHub] [airflow] csm10495 commented on a diff in pull request #28752: Allow setting the name for the base container and fix longstanding bug with running quick pods

[GitBox <gi...@apache.org>]

csm10495 commented on code in PR #28752:
URL: https://github.com/apache/airflow/pull/28752#discussion_r1063075211


##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -265,7 +265,7 @@ def consume_logs(*, since_time: DateTime | None = None, follow: bool = True) ->
                 time.sleep(1)
 
     def await_container_completion(self, pod: V1Pod, container_name: str) -> None:
-        while not self.container_is_running(pod=pod, container_name=container_name):
+        while self.container_is_running(pod=pod, container_name=container_name):
             time.sleep(1)

Review Comment:
   The problem is I can't get my new unit tests for base name with get_log=False without fixing this too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org