You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/03/24 06:31:08 UTC
[GitHub] [iceberg] uncleGen opened a new pull request #2368: Core: Fix circular call in BaseMetastoreCatalog
uncleGen opened a new pull request #2368:
URL: https://github.com/apache/iceberg/pull/2368
fix #2318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #2368: Core: Fix circular call in BaseMetastoreCatalog
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #2368:
URL: https://github.com/apache/iceberg/pull/2368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] uncleGen commented on a change in pull request #2368: Core: Fix circular call in BaseMetastoreCatalog
Posted by GitBox <gi...@apache.org>.
uncleGen commented on a change in pull request #2368:
URL: https://github.com/apache/iceberg/pull/2368#discussion_r600213824
##########
File path: api/src/main/java/org/apache/iceberg/catalog/Catalog.java
##########
@@ -40,9 +40,7 @@
*
* @return this catalog's name
*/
- default String name() {
- return toString();
- }
+ String name();
Review comment:
make sense!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on a change in pull request #2368: Core: Fix circular call in BaseMetastoreCatalog
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #2368:
URL: https://github.com/apache/iceberg/pull/2368#discussion_r600211771
##########
File path: api/src/main/java/org/apache/iceberg/catalog/Catalog.java
##########
@@ -40,9 +40,7 @@
*
* @return this catalog's name
*/
- default String name() {
- return toString();
- }
+ String name();
Review comment:
This breaks the public API. Is there a way to handle it differently? Can we maybe just drop `name` from the default implementation of `toString` in the base metastore catalog? Or any other option that keeps the old API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #2368: Core: Fix circular call in BaseMetastoreCatalog
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2368:
URL: https://github.com/apache/iceberg/pull/2368#issuecomment-810475024
Thanks for fixing this, @uncleGen! And thanks for catching the API issue, @aokolnychyi!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org