You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@maven.apache.org by Benson Margulies <bi...@gmail.com> on 2014/09/10 20:10:03 UTC

https://github.com/apache/maven-scm/pull/17

Is anyone working on a fix to MRELEASE-875?

Re: https://github.com/apache/maven-scm/pull/17

Posted by Chris Graham <ch...@gmail.com>.

Hi Benson,

Perfect! Exactly what I was looking for!

Thanks!

-Chris


On Mon, Sep 15, 2014 at 8:16 PM, Benson Margulies <bi...@gmail.com>
wrote:

> Chris, See
>
> http://maven.apache.org/developers/conventions/git.html.
>
> I didn't know it existed until yesterday.
>
>
> On Mon, Sep 15, 2014 at 1:26 AM, Chris Graham <ch...@gmail.com>
> wrote:
>
> > So, if the scm stuff is in git, my original question still remains
> > unanswered.
> >
> > What are the process steps needed to go through to be able to perform
> > meaningful work in terms of working on the maven-scm modules?
> >
> > Has anyone actually documented what needs doing on the git side of
> things?
> > Creating a patch if was still based in svn, is easy enough, but for git I
> > do not have a clue.
> >
> > -Chris
> >
> > On Thu, Sep 11, 2014 at 8:13 PM, Benson Margulies <bimargulies@gmail.com
> >
> > wrote:
> >
> > > A mixture. The release plugin had not moved.
> > > On Sep 10, 2014 11:46 PM, "Chris Graham" <ch...@gmail.com> wrote:
> > >
> > > > Sorry, I thought that the plugins, the scm ones in this case, had
> moved
> > > to
> > > > git? Still in SVN? If so, then no issues.
> > > >
> > > > -Chris
> > > >
> > > > On Thu, Sep 11, 2014 at 11:43 AM, Benson Margulies <
> > > bimargulies@gmail.com>
> > > > wrote:
> > > >
> > > > > For plugins, you need mostly to make an account on Codehaus JIRA,
> > then
> > > > you
> > > > > svn checkout as per the information in the plugin's page, and then
> > you
> > > > can
> > > > > attach a patch to a JIRA.
> > > > >
> > > > >
> > > > >
> > > > > On Wed, Sep 10, 2014 at 9:37 PM, Chris Graham <
> chrisgwarp@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > Whilst not strictly related to this thread...
> > > > > >
> > > > > > Is there a document that tells us what we need to do to
> contribute?
> > > > > > How/what repos we need to clone/setup, how to generate a
> patch/pull
> > > > > request
> > > > > > etc?
> > > > > >
> > > > > > Thanks,
> > > > > >
> > > > > > -Chris
> > > > > >
> > > > > > On Thu, Sep 11, 2014 at 7:04 AM, Benson Margulies <
> > > > bimargulies@gmail.com
> > > > > >
> > > > > > wrote:
> > > > > >
> > > > > > > Of course; I'm just trying to help you get off the ground; is
> > there
> > > > > > > something else you'd like me to do?
> > > > > > >
> > > > > > > On Wed, Sep 10, 2014 at 4:58 PM, Robert Scholte <
> > > > rfscholte@apache.org>
> > > > > > > wrote:
> > > > > > >
> > > > > > > > I don't want to depend on external systems.
> > > > > > > > you could add me (rfscholte) but that'll only be for
> > reproducing
> > > > the
> > > > > > > issue.
> > > > > > > > and then I need isolate the problem and translate it to a
> > > unittest.
> > > > > > > >
> > > > > > > >
> > > > > > > > Op Wed, 10 Sep 2014 22:53:38 +0200 schreef Benson Margulies <
> > > > > > > > bimargulies@gmail.com>:
> > > > > > > >
> > > > > > > >
> > > > > > > >  Well, you'll need to push a clone where you can write, or
> tell
> > > me
> > > > > your
> > > > > > > >> github ID so I can add you as a collaborator.
> > > > > > > >>
> > > > > > > >> On Wed, Sep 10, 2014 at 4:45 PM, Robert Scholte <
> > > > > rfscholte@apache.org
> > > > > > >
> > > > > > > >> wrote:
> > > > > > > >>
> > > > > > > >>  The first step already fails on my machine.
> > > > > > > >>>
> > > > > > > >>> mvn release:prepare release:perform -B -DpushChanges=false
> > > > > > > >>>
> > > > > > > >>> I'm a bit surprised, because I see:
> > > > > > > >>> [INFO] Executing: cmd.exe /X /C "git push git@github.com:
> > > > > > bimargulies/
> > > > > > > >>> pom-file-name-tc.git
> > > > > > > >>> refs/heads/master:refs/heads/master"
> > > > > > > >>>
> > > > > > > >>> Actual failure:
> > > > > > > >>> [ERROR] Failed to execute goal org.apache.maven.plugins:
> > > > > > > >>> maven-release-plugin:2.5:prepare (default-cli) on project
> > > > > > > >>> pom-file-name-tc: Unable to commit files
> > > > > > > >>> [ERROR] Provider message:
> > > > > > > >>> [ERROR] The git-push command failed.
> > > > > > > >>> [ERROR] Command output:
> > > > > > > >>> [ERROR] Warning: Permanently added the RSA host key for IP
> > > > address
> > > > > > > >>> '192.30.252.131' to the list of known hosts.
> > > > > > > >>> [ERROR] Permission denied (publickey).
> > > > > > > >>> [ERROR] fatal: Could not read from remote repository.
> > > > > > > >>> [ERROR]
> > > > > > > >>> [ERROR] Please make sure you have the correct access rights
> > > > > > > >>> [ERROR] and the repository exists.
> > > > > > > >>>
> > > > > > > >>> As said: I want to create a *unittest*
> > > > > > > >>> If I'm correct, the status-call has the wrong arguments. So
> > > what
> > > > > > should
> > > > > > > >>> it
> > > > > > > >>> look like? What's the result of this (so I can mock the
> > > consumer)
> > > > > and
> > > > > > > >>> what
> > > > > > > >>> should the next call be?
> > > > > > > >>>
> > > > > > > >>> Robert
> > > > > > > >>>
> > > > > > > >>> Op Wed, 10 Sep 2014 21:17:10 +0200 schreef Benson
> Margulies <
> > > > > > > >>> bimargulies@gmail.com>:
> > > > > > > >>>
> > > > > > > >>>
> > > > > > > >>>  Step 1: in the top level dir of the example, run mvn
> > > > --batch-mode
> > > > > > > >>>
> > > > > > > >>>> release:prepare release:perform. All will be well. A repo
> > will
> > > > > > > populate
> > > > > > > >>>> in
> > > > > > > >>>> /tmp.
> > > > > > > >>>>
> > > > > > > >>>> Step 2: modify pom in 'second' directory to use the
> > > just-release
> > > > > > > parent
> > > > > > > >>>> pom, commit, push.
> > > > > > > >>>>
> > > > > > > >>>> Step 3: mvn release:prepare in second directory.
> > > > > > > >>>>
> > > > > > > >>>> No errors, but the pom.xml will be sitting there modified,
> > and
> > > > > there
> > > > > > > >>>> will
> > > > > > > >>>> be a tag pointing to the wrong place.
> > > > > > > >>>>
> > > > > > > >>>>
> > > > > > > >>>>
> > > > > > > >>>> On Wed, Sep 10, 2014 at 3:10 PM, Robert Scholte <
> > > > > > rfscholte@apache.org
> > > > > > > >
> > > > > > > >>>> wrote:
> > > > > > > >>>>
> > > > > > > >>>>  that's just the beginning...
> > > > > > > >>>>
> > > > > > > >>>>> so: how did you execute it? what did you get? what would
> > you
> > > > > > expect?
> > > > > > > >>>>>
> > > > > > > >>>>> Op Wed, 10 Sep 2014 20:54:49 +0200 schreef Benson
> > Margulies <
> > > > > > > >>>>> bimargulies@gmail.com>:
> > > > > > > >>>>>
> > > > > > > >>>>>
> > > > > > > >>>>>  Aha, I have one for you. https://github.com/
> > > > > > > >>>>> bimargulies/pom-file-name-tc.
> > > > > > > >>>>>
> > > > > > > >>>>>  I
> > > > > > > >>>>>> attached it to a dup JIRA which I closed, or you can
> take
> > it
> > > > as
> > > > > > you
> > > > > > > >>>>>> see
> > > > > > > >>>>>> it.
> > > > > > > >>>>>> You may in general find MRELEASE-887 helpful in this
> > > respect.
> > > > > > > >>>>>>
> > > > > > > >>>>>> On Wed, Sep 10, 2014 at 2:53 PM, Robert Scholte <
> > > > > > > rfscholte@apache.org
> > > > > > > >>>>>> >
> > > > > > > >>>>>> wrote:
> > > > > > > >>>>>>
> > > > > > > >>>>>>  Hi,
> > > > > > > >>>>>>
> > > > > > > >>>>>>
> > > > > > > >>>>>>> IIRC I didn't have enough info to make a unittest, i.e.
> > > > > reproduce
> > > > > > > >>>>>>> what
> > > > > > > >>>>>>> they get right now and what they would expect to be
> able
> > to
> > > > fix
> > > > > > it.
> > > > > > > >>>>>>> That would take me too much time to find out, so I left
> > > this
> > > > > one
> > > > > > > open
> > > > > > > >>>>>>> for
> > > > > > > >>>>>>> now.
> > > > > > > >>>>>>>
> > > > > > > >>>>>>> thanks,
> > > > > > > >>>>>>> Robert
> > > > > > > >>>>>>>
> > > > > > > >>>>>>> Op Wed, 10 Sep 2014 20:23:07 +0200 schreef Benson
> > > Margulies <
> > > > > > > >>>>>>> bimargulies@gmail.com>:
> > > > > > > >>>>>>>
> > > > > > > >>>>>>>
> > > > > > > >>>>>>>  Yes, the remarks which dribbled off pointed to
> adapting
> > > the
> > > > > fix
> > > > > > > back
> > > > > > > >>>>>>> into
> > > > > > > >>>>>>>
> > > > > > > >>>>>>>  the m-r-p.
> > > > > > > >>>>>>>
> > > > > > > >>>>>>>>
> > > > > > > >>>>>>>>
> > > > > > > >>>>>>>> On Wed, Sep 10, 2014 at 2:21 PM, Karl Heinz Marbaise <
> > > > > > > >>>>>>>> khmarbaise@gmx.de
> > > > > > > >>>>>>>> >
> > > > > > > >>>>>>>> wrote:
> > > > > > > >>>>>>>>
> > > > > > > >>>>>>>>  Hi Benson,
> > > > > > > >>>>>>>>
> > > > > > > >>>>>>>>
> > > > > > > >>>>>>>>  > Is anyone working on a fix to MRELEASE-875?
> > > > > > > >>>>>>>>>
> > > > > > > >>>>>>>>>
> > > > > > > >>>>>>>>>
> > > > > > > >>>>>>>>>   Based on JIRA it is assigned to Dominik Bartholdi
> > which
> > > > > > > requested
> > > > > > > >>>>>>>>>
> > > > > > > >>>>>>>>>>
> > > > > > > >>>>>>>>>>  reviews
> > > > > > > >>>>>>>>>>
> > > > > > > >>>>>>>>> from others on Github...
> > > > > > > >>>>>>>>>
> > > > > > > >>>>>>>>> BTW: Not working on that...
> > > > > > > >>>>>>>>>
> > > > > > > >>>>>>>>> Kind regards
> > > > > > > >>>>>>>>> Karl-Heinz Marbaise
> > > > > > > >>>>>>>>>
> > > > > > > >>>>>>>>>
> > > > > > > >>>>>>>>>
> > > > > > > >>>>>>>>>
> > > > > > > >>>>>>>>>
> > > > > > > >>>>>>>>>
> > > > > > > >>>>>>>>>
> > > > ------------------------------------------------------------
> > > > > > > >>>>>>>>> ---------
> > > > > > > >>>>>>>>> To unsubscribe, e-mail:
> > dev-unsubscribe@maven.apache.org
> > > > > > > >>>>>>>>> For additional commands, e-mail:
> > > dev-help@maven.apache.org
> > > > > > > >>>>>>>>>
> > > > > > > >>>>>>>>>
> > > > > > > >>>>>>>>>
> > > > ------------------------------------------------------------
> > > > > > > >>>>>>>>> ---------
> > > > > > > >>>>>>>>>
> > > > > > > >>>>>>>>>  To unsubscribe, e-mail:
> > > dev-unsubscribe@maven.apache.org
> > > > > > > >>>>>>>>
> > > > > > > >>>>>>> For additional commands, e-mail:
> > dev-help@maven.apache.org
> > > > > > > >>>>>>>
> > > > > > > >>>>>>>
> > > > > > > >>>>>>>
> > > ------------------------------------------------------------
> > > > > > > >>>>>>> ---------
> > > > > > > >>>>>>>
> > > > > > > >>>>>> To unsubscribe, e-mail:
> dev-unsubscribe@maven.apache.org
> > > > > > > >>>>> For additional commands, e-mail:
> dev-help@maven.apache.org
> > > > > > > >>>>>
> > > > > > > >>>>>
> > > > > > > >>>>>
> > > > > > >
> > > ---------------------------------------------------------------------
> > > > > > > >>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > > > >>> For additional commands, e-mail: dev-help@maven.apache.org
> > > > > > > >>>
> > > > > > > >>>
> > > > > > > >
> > > > ---------------------------------------------------------------------
> > > > > > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: https://github.com/apache/maven-scm/pull/17

Posted by Benson Margulies <bi...@gmail.com>.

Chris, See

http://maven.apache.org/developers/conventions/git.html.

I didn't know it existed until yesterday.


On Mon, Sep 15, 2014 at 1:26 AM, Chris Graham <ch...@gmail.com> wrote:

> So, if the scm stuff is in git, my original question still remains
> unanswered.
>
> What are the process steps needed to go through to be able to perform
> meaningful work in terms of working on the maven-scm modules?
>
> Has anyone actually documented what needs doing on the git side of things?
> Creating a patch if was still based in svn, is easy enough, but for git I
> do not have a clue.
>
> -Chris
>
> On Thu, Sep 11, 2014 at 8:13 PM, Benson Margulies <bi...@gmail.com>
> wrote:
>
> > A mixture. The release plugin had not moved.
> > On Sep 10, 2014 11:46 PM, "Chris Graham" <ch...@gmail.com> wrote:
> >
> > > Sorry, I thought that the plugins, the scm ones in this case, had moved
> > to
> > > git? Still in SVN? If so, then no issues.
> > >
> > > -Chris
> > >
> > > On Thu, Sep 11, 2014 at 11:43 AM, Benson Margulies <
> > bimargulies@gmail.com>
> > > wrote:
> > >
> > > > For plugins, you need mostly to make an account on Codehaus JIRA,
> then
> > > you
> > > > svn checkout as per the information in the plugin's page, and then
> you
> > > can
> > > > attach a patch to a JIRA.
> > > >
> > > >
> > > >
> > > > On Wed, Sep 10, 2014 at 9:37 PM, Chris Graham <ch...@gmail.com>
> > > > wrote:
> > > >
> > > > > Whilst not strictly related to this thread...
> > > > >
> > > > > Is there a document that tells us what we need to do to contribute?
> > > > > How/what repos we need to clone/setup, how to generate a patch/pull
> > > > request
> > > > > etc?
> > > > >
> > > > > Thanks,
> > > > >
> > > > > -Chris
> > > > >
> > > > > On Thu, Sep 11, 2014 at 7:04 AM, Benson Margulies <
> > > bimargulies@gmail.com
> > > > >
> > > > > wrote:
> > > > >
> > > > > > Of course; I'm just trying to help you get off the ground; is
> there
> > > > > > something else you'd like me to do?
> > > > > >
> > > > > > On Wed, Sep 10, 2014 at 4:58 PM, Robert Scholte <
> > > rfscholte@apache.org>
> > > > > > wrote:
> > > > > >
> > > > > > > I don't want to depend on external systems.
> > > > > > > you could add me (rfscholte) but that'll only be for
> reproducing
> > > the
> > > > > > issue.
> > > > > > > and then I need isolate the problem and translate it to a
> > unittest.
> > > > > > >
> > > > > > >
> > > > > > > Op Wed, 10 Sep 2014 22:53:38 +0200 schreef Benson Margulies <
> > > > > > > bimargulies@gmail.com>:
> > > > > > >
> > > > > > >
> > > > > > >  Well, you'll need to push a clone where you can write, or tell
> > me
> > > > your
> > > > > > >> github ID so I can add you as a collaborator.
> > > > > > >>
> > > > > > >> On Wed, Sep 10, 2014 at 4:45 PM, Robert Scholte <
> > > > rfscholte@apache.org
> > > > > >
> > > > > > >> wrote:
> > > > > > >>
> > > > > > >>  The first step already fails on my machine.
> > > > > > >>>
> > > > > > >>> mvn release:prepare release:perform -B -DpushChanges=false
> > > > > > >>>
> > > > > > >>> I'm a bit surprised, because I see:
> > > > > > >>> [INFO] Executing: cmd.exe /X /C "git push git@github.com:
> > > > > bimargulies/
> > > > > > >>> pom-file-name-tc.git
> > > > > > >>> refs/heads/master:refs/heads/master"
> > > > > > >>>
> > > > > > >>> Actual failure:
> > > > > > >>> [ERROR] Failed to execute goal org.apache.maven.plugins:
> > > > > > >>> maven-release-plugin:2.5:prepare (default-cli) on project
> > > > > > >>> pom-file-name-tc: Unable to commit files
> > > > > > >>> [ERROR] Provider message:
> > > > > > >>> [ERROR] The git-push command failed.
> > > > > > >>> [ERROR] Command output:
> > > > > > >>> [ERROR] Warning: Permanently added the RSA host key for IP
> > > address
> > > > > > >>> '192.30.252.131' to the list of known hosts.
> > > > > > >>> [ERROR] Permission denied (publickey).
> > > > > > >>> [ERROR] fatal: Could not read from remote repository.
> > > > > > >>> [ERROR]
> > > > > > >>> [ERROR] Please make sure you have the correct access rights
> > > > > > >>> [ERROR] and the repository exists.
> > > > > > >>>
> > > > > > >>> As said: I want to create a *unittest*
> > > > > > >>> If I'm correct, the status-call has the wrong arguments. So
> > what
> > > > > should
> > > > > > >>> it
> > > > > > >>> look like? What's the result of this (so I can mock the
> > consumer)
> > > > and
> > > > > > >>> what
> > > > > > >>> should the next call be?
> > > > > > >>>
> > > > > > >>> Robert
> > > > > > >>>
> > > > > > >>> Op Wed, 10 Sep 2014 21:17:10 +0200 schreef Benson Margulies <
> > > > > > >>> bimargulies@gmail.com>:
> > > > > > >>>
> > > > > > >>>
> > > > > > >>>  Step 1: in the top level dir of the example, run mvn
> > > --batch-mode
> > > > > > >>>
> > > > > > >>>> release:prepare release:perform. All will be well. A repo
> will
> > > > > > populate
> > > > > > >>>> in
> > > > > > >>>> /tmp.
> > > > > > >>>>
> > > > > > >>>> Step 2: modify pom in 'second' directory to use the
> > just-release
> > > > > > parent
> > > > > > >>>> pom, commit, push.
> > > > > > >>>>
> > > > > > >>>> Step 3: mvn release:prepare in second directory.
> > > > > > >>>>
> > > > > > >>>> No errors, but the pom.xml will be sitting there modified,
> and
> > > > there
> > > > > > >>>> will
> > > > > > >>>> be a tag pointing to the wrong place.
> > > > > > >>>>
> > > > > > >>>>
> > > > > > >>>>
> > > > > > >>>> On Wed, Sep 10, 2014 at 3:10 PM, Robert Scholte <
> > > > > rfscholte@apache.org
> > > > > > >
> > > > > > >>>> wrote:
> > > > > > >>>>
> > > > > > >>>>  that's just the beginning...
> > > > > > >>>>
> > > > > > >>>>> so: how did you execute it? what did you get? what would
> you
> > > > > expect?
> > > > > > >>>>>
> > > > > > >>>>> Op Wed, 10 Sep 2014 20:54:49 +0200 schreef Benson
> Margulies <
> > > > > > >>>>> bimargulies@gmail.com>:
> > > > > > >>>>>
> > > > > > >>>>>
> > > > > > >>>>>  Aha, I have one for you. https://github.com/
> > > > > > >>>>> bimargulies/pom-file-name-tc.
> > > > > > >>>>>
> > > > > > >>>>>  I
> > > > > > >>>>>> attached it to a dup JIRA which I closed, or you can take
> it
> > > as
> > > > > you
> > > > > > >>>>>> see
> > > > > > >>>>>> it.
> > > > > > >>>>>> You may in general find MRELEASE-887 helpful in this
> > respect.
> > > > > > >>>>>>
> > > > > > >>>>>> On Wed, Sep 10, 2014 at 2:53 PM, Robert Scholte <
> > > > > > rfscholte@apache.org
> > > > > > >>>>>> >
> > > > > > >>>>>> wrote:
> > > > > > >>>>>>
> > > > > > >>>>>>  Hi,
> > > > > > >>>>>>
> > > > > > >>>>>>
> > > > > > >>>>>>> IIRC I didn't have enough info to make a unittest, i.e.
> > > > reproduce
> > > > > > >>>>>>> what
> > > > > > >>>>>>> they get right now and what they would expect to be able
> to
> > > fix
> > > > > it.
> > > > > > >>>>>>> That would take me too much time to find out, so I left
> > this
> > > > one
> > > > > > open
> > > > > > >>>>>>> for
> > > > > > >>>>>>> now.
> > > > > > >>>>>>>
> > > > > > >>>>>>> thanks,
> > > > > > >>>>>>> Robert
> > > > > > >>>>>>>
> > > > > > >>>>>>> Op Wed, 10 Sep 2014 20:23:07 +0200 schreef Benson
> > Margulies <
> > > > > > >>>>>>> bimargulies@gmail.com>:
> > > > > > >>>>>>>
> > > > > > >>>>>>>
> > > > > > >>>>>>>  Yes, the remarks which dribbled off pointed to adapting
> > the
> > > > fix
> > > > > > back
> > > > > > >>>>>>> into
> > > > > > >>>>>>>
> > > > > > >>>>>>>  the m-r-p.
> > > > > > >>>>>>>
> > > > > > >>>>>>>>
> > > > > > >>>>>>>>
> > > > > > >>>>>>>> On Wed, Sep 10, 2014 at 2:21 PM, Karl Heinz Marbaise <
> > > > > > >>>>>>>> khmarbaise@gmx.de
> > > > > > >>>>>>>> >
> > > > > > >>>>>>>> wrote:
> > > > > > >>>>>>>>
> > > > > > >>>>>>>>  Hi Benson,
> > > > > > >>>>>>>>
> > > > > > >>>>>>>>
> > > > > > >>>>>>>>  > Is anyone working on a fix to MRELEASE-875?
> > > > > > >>>>>>>>>
> > > > > > >>>>>>>>>
> > > > > > >>>>>>>>>
> > > > > > >>>>>>>>>   Based on JIRA it is assigned to Dominik Bartholdi
> which
> > > > > > requested
> > > > > > >>>>>>>>>
> > > > > > >>>>>>>>>>
> > > > > > >>>>>>>>>>  reviews
> > > > > > >>>>>>>>>>
> > > > > > >>>>>>>>> from others on Github...
> > > > > > >>>>>>>>>
> > > > > > >>>>>>>>> BTW: Not working on that...
> > > > > > >>>>>>>>>
> > > > > > >>>>>>>>> Kind regards
> > > > > > >>>>>>>>> Karl-Heinz Marbaise
> > > > > > >>>>>>>>>
> > > > > > >>>>>>>>>
> > > > > > >>>>>>>>>
> > > > > > >>>>>>>>>
> > > > > > >>>>>>>>>
> > > > > > >>>>>>>>>
> > > > > > >>>>>>>>>
> > > ------------------------------------------------------------
> > > > > > >>>>>>>>> ---------
> > > > > > >>>>>>>>> To unsubscribe, e-mail:
> dev-unsubscribe@maven.apache.org
> > > > > > >>>>>>>>> For additional commands, e-mail:
> > dev-help@maven.apache.org
> > > > > > >>>>>>>>>
> > > > > > >>>>>>>>>
> > > > > > >>>>>>>>>
> > > ------------------------------------------------------------
> > > > > > >>>>>>>>> ---------
> > > > > > >>>>>>>>>
> > > > > > >>>>>>>>>  To unsubscribe, e-mail:
> > dev-unsubscribe@maven.apache.org
> > > > > > >>>>>>>>
> > > > > > >>>>>>> For additional commands, e-mail:
> dev-help@maven.apache.org
> > > > > > >>>>>>>
> > > > > > >>>>>>>
> > > > > > >>>>>>>
> > ------------------------------------------------------------
> > > > > > >>>>>>> ---------
> > > > > > >>>>>>>
> > > > > > >>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > > >>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > > > > > >>>>>
> > > > > > >>>>>
> > > > > > >>>>>
> > > > > >
> > ---------------------------------------------------------------------
> > > > > > >>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > > >>> For additional commands, e-mail: dev-help@maven.apache.org
> > > > > > >>>
> > > > > > >>>
> > > > > > >
> > > ---------------------------------------------------------------------
> > > > > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: https://github.com/apache/maven-scm/pull/17

Posted by Chris Graham <ch...@gmail.com>.

So, if the scm stuff is in git, my original question still remains
unanswered.

What are the process steps needed to go through to be able to perform
meaningful work in terms of working on the maven-scm modules?

Has anyone actually documented what needs doing on the git side of things?
Creating a patch if was still based in svn, is easy enough, but for git I
do not have a clue.

-Chris

On Thu, Sep 11, 2014 at 8:13 PM, Benson Margulies <bi...@gmail.com>
wrote:

> A mixture. The release plugin had not moved.
> On Sep 10, 2014 11:46 PM, "Chris Graham" <ch...@gmail.com> wrote:
>
> > Sorry, I thought that the plugins, the scm ones in this case, had moved
> to
> > git? Still in SVN? If so, then no issues.
> >
> > -Chris
> >
> > On Thu, Sep 11, 2014 at 11:43 AM, Benson Margulies <
> bimargulies@gmail.com>
> > wrote:
> >
> > > For plugins, you need mostly to make an account on Codehaus JIRA, then
> > you
> > > svn checkout as per the information in the plugin's page, and then you
> > can
> > > attach a patch to a JIRA.
> > >
> > >
> > >
> > > On Wed, Sep 10, 2014 at 9:37 PM, Chris Graham <ch...@gmail.com>
> > > wrote:
> > >
> > > > Whilst not strictly related to this thread...
> > > >
> > > > Is there a document that tells us what we need to do to contribute?
> > > > How/what repos we need to clone/setup, how to generate a patch/pull
> > > request
> > > > etc?
> > > >
> > > > Thanks,
> > > >
> > > > -Chris
> > > >
> > > > On Thu, Sep 11, 2014 at 7:04 AM, Benson Margulies <
> > bimargulies@gmail.com
> > > >
> > > > wrote:
> > > >
> > > > > Of course; I'm just trying to help you get off the ground; is there
> > > > > something else you'd like me to do?
> > > > >
> > > > > On Wed, Sep 10, 2014 at 4:58 PM, Robert Scholte <
> > rfscholte@apache.org>
> > > > > wrote:
> > > > >
> > > > > > I don't want to depend on external systems.
> > > > > > you could add me (rfscholte) but that'll only be for reproducing
> > the
> > > > > issue.
> > > > > > and then I need isolate the problem and translate it to a
> unittest.
> > > > > >
> > > > > >
> > > > > > Op Wed, 10 Sep 2014 22:53:38 +0200 schreef Benson Margulies <
> > > > > > bimargulies@gmail.com>:
> > > > > >
> > > > > >
> > > > > >  Well, you'll need to push a clone where you can write, or tell
> me
> > > your
> > > > > >> github ID so I can add you as a collaborator.
> > > > > >>
> > > > > >> On Wed, Sep 10, 2014 at 4:45 PM, Robert Scholte <
> > > rfscholte@apache.org
> > > > >
> > > > > >> wrote:
> > > > > >>
> > > > > >>  The first step already fails on my machine.
> > > > > >>>
> > > > > >>> mvn release:prepare release:perform -B -DpushChanges=false
> > > > > >>>
> > > > > >>> I'm a bit surprised, because I see:
> > > > > >>> [INFO] Executing: cmd.exe /X /C "git push git@github.com:
> > > > bimargulies/
> > > > > >>> pom-file-name-tc.git
> > > > > >>> refs/heads/master:refs/heads/master"
> > > > > >>>
> > > > > >>> Actual failure:
> > > > > >>> [ERROR] Failed to execute goal org.apache.maven.plugins:
> > > > > >>> maven-release-plugin:2.5:prepare (default-cli) on project
> > > > > >>> pom-file-name-tc: Unable to commit files
> > > > > >>> [ERROR] Provider message:
> > > > > >>> [ERROR] The git-push command failed.
> > > > > >>> [ERROR] Command output:
> > > > > >>> [ERROR] Warning: Permanently added the RSA host key for IP
> > address
> > > > > >>> '192.30.252.131' to the list of known hosts.
> > > > > >>> [ERROR] Permission denied (publickey).
> > > > > >>> [ERROR] fatal: Could not read from remote repository.
> > > > > >>> [ERROR]
> > > > > >>> [ERROR] Please make sure you have the correct access rights
> > > > > >>> [ERROR] and the repository exists.
> > > > > >>>
> > > > > >>> As said: I want to create a *unittest*
> > > > > >>> If I'm correct, the status-call has the wrong arguments. So
> what
> > > > should
> > > > > >>> it
> > > > > >>> look like? What's the result of this (so I can mock the
> consumer)
> > > and
> > > > > >>> what
> > > > > >>> should the next call be?
> > > > > >>>
> > > > > >>> Robert
> > > > > >>>
> > > > > >>> Op Wed, 10 Sep 2014 21:17:10 +0200 schreef Benson Margulies <
> > > > > >>> bimargulies@gmail.com>:
> > > > > >>>
> > > > > >>>
> > > > > >>>  Step 1: in the top level dir of the example, run mvn
> > --batch-mode
> > > > > >>>
> > > > > >>>> release:prepare release:perform. All will be well. A repo will
> > > > > populate
> > > > > >>>> in
> > > > > >>>> /tmp.
> > > > > >>>>
> > > > > >>>> Step 2: modify pom in 'second' directory to use the
> just-release
> > > > > parent
> > > > > >>>> pom, commit, push.
> > > > > >>>>
> > > > > >>>> Step 3: mvn release:prepare in second directory.
> > > > > >>>>
> > > > > >>>> No errors, but the pom.xml will be sitting there modified, and
> > > there
> > > > > >>>> will
> > > > > >>>> be a tag pointing to the wrong place.
> > > > > >>>>
> > > > > >>>>
> > > > > >>>>
> > > > > >>>> On Wed, Sep 10, 2014 at 3:10 PM, Robert Scholte <
> > > > rfscholte@apache.org
> > > > > >
> > > > > >>>> wrote:
> > > > > >>>>
> > > > > >>>>  that's just the beginning...
> > > > > >>>>
> > > > > >>>>> so: how did you execute it? what did you get? what would you
> > > > expect?
> > > > > >>>>>
> > > > > >>>>> Op Wed, 10 Sep 2014 20:54:49 +0200 schreef Benson Margulies <
> > > > > >>>>> bimargulies@gmail.com>:
> > > > > >>>>>
> > > > > >>>>>
> > > > > >>>>>  Aha, I have one for you. https://github.com/
> > > > > >>>>> bimargulies/pom-file-name-tc.
> > > > > >>>>>
> > > > > >>>>>  I
> > > > > >>>>>> attached it to a dup JIRA which I closed, or you can take it
> > as
> > > > you
> > > > > >>>>>> see
> > > > > >>>>>> it.
> > > > > >>>>>> You may in general find MRELEASE-887 helpful in this
> respect.
> > > > > >>>>>>
> > > > > >>>>>> On Wed, Sep 10, 2014 at 2:53 PM, Robert Scholte <
> > > > > rfscholte@apache.org
> > > > > >>>>>> >
> > > > > >>>>>> wrote:
> > > > > >>>>>>
> > > > > >>>>>>  Hi,
> > > > > >>>>>>
> > > > > >>>>>>
> > > > > >>>>>>> IIRC I didn't have enough info to make a unittest, i.e.
> > > reproduce
> > > > > >>>>>>> what
> > > > > >>>>>>> they get right now and what they would expect to be able to
> > fix
> > > > it.
> > > > > >>>>>>> That would take me too much time to find out, so I left
> this
> > > one
> > > > > open
> > > > > >>>>>>> for
> > > > > >>>>>>> now.
> > > > > >>>>>>>
> > > > > >>>>>>> thanks,
> > > > > >>>>>>> Robert
> > > > > >>>>>>>
> > > > > >>>>>>> Op Wed, 10 Sep 2014 20:23:07 +0200 schreef Benson
> Margulies <
> > > > > >>>>>>> bimargulies@gmail.com>:
> > > > > >>>>>>>
> > > > > >>>>>>>
> > > > > >>>>>>>  Yes, the remarks which dribbled off pointed to adapting
> the
> > > fix
> > > > > back
> > > > > >>>>>>> into
> > > > > >>>>>>>
> > > > > >>>>>>>  the m-r-p.
> > > > > >>>>>>>
> > > > > >>>>>>>>
> > > > > >>>>>>>>
> > > > > >>>>>>>> On Wed, Sep 10, 2014 at 2:21 PM, Karl Heinz Marbaise <
> > > > > >>>>>>>> khmarbaise@gmx.de
> > > > > >>>>>>>> >
> > > > > >>>>>>>> wrote:
> > > > > >>>>>>>>
> > > > > >>>>>>>>  Hi Benson,
> > > > > >>>>>>>>
> > > > > >>>>>>>>
> > > > > >>>>>>>>  > Is anyone working on a fix to MRELEASE-875?
> > > > > >>>>>>>>>
> > > > > >>>>>>>>>
> > > > > >>>>>>>>>
> > > > > >>>>>>>>>   Based on JIRA it is assigned to Dominik Bartholdi which
> > > > > requested
> > > > > >>>>>>>>>
> > > > > >>>>>>>>>>
> > > > > >>>>>>>>>>  reviews
> > > > > >>>>>>>>>>
> > > > > >>>>>>>>> from others on Github...
> > > > > >>>>>>>>>
> > > > > >>>>>>>>> BTW: Not working on that...
> > > > > >>>>>>>>>
> > > > > >>>>>>>>> Kind regards
> > > > > >>>>>>>>> Karl-Heinz Marbaise
> > > > > >>>>>>>>>
> > > > > >>>>>>>>>
> > > > > >>>>>>>>>
> > > > > >>>>>>>>>
> > > > > >>>>>>>>>
> > > > > >>>>>>>>>
> > > > > >>>>>>>>>
> > ------------------------------------------------------------
> > > > > >>>>>>>>> ---------
> > > > > >>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > >>>>>>>>> For additional commands, e-mail:
> dev-help@maven.apache.org
> > > > > >>>>>>>>>
> > > > > >>>>>>>>>
> > > > > >>>>>>>>>
> > ------------------------------------------------------------
> > > > > >>>>>>>>> ---------
> > > > > >>>>>>>>>
> > > > > >>>>>>>>>  To unsubscribe, e-mail:
> dev-unsubscribe@maven.apache.org
> > > > > >>>>>>>>
> > > > > >>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > > > > >>>>>>>
> > > > > >>>>>>>
> > > > > >>>>>>>
> ------------------------------------------------------------
> > > > > >>>>>>> ---------
> > > > > >>>>>>>
> > > > > >>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > >>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > > > > >>>>>
> > > > > >>>>>
> > > > > >>>>>
> > > > >
> ---------------------------------------------------------------------
> > > > > >>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > >>> For additional commands, e-mail: dev-help@maven.apache.org
> > > > > >>>
> > > > > >>>
> > > > > >
> > ---------------------------------------------------------------------
> > > > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: https://github.com/apache/maven-scm/pull/17

Posted by Benson Margulies <bi...@gmail.com>.

A mixture. The release plugin had not moved.
On Sep 10, 2014 11:46 PM, "Chris Graham" <ch...@gmail.com> wrote:

> Sorry, I thought that the plugins, the scm ones in this case, had moved to
> git? Still in SVN? If so, then no issues.
>
> -Chris
>
> On Thu, Sep 11, 2014 at 11:43 AM, Benson Margulies <bi...@gmail.com>
> wrote:
>
> > For plugins, you need mostly to make an account on Codehaus JIRA, then
> you
> > svn checkout as per the information in the plugin's page, and then you
> can
> > attach a patch to a JIRA.
> >
> >
> >
> > On Wed, Sep 10, 2014 at 9:37 PM, Chris Graham <ch...@gmail.com>
> > wrote:
> >
> > > Whilst not strictly related to this thread...
> > >
> > > Is there a document that tells us what we need to do to contribute?
> > > How/what repos we need to clone/setup, how to generate a patch/pull
> > request
> > > etc?
> > >
> > > Thanks,
> > >
> > > -Chris
> > >
> > > On Thu, Sep 11, 2014 at 7:04 AM, Benson Margulies <
> bimargulies@gmail.com
> > >
> > > wrote:
> > >
> > > > Of course; I'm just trying to help you get off the ground; is there
> > > > something else you'd like me to do?
> > > >
> > > > On Wed, Sep 10, 2014 at 4:58 PM, Robert Scholte <
> rfscholte@apache.org>
> > > > wrote:
> > > >
> > > > > I don't want to depend on external systems.
> > > > > you could add me (rfscholte) but that'll only be for reproducing
> the
> > > > issue.
> > > > > and then I need isolate the problem and translate it to a unittest.
> > > > >
> > > > >
> > > > > Op Wed, 10 Sep 2014 22:53:38 +0200 schreef Benson Margulies <
> > > > > bimargulies@gmail.com>:
> > > > >
> > > > >
> > > > >  Well, you'll need to push a clone where you can write, or tell me
> > your
> > > > >> github ID so I can add you as a collaborator.
> > > > >>
> > > > >> On Wed, Sep 10, 2014 at 4:45 PM, Robert Scholte <
> > rfscholte@apache.org
> > > >
> > > > >> wrote:
> > > > >>
> > > > >>  The first step already fails on my machine.
> > > > >>>
> > > > >>> mvn release:prepare release:perform -B -DpushChanges=false
> > > > >>>
> > > > >>> I'm a bit surprised, because I see:
> > > > >>> [INFO] Executing: cmd.exe /X /C "git push git@github.com:
> > > bimargulies/
> > > > >>> pom-file-name-tc.git
> > > > >>> refs/heads/master:refs/heads/master"
> > > > >>>
> > > > >>> Actual failure:
> > > > >>> [ERROR] Failed to execute goal org.apache.maven.plugins:
> > > > >>> maven-release-plugin:2.5:prepare (default-cli) on project
> > > > >>> pom-file-name-tc: Unable to commit files
> > > > >>> [ERROR] Provider message:
> > > > >>> [ERROR] The git-push command failed.
> > > > >>> [ERROR] Command output:
> > > > >>> [ERROR] Warning: Permanently added the RSA host key for IP
> address
> > > > >>> '192.30.252.131' to the list of known hosts.
> > > > >>> [ERROR] Permission denied (publickey).
> > > > >>> [ERROR] fatal: Could not read from remote repository.
> > > > >>> [ERROR]
> > > > >>> [ERROR] Please make sure you have the correct access rights
> > > > >>> [ERROR] and the repository exists.
> > > > >>>
> > > > >>> As said: I want to create a *unittest*
> > > > >>> If I'm correct, the status-call has the wrong arguments. So what
> > > should
> > > > >>> it
> > > > >>> look like? What's the result of this (so I can mock the consumer)
> > and
> > > > >>> what
> > > > >>> should the next call be?
> > > > >>>
> > > > >>> Robert
> > > > >>>
> > > > >>> Op Wed, 10 Sep 2014 21:17:10 +0200 schreef Benson Margulies <
> > > > >>> bimargulies@gmail.com>:
> > > > >>>
> > > > >>>
> > > > >>>  Step 1: in the top level dir of the example, run mvn
> --batch-mode
> > > > >>>
> > > > >>>> release:prepare release:perform. All will be well. A repo will
> > > > populate
> > > > >>>> in
> > > > >>>> /tmp.
> > > > >>>>
> > > > >>>> Step 2: modify pom in 'second' directory to use the just-release
> > > > parent
> > > > >>>> pom, commit, push.
> > > > >>>>
> > > > >>>> Step 3: mvn release:prepare in second directory.
> > > > >>>>
> > > > >>>> No errors, but the pom.xml will be sitting there modified, and
> > there
> > > > >>>> will
> > > > >>>> be a tag pointing to the wrong place.
> > > > >>>>
> > > > >>>>
> > > > >>>>
> > > > >>>> On Wed, Sep 10, 2014 at 3:10 PM, Robert Scholte <
> > > rfscholte@apache.org
> > > > >
> > > > >>>> wrote:
> > > > >>>>
> > > > >>>>  that's just the beginning...
> > > > >>>>
> > > > >>>>> so: how did you execute it? what did you get? what would you
> > > expect?
> > > > >>>>>
> > > > >>>>> Op Wed, 10 Sep 2014 20:54:49 +0200 schreef Benson Margulies <
> > > > >>>>> bimargulies@gmail.com>:
> > > > >>>>>
> > > > >>>>>
> > > > >>>>>  Aha, I have one for you. https://github.com/
> > > > >>>>> bimargulies/pom-file-name-tc.
> > > > >>>>>
> > > > >>>>>  I
> > > > >>>>>> attached it to a dup JIRA which I closed, or you can take it
> as
> > > you
> > > > >>>>>> see
> > > > >>>>>> it.
> > > > >>>>>> You may in general find MRELEASE-887 helpful in this respect.
> > > > >>>>>>
> > > > >>>>>> On Wed, Sep 10, 2014 at 2:53 PM, Robert Scholte <
> > > > rfscholte@apache.org
> > > > >>>>>> >
> > > > >>>>>> wrote:
> > > > >>>>>>
> > > > >>>>>>  Hi,
> > > > >>>>>>
> > > > >>>>>>
> > > > >>>>>>> IIRC I didn't have enough info to make a unittest, i.e.
> > reproduce
> > > > >>>>>>> what
> > > > >>>>>>> they get right now and what they would expect to be able to
> fix
> > > it.
> > > > >>>>>>> That would take me too much time to find out, so I left this
> > one
> > > > open
> > > > >>>>>>> for
> > > > >>>>>>> now.
> > > > >>>>>>>
> > > > >>>>>>> thanks,
> > > > >>>>>>> Robert
> > > > >>>>>>>
> > > > >>>>>>> Op Wed, 10 Sep 2014 20:23:07 +0200 schreef Benson Margulies <
> > > > >>>>>>> bimargulies@gmail.com>:
> > > > >>>>>>>
> > > > >>>>>>>
> > > > >>>>>>>  Yes, the remarks which dribbled off pointed to adapting the
> > fix
> > > > back
> > > > >>>>>>> into
> > > > >>>>>>>
> > > > >>>>>>>  the m-r-p.
> > > > >>>>>>>
> > > > >>>>>>>>
> > > > >>>>>>>>
> > > > >>>>>>>> On Wed, Sep 10, 2014 at 2:21 PM, Karl Heinz Marbaise <
> > > > >>>>>>>> khmarbaise@gmx.de
> > > > >>>>>>>> >
> > > > >>>>>>>> wrote:
> > > > >>>>>>>>
> > > > >>>>>>>>  Hi Benson,
> > > > >>>>>>>>
> > > > >>>>>>>>
> > > > >>>>>>>>  > Is anyone working on a fix to MRELEASE-875?
> > > > >>>>>>>>>
> > > > >>>>>>>>>
> > > > >>>>>>>>>
> > > > >>>>>>>>>   Based on JIRA it is assigned to Dominik Bartholdi which
> > > > requested
> > > > >>>>>>>>>
> > > > >>>>>>>>>>
> > > > >>>>>>>>>>  reviews
> > > > >>>>>>>>>>
> > > > >>>>>>>>> from others on Github...
> > > > >>>>>>>>>
> > > > >>>>>>>>> BTW: Not working on that...
> > > > >>>>>>>>>
> > > > >>>>>>>>> Kind regards
> > > > >>>>>>>>> Karl-Heinz Marbaise
> > > > >>>>>>>>>
> > > > >>>>>>>>>
> > > > >>>>>>>>>
> > > > >>>>>>>>>
> > > > >>>>>>>>>
> > > > >>>>>>>>>
> > > > >>>>>>>>>
> ------------------------------------------------------------
> > > > >>>>>>>>> ---------
> > > > >>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > >>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > > > >>>>>>>>>
> > > > >>>>>>>>>
> > > > >>>>>>>>>
> ------------------------------------------------------------
> > > > >>>>>>>>> ---------
> > > > >>>>>>>>>
> > > > >>>>>>>>>  To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > >>>>>>>>
> > > > >>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > > > >>>>>>>
> > > > >>>>>>>
> > > > >>>>>>>  ------------------------------------------------------------
> > > > >>>>>>> ---------
> > > > >>>>>>>
> > > > >>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > >>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > > > >>>>>
> > > > >>>>>
> > > > >>>>>
> > > > ---------------------------------------------------------------------
> > > > >>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > >>> For additional commands, e-mail: dev-help@maven.apache.org
> > > > >>>
> > > > >>>
> > > > >
> ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > > >
> > > > >
> > > >
> > >
> >
>

Re: https://github.com/apache/maven-scm/pull/17

Posted by Chris Graham <ch...@gmail.com>.

Sorry, I thought that the plugins, the scm ones in this case, had moved to
git? Still in SVN? If so, then no issues.

-Chris

On Thu, Sep 11, 2014 at 11:43 AM, Benson Margulies <bi...@gmail.com>
wrote:

> For plugins, you need mostly to make an account on Codehaus JIRA, then you
> svn checkout as per the information in the plugin's page, and then you can
> attach a patch to a JIRA.
>
>
>
> On Wed, Sep 10, 2014 at 9:37 PM, Chris Graham <ch...@gmail.com>
> wrote:
>
> > Whilst not strictly related to this thread...
> >
> > Is there a document that tells us what we need to do to contribute?
> > How/what repos we need to clone/setup, how to generate a patch/pull
> request
> > etc?
> >
> > Thanks,
> >
> > -Chris
> >
> > On Thu, Sep 11, 2014 at 7:04 AM, Benson Margulies <bimargulies@gmail.com
> >
> > wrote:
> >
> > > Of course; I'm just trying to help you get off the ground; is there
> > > something else you'd like me to do?
> > >
> > > On Wed, Sep 10, 2014 at 4:58 PM, Robert Scholte <rf...@apache.org>
> > > wrote:
> > >
> > > > I don't want to depend on external systems.
> > > > you could add me (rfscholte) but that'll only be for reproducing the
> > > issue.
> > > > and then I need isolate the problem and translate it to a unittest.
> > > >
> > > >
> > > > Op Wed, 10 Sep 2014 22:53:38 +0200 schreef Benson Margulies <
> > > > bimargulies@gmail.com>:
> > > >
> > > >
> > > >  Well, you'll need to push a clone where you can write, or tell me
> your
> > > >> github ID so I can add you as a collaborator.
> > > >>
> > > >> On Wed, Sep 10, 2014 at 4:45 PM, Robert Scholte <
> rfscholte@apache.org
> > >
> > > >> wrote:
> > > >>
> > > >>  The first step already fails on my machine.
> > > >>>
> > > >>> mvn release:prepare release:perform -B -DpushChanges=false
> > > >>>
> > > >>> I'm a bit surprised, because I see:
> > > >>> [INFO] Executing: cmd.exe /X /C "git push git@github.com:
> > bimargulies/
> > > >>> pom-file-name-tc.git
> > > >>> refs/heads/master:refs/heads/master"
> > > >>>
> > > >>> Actual failure:
> > > >>> [ERROR] Failed to execute goal org.apache.maven.plugins:
> > > >>> maven-release-plugin:2.5:prepare (default-cli) on project
> > > >>> pom-file-name-tc: Unable to commit files
> > > >>> [ERROR] Provider message:
> > > >>> [ERROR] The git-push command failed.
> > > >>> [ERROR] Command output:
> > > >>> [ERROR] Warning: Permanently added the RSA host key for IP address
> > > >>> '192.30.252.131' to the list of known hosts.
> > > >>> [ERROR] Permission denied (publickey).
> > > >>> [ERROR] fatal: Could not read from remote repository.
> > > >>> [ERROR]
> > > >>> [ERROR] Please make sure you have the correct access rights
> > > >>> [ERROR] and the repository exists.
> > > >>>
> > > >>> As said: I want to create a *unittest*
> > > >>> If I'm correct, the status-call has the wrong arguments. So what
> > should
> > > >>> it
> > > >>> look like? What's the result of this (so I can mock the consumer)
> and
> > > >>> what
> > > >>> should the next call be?
> > > >>>
> > > >>> Robert
> > > >>>
> > > >>> Op Wed, 10 Sep 2014 21:17:10 +0200 schreef Benson Margulies <
> > > >>> bimargulies@gmail.com>:
> > > >>>
> > > >>>
> > > >>>  Step 1: in the top level dir of the example, run mvn --batch-mode
> > > >>>
> > > >>>> release:prepare release:perform. All will be well. A repo will
> > > populate
> > > >>>> in
> > > >>>> /tmp.
> > > >>>>
> > > >>>> Step 2: modify pom in 'second' directory to use the just-release
> > > parent
> > > >>>> pom, commit, push.
> > > >>>>
> > > >>>> Step 3: mvn release:prepare in second directory.
> > > >>>>
> > > >>>> No errors, but the pom.xml will be sitting there modified, and
> there
> > > >>>> will
> > > >>>> be a tag pointing to the wrong place.
> > > >>>>
> > > >>>>
> > > >>>>
> > > >>>> On Wed, Sep 10, 2014 at 3:10 PM, Robert Scholte <
> > rfscholte@apache.org
> > > >
> > > >>>> wrote:
> > > >>>>
> > > >>>>  that's just the beginning...
> > > >>>>
> > > >>>>> so: how did you execute it? what did you get? what would you
> > expect?
> > > >>>>>
> > > >>>>> Op Wed, 10 Sep 2014 20:54:49 +0200 schreef Benson Margulies <
> > > >>>>> bimargulies@gmail.com>:
> > > >>>>>
> > > >>>>>
> > > >>>>>  Aha, I have one for you. https://github.com/
> > > >>>>> bimargulies/pom-file-name-tc.
> > > >>>>>
> > > >>>>>  I
> > > >>>>>> attached it to a dup JIRA which I closed, or you can take it as
> > you
> > > >>>>>> see
> > > >>>>>> it.
> > > >>>>>> You may in general find MRELEASE-887 helpful in this respect.
> > > >>>>>>
> > > >>>>>> On Wed, Sep 10, 2014 at 2:53 PM, Robert Scholte <
> > > rfscholte@apache.org
> > > >>>>>> >
> > > >>>>>> wrote:
> > > >>>>>>
> > > >>>>>>  Hi,
> > > >>>>>>
> > > >>>>>>
> > > >>>>>>> IIRC I didn't have enough info to make a unittest, i.e.
> reproduce
> > > >>>>>>> what
> > > >>>>>>> they get right now and what they would expect to be able to fix
> > it.
> > > >>>>>>> That would take me too much time to find out, so I left this
> one
> > > open
> > > >>>>>>> for
> > > >>>>>>> now.
> > > >>>>>>>
> > > >>>>>>> thanks,
> > > >>>>>>> Robert
> > > >>>>>>>
> > > >>>>>>> Op Wed, 10 Sep 2014 20:23:07 +0200 schreef Benson Margulies <
> > > >>>>>>> bimargulies@gmail.com>:
> > > >>>>>>>
> > > >>>>>>>
> > > >>>>>>>  Yes, the remarks which dribbled off pointed to adapting the
> fix
> > > back
> > > >>>>>>> into
> > > >>>>>>>
> > > >>>>>>>  the m-r-p.
> > > >>>>>>>
> > > >>>>>>>>
> > > >>>>>>>>
> > > >>>>>>>> On Wed, Sep 10, 2014 at 2:21 PM, Karl Heinz Marbaise <
> > > >>>>>>>> khmarbaise@gmx.de
> > > >>>>>>>> >
> > > >>>>>>>> wrote:
> > > >>>>>>>>
> > > >>>>>>>>  Hi Benson,
> > > >>>>>>>>
> > > >>>>>>>>
> > > >>>>>>>>  > Is anyone working on a fix to MRELEASE-875?
> > > >>>>>>>>>
> > > >>>>>>>>>
> > > >>>>>>>>>
> > > >>>>>>>>>   Based on JIRA it is assigned to Dominik Bartholdi which
> > > requested
> > > >>>>>>>>>
> > > >>>>>>>>>>
> > > >>>>>>>>>>  reviews
> > > >>>>>>>>>>
> > > >>>>>>>>> from others on Github...
> > > >>>>>>>>>
> > > >>>>>>>>> BTW: Not working on that...
> > > >>>>>>>>>
> > > >>>>>>>>> Kind regards
> > > >>>>>>>>> Karl-Heinz Marbaise
> > > >>>>>>>>>
> > > >>>>>>>>>
> > > >>>>>>>>>
> > > >>>>>>>>>
> > > >>>>>>>>>
> > > >>>>>>>>>
> > > >>>>>>>>> ------------------------------------------------------------
> > > >>>>>>>>> ---------
> > > >>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > >>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > > >>>>>>>>>
> > > >>>>>>>>>
> > > >>>>>>>>>  ------------------------------------------------------------
> > > >>>>>>>>> ---------
> > > >>>>>>>>>
> > > >>>>>>>>>  To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > >>>>>>>>
> > > >>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > > >>>>>>>
> > > >>>>>>>
> > > >>>>>>>  ------------------------------------------------------------
> > > >>>>>>> ---------
> > > >>>>>>>
> > > >>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > >>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > > >>>>>
> > > >>>>>
> > > >>>>>
> > > ---------------------------------------------------------------------
> > > >>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > >>> For additional commands, e-mail: dev-help@maven.apache.org
> > > >>>
> > > >>>
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > >
> > > >
> > >
> >
>

Re: https://github.com/apache/maven-scm/pull/17

Posted by Benson Margulies <bi...@gmail.com>.

For plugins, you need mostly to make an account on Codehaus JIRA, then you
svn checkout as per the information in the plugin's page, and then you can
attach a patch to a JIRA.



On Wed, Sep 10, 2014 at 9:37 PM, Chris Graham <ch...@gmail.com> wrote:

> Whilst not strictly related to this thread...
>
> Is there a document that tells us what we need to do to contribute?
> How/what repos we need to clone/setup, how to generate a patch/pull request
> etc?
>
> Thanks,
>
> -Chris
>
> On Thu, Sep 11, 2014 at 7:04 AM, Benson Margulies <bi...@gmail.com>
> wrote:
>
> > Of course; I'm just trying to help you get off the ground; is there
> > something else you'd like me to do?
> >
> > On Wed, Sep 10, 2014 at 4:58 PM, Robert Scholte <rf...@apache.org>
> > wrote:
> >
> > > I don't want to depend on external systems.
> > > you could add me (rfscholte) but that'll only be for reproducing the
> > issue.
> > > and then I need isolate the problem and translate it to a unittest.
> > >
> > >
> > > Op Wed, 10 Sep 2014 22:53:38 +0200 schreef Benson Margulies <
> > > bimargulies@gmail.com>:
> > >
> > >
> > >  Well, you'll need to push a clone where you can write, or tell me your
> > >> github ID so I can add you as a collaborator.
> > >>
> > >> On Wed, Sep 10, 2014 at 4:45 PM, Robert Scholte <rfscholte@apache.org
> >
> > >> wrote:
> > >>
> > >>  The first step already fails on my machine.
> > >>>
> > >>> mvn release:prepare release:perform -B -DpushChanges=false
> > >>>
> > >>> I'm a bit surprised, because I see:
> > >>> [INFO] Executing: cmd.exe /X /C "git push git@github.com:
> bimargulies/
> > >>> pom-file-name-tc.git
> > >>> refs/heads/master:refs/heads/master"
> > >>>
> > >>> Actual failure:
> > >>> [ERROR] Failed to execute goal org.apache.maven.plugins:
> > >>> maven-release-plugin:2.5:prepare (default-cli) on project
> > >>> pom-file-name-tc: Unable to commit files
> > >>> [ERROR] Provider message:
> > >>> [ERROR] The git-push command failed.
> > >>> [ERROR] Command output:
> > >>> [ERROR] Warning: Permanently added the RSA host key for IP address
> > >>> '192.30.252.131' to the list of known hosts.
> > >>> [ERROR] Permission denied (publickey).
> > >>> [ERROR] fatal: Could not read from remote repository.
> > >>> [ERROR]
> > >>> [ERROR] Please make sure you have the correct access rights
> > >>> [ERROR] and the repository exists.
> > >>>
> > >>> As said: I want to create a *unittest*
> > >>> If I'm correct, the status-call has the wrong arguments. So what
> should
> > >>> it
> > >>> look like? What's the result of this (so I can mock the consumer) and
> > >>> what
> > >>> should the next call be?
> > >>>
> > >>> Robert
> > >>>
> > >>> Op Wed, 10 Sep 2014 21:17:10 +0200 schreef Benson Margulies <
> > >>> bimargulies@gmail.com>:
> > >>>
> > >>>
> > >>>  Step 1: in the top level dir of the example, run mvn --batch-mode
> > >>>
> > >>>> release:prepare release:perform. All will be well. A repo will
> > populate
> > >>>> in
> > >>>> /tmp.
> > >>>>
> > >>>> Step 2: modify pom in 'second' directory to use the just-release
> > parent
> > >>>> pom, commit, push.
> > >>>>
> > >>>> Step 3: mvn release:prepare in second directory.
> > >>>>
> > >>>> No errors, but the pom.xml will be sitting there modified, and there
> > >>>> will
> > >>>> be a tag pointing to the wrong place.
> > >>>>
> > >>>>
> > >>>>
> > >>>> On Wed, Sep 10, 2014 at 3:10 PM, Robert Scholte <
> rfscholte@apache.org
> > >
> > >>>> wrote:
> > >>>>
> > >>>>  that's just the beginning...
> > >>>>
> > >>>>> so: how did you execute it? what did you get? what would you
> expect?
> > >>>>>
> > >>>>> Op Wed, 10 Sep 2014 20:54:49 +0200 schreef Benson Margulies <
> > >>>>> bimargulies@gmail.com>:
> > >>>>>
> > >>>>>
> > >>>>>  Aha, I have one for you. https://github.com/
> > >>>>> bimargulies/pom-file-name-tc.
> > >>>>>
> > >>>>>  I
> > >>>>>> attached it to a dup JIRA which I closed, or you can take it as
> you
> > >>>>>> see
> > >>>>>> it.
> > >>>>>> You may in general find MRELEASE-887 helpful in this respect.
> > >>>>>>
> > >>>>>> On Wed, Sep 10, 2014 at 2:53 PM, Robert Scholte <
> > rfscholte@apache.org
> > >>>>>> >
> > >>>>>> wrote:
> > >>>>>>
> > >>>>>>  Hi,
> > >>>>>>
> > >>>>>>
> > >>>>>>> IIRC I didn't have enough info to make a unittest, i.e. reproduce
> > >>>>>>> what
> > >>>>>>> they get right now and what they would expect to be able to fix
> it.
> > >>>>>>> That would take me too much time to find out, so I left this one
> > open
> > >>>>>>> for
> > >>>>>>> now.
> > >>>>>>>
> > >>>>>>> thanks,
> > >>>>>>> Robert
> > >>>>>>>
> > >>>>>>> Op Wed, 10 Sep 2014 20:23:07 +0200 schreef Benson Margulies <
> > >>>>>>> bimargulies@gmail.com>:
> > >>>>>>>
> > >>>>>>>
> > >>>>>>>  Yes, the remarks which dribbled off pointed to adapting the fix
> > back
> > >>>>>>> into
> > >>>>>>>
> > >>>>>>>  the m-r-p.
> > >>>>>>>
> > >>>>>>>>
> > >>>>>>>>
> > >>>>>>>> On Wed, Sep 10, 2014 at 2:21 PM, Karl Heinz Marbaise <
> > >>>>>>>> khmarbaise@gmx.de
> > >>>>>>>> >
> > >>>>>>>> wrote:
> > >>>>>>>>
> > >>>>>>>>  Hi Benson,
> > >>>>>>>>
> > >>>>>>>>
> > >>>>>>>>  > Is anyone working on a fix to MRELEASE-875?
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>>   Based on JIRA it is assigned to Dominik Bartholdi which
> > requested
> > >>>>>>>>>
> > >>>>>>>>>>
> > >>>>>>>>>>  reviews
> > >>>>>>>>>>
> > >>>>>>>>> from others on Github...
> > >>>>>>>>>
> > >>>>>>>>> BTW: Not working on that...
> > >>>>>>>>>
> > >>>>>>>>> Kind regards
> > >>>>>>>>> Karl-Heinz Marbaise
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>> ------------------------------------------------------------
> > >>>>>>>>> ---------
> > >>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>>  ------------------------------------------------------------
> > >>>>>>>>> ---------
> > >>>>>>>>>
> > >>>>>>>>>  To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >>>>>>>>
> > >>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > >>>>>>>
> > >>>>>>>
> > >>>>>>>  ------------------------------------------------------------
> > >>>>>>> ---------
> > >>>>>>>
> > >>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >>>>> For additional commands, e-mail: dev-help@maven.apache.org
> > >>>>>
> > >>>>>
> > >>>>>
> > ---------------------------------------------------------------------
> > >>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >>> For additional commands, e-mail: dev-help@maven.apache.org
> > >>>
> > >>>
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > For additional commands, e-mail: dev-help@maven.apache.org
> > >
> > >
> >
>

Re: https://github.com/apache/maven-scm/pull/17

Posted by Chris Graham <ch...@gmail.com>.

Whilst not strictly related to this thread...

Is there a document that tells us what we need to do to contribute?
How/what repos we need to clone/setup, how to generate a patch/pull request
etc?

Thanks,

-Chris

On Thu, Sep 11, 2014 at 7:04 AM, Benson Margulies <bi...@gmail.com>
wrote:

> Of course; I'm just trying to help you get off the ground; is there
> something else you'd like me to do?
>
> On Wed, Sep 10, 2014 at 4:58 PM, Robert Scholte <rf...@apache.org>
> wrote:
>
> > I don't want to depend on external systems.
> > you could add me (rfscholte) but that'll only be for reproducing the
> issue.
> > and then I need isolate the problem and translate it to a unittest.
> >
> >
> > Op Wed, 10 Sep 2014 22:53:38 +0200 schreef Benson Margulies <
> > bimargulies@gmail.com>:
> >
> >
> >  Well, you'll need to push a clone where you can write, or tell me your
> >> github ID so I can add you as a collaborator.
> >>
> >> On Wed, Sep 10, 2014 at 4:45 PM, Robert Scholte <rf...@apache.org>
> >> wrote:
> >>
> >>  The first step already fails on my machine.
> >>>
> >>> mvn release:prepare release:perform -B -DpushChanges=false
> >>>
> >>> I'm a bit surprised, because I see:
> >>> [INFO] Executing: cmd.exe /X /C "git push git@github.com:bimargulies/
> >>> pom-file-name-tc.git
> >>> refs/heads/master:refs/heads/master"
> >>>
> >>> Actual failure:
> >>> [ERROR] Failed to execute goal org.apache.maven.plugins:
> >>> maven-release-plugin:2.5:prepare (default-cli) on project
> >>> pom-file-name-tc: Unable to commit files
> >>> [ERROR] Provider message:
> >>> [ERROR] The git-push command failed.
> >>> [ERROR] Command output:
> >>> [ERROR] Warning: Permanently added the RSA host key for IP address
> >>> '192.30.252.131' to the list of known hosts.
> >>> [ERROR] Permission denied (publickey).
> >>> [ERROR] fatal: Could not read from remote repository.
> >>> [ERROR]
> >>> [ERROR] Please make sure you have the correct access rights
> >>> [ERROR] and the repository exists.
> >>>
> >>> As said: I want to create a *unittest*
> >>> If I'm correct, the status-call has the wrong arguments. So what should
> >>> it
> >>> look like? What's the result of this (so I can mock the consumer) and
> >>> what
> >>> should the next call be?
> >>>
> >>> Robert
> >>>
> >>> Op Wed, 10 Sep 2014 21:17:10 +0200 schreef Benson Margulies <
> >>> bimargulies@gmail.com>:
> >>>
> >>>
> >>>  Step 1: in the top level dir of the example, run mvn --batch-mode
> >>>
> >>>> release:prepare release:perform. All will be well. A repo will
> populate
> >>>> in
> >>>> /tmp.
> >>>>
> >>>> Step 2: modify pom in 'second' directory to use the just-release
> parent
> >>>> pom, commit, push.
> >>>>
> >>>> Step 3: mvn release:prepare in second directory.
> >>>>
> >>>> No errors, but the pom.xml will be sitting there modified, and there
> >>>> will
> >>>> be a tag pointing to the wrong place.
> >>>>
> >>>>
> >>>>
> >>>> On Wed, Sep 10, 2014 at 3:10 PM, Robert Scholte <rfscholte@apache.org
> >
> >>>> wrote:
> >>>>
> >>>>  that's just the beginning...
> >>>>
> >>>>> so: how did you execute it? what did you get? what would you expect?
> >>>>>
> >>>>> Op Wed, 10 Sep 2014 20:54:49 +0200 schreef Benson Margulies <
> >>>>> bimargulies@gmail.com>:
> >>>>>
> >>>>>
> >>>>>  Aha, I have one for you. https://github.com/
> >>>>> bimargulies/pom-file-name-tc.
> >>>>>
> >>>>>  I
> >>>>>> attached it to a dup JIRA which I closed, or you can take it as you
> >>>>>> see
> >>>>>> it.
> >>>>>> You may in general find MRELEASE-887 helpful in this respect.
> >>>>>>
> >>>>>> On Wed, Sep 10, 2014 at 2:53 PM, Robert Scholte <
> rfscholte@apache.org
> >>>>>> >
> >>>>>> wrote:
> >>>>>>
> >>>>>>  Hi,
> >>>>>>
> >>>>>>
> >>>>>>> IIRC I didn't have enough info to make a unittest, i.e. reproduce
> >>>>>>> what
> >>>>>>> they get right now and what they would expect to be able to fix it.
> >>>>>>> That would take me too much time to find out, so I left this one
> open
> >>>>>>> for
> >>>>>>> now.
> >>>>>>>
> >>>>>>> thanks,
> >>>>>>> Robert
> >>>>>>>
> >>>>>>> Op Wed, 10 Sep 2014 20:23:07 +0200 schreef Benson Margulies <
> >>>>>>> bimargulies@gmail.com>:
> >>>>>>>
> >>>>>>>
> >>>>>>>  Yes, the remarks which dribbled off pointed to adapting the fix
> back
> >>>>>>> into
> >>>>>>>
> >>>>>>>  the m-r-p.
> >>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> On Wed, Sep 10, 2014 at 2:21 PM, Karl Heinz Marbaise <
> >>>>>>>> khmarbaise@gmx.de
> >>>>>>>> >
> >>>>>>>> wrote:
> >>>>>>>>
> >>>>>>>>  Hi Benson,
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>  > Is anyone working on a fix to MRELEASE-875?
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>   Based on JIRA it is assigned to Dominik Bartholdi which
> requested
> >>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>  reviews
> >>>>>>>>>>
> >>>>>>>>> from others on Github...
> >>>>>>>>>
> >>>>>>>>> BTW: Not working on that...
> >>>>>>>>>
> >>>>>>>>> Kind regards
> >>>>>>>>> Karl-Heinz Marbaise
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> ------------------------------------------------------------
> >>>>>>>>> ---------
> >>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>  ------------------------------------------------------------
> >>>>>>>>> ---------
> >>>>>>>>>
> >>>>>>>>>  To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>>>>>>
> >>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>>>>>
> >>>>>>>
> >>>>>>>  ------------------------------------------------------------
> >>>>>>> ---------
> >>>>>>>
> >>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>>>
> >>>>>
> >>>>>
> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>
> >>>
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>

Re: https://github.com/apache/maven-scm/pull/17

Posted by Benson Margulies <bi...@gmail.com>.

Of course; I'm just trying to help you get off the ground; is there
something else you'd like me to do?

On Wed, Sep 10, 2014 at 4:58 PM, Robert Scholte <rf...@apache.org>
wrote:

> I don't want to depend on external systems.
> you could add me (rfscholte) but that'll only be for reproducing the issue.
> and then I need isolate the problem and translate it to a unittest.
>
>
> Op Wed, 10 Sep 2014 22:53:38 +0200 schreef Benson Margulies <
> bimargulies@gmail.com>:
>
>
>  Well, you'll need to push a clone where you can write, or tell me your
>> github ID so I can add you as a collaborator.
>>
>> On Wed, Sep 10, 2014 at 4:45 PM, Robert Scholte <rf...@apache.org>
>> wrote:
>>
>>  The first step already fails on my machine.
>>>
>>> mvn release:prepare release:perform -B -DpushChanges=false
>>>
>>> I'm a bit surprised, because I see:
>>> [INFO] Executing: cmd.exe /X /C "git push git@github.com:bimargulies/
>>> pom-file-name-tc.git
>>> refs/heads/master:refs/heads/master"
>>>
>>> Actual failure:
>>> [ERROR] Failed to execute goal org.apache.maven.plugins:
>>> maven-release-plugin:2.5:prepare (default-cli) on project
>>> pom-file-name-tc: Unable to commit files
>>> [ERROR] Provider message:
>>> [ERROR] The git-push command failed.
>>> [ERROR] Command output:
>>> [ERROR] Warning: Permanently added the RSA host key for IP address
>>> '192.30.252.131' to the list of known hosts.
>>> [ERROR] Permission denied (publickey).
>>> [ERROR] fatal: Could not read from remote repository.
>>> [ERROR]
>>> [ERROR] Please make sure you have the correct access rights
>>> [ERROR] and the repository exists.
>>>
>>> As said: I want to create a *unittest*
>>> If I'm correct, the status-call has the wrong arguments. So what should
>>> it
>>> look like? What's the result of this (so I can mock the consumer) and
>>> what
>>> should the next call be?
>>>
>>> Robert
>>>
>>> Op Wed, 10 Sep 2014 21:17:10 +0200 schreef Benson Margulies <
>>> bimargulies@gmail.com>:
>>>
>>>
>>>  Step 1: in the top level dir of the example, run mvn --batch-mode
>>>
>>>> release:prepare release:perform. All will be well. A repo will populate
>>>> in
>>>> /tmp.
>>>>
>>>> Step 2: modify pom in 'second' directory to use the just-release parent
>>>> pom, commit, push.
>>>>
>>>> Step 3: mvn release:prepare in second directory.
>>>>
>>>> No errors, but the pom.xml will be sitting there modified, and there
>>>> will
>>>> be a tag pointing to the wrong place.
>>>>
>>>>
>>>>
>>>> On Wed, Sep 10, 2014 at 3:10 PM, Robert Scholte <rf...@apache.org>
>>>> wrote:
>>>>
>>>>  that's just the beginning...
>>>>
>>>>> so: how did you execute it? what did you get? what would you expect?
>>>>>
>>>>> Op Wed, 10 Sep 2014 20:54:49 +0200 schreef Benson Margulies <
>>>>> bimargulies@gmail.com>:
>>>>>
>>>>>
>>>>>  Aha, I have one for you. https://github.com/
>>>>> bimargulies/pom-file-name-tc.
>>>>>
>>>>>  I
>>>>>> attached it to a dup JIRA which I closed, or you can take it as you
>>>>>> see
>>>>>> it.
>>>>>> You may in general find MRELEASE-887 helpful in this respect.
>>>>>>
>>>>>> On Wed, Sep 10, 2014 at 2:53 PM, Robert Scholte <rfscholte@apache.org
>>>>>> >
>>>>>> wrote:
>>>>>>
>>>>>>  Hi,
>>>>>>
>>>>>>
>>>>>>> IIRC I didn't have enough info to make a unittest, i.e. reproduce
>>>>>>> what
>>>>>>> they get right now and what they would expect to be able to fix it.
>>>>>>> That would take me too much time to find out, so I left this one open
>>>>>>> for
>>>>>>> now.
>>>>>>>
>>>>>>> thanks,
>>>>>>> Robert
>>>>>>>
>>>>>>> Op Wed, 10 Sep 2014 20:23:07 +0200 schreef Benson Margulies <
>>>>>>> bimargulies@gmail.com>:
>>>>>>>
>>>>>>>
>>>>>>>  Yes, the remarks which dribbled off pointed to adapting the fix back
>>>>>>> into
>>>>>>>
>>>>>>>  the m-r-p.
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Wed, Sep 10, 2014 at 2:21 PM, Karl Heinz Marbaise <
>>>>>>>> khmarbaise@gmx.de
>>>>>>>> >
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>  Hi Benson,
>>>>>>>>
>>>>>>>>
>>>>>>>>  > Is anyone working on a fix to MRELEASE-875?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>   Based on JIRA it is assigned to Dominik Bartholdi which requested
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>  reviews
>>>>>>>>>>
>>>>>>>>> from others on Github...
>>>>>>>>>
>>>>>>>>> BTW: Not working on that...
>>>>>>>>>
>>>>>>>>> Kind regards
>>>>>>>>> Karl-Heinz Marbaise
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> ------------------------------------------------------------
>>>>>>>>> ---------
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>  ------------------------------------------------------------
>>>>>>>>> ---------
>>>>>>>>>
>>>>>>>>>  To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>>>>
>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>>>
>>>>>>>
>>>>>>>  ------------------------------------------------------------
>>>>>>> ---------
>>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>
>>>>>
>>>>>  ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Re: https://github.com/apache/maven-scm/pull/17

Posted by Benson Margulies <bi...@gmail.com>.

Robert has looked into this in more detail, and think the trail points back
into SCM. As per info I've added to the JIRA, it is not caused by git
barking at the release.properties and pom.xml.xxx file; if you add those to
.gitignore, they disappear from the scene, but it still does not work. I'm
hoping Robert will add more analysis here or to the JIRA.


On Wed, Sep 10, 2014 at 4:58 PM, Robert Scholte <rf...@apache.org>
wrote:

> I don't want to depend on external systems.
> you could add me (rfscholte) but that'll only be for reproducing the issue.
> and then I need isolate the problem and translate it to a unittest.
>
>
> Op Wed, 10 Sep 2014 22:53:38 +0200 schreef Benson Margulies <
> bimargulies@gmail.com>:
>
>
>  Well, you'll need to push a clone where you can write, or tell me your
>> github ID so I can add you as a collaborator.
>>
>> On Wed, Sep 10, 2014 at 4:45 PM, Robert Scholte <rf...@apache.org>
>> wrote:
>>
>>  The first step already fails on my machine.
>>>
>>> mvn release:prepare release:perform -B -DpushChanges=false
>>>
>>> I'm a bit surprised, because I see:
>>> [INFO] Executing: cmd.exe /X /C "git push git@github.com:bimargulies/
>>> pom-file-name-tc.git
>>> refs/heads/master:refs/heads/master"
>>>
>>> Actual failure:
>>> [ERROR] Failed to execute goal org.apache.maven.plugins:
>>> maven-release-plugin:2.5:prepare (default-cli) on project
>>> pom-file-name-tc: Unable to commit files
>>> [ERROR] Provider message:
>>> [ERROR] The git-push command failed.
>>> [ERROR] Command output:
>>> [ERROR] Warning: Permanently added the RSA host key for IP address
>>> '192.30.252.131' to the list of known hosts.
>>> [ERROR] Permission denied (publickey).
>>> [ERROR] fatal: Could not read from remote repository.
>>> [ERROR]
>>> [ERROR] Please make sure you have the correct access rights
>>> [ERROR] and the repository exists.
>>>
>>> As said: I want to create a *unittest*
>>> If I'm correct, the status-call has the wrong arguments. So what should
>>> it
>>> look like? What's the result of this (so I can mock the consumer) and
>>> what
>>> should the next call be?
>>>
>>> Robert
>>>
>>> Op Wed, 10 Sep 2014 21:17:10 +0200 schreef Benson Margulies <
>>> bimargulies@gmail.com>:
>>>
>>>
>>>  Step 1: in the top level dir of the example, run mvn --batch-mode
>>>
>>>> release:prepare release:perform. All will be well. A repo will populate
>>>> in
>>>> /tmp.
>>>>
>>>> Step 2: modify pom in 'second' directory to use the just-release parent
>>>> pom, commit, push.
>>>>
>>>> Step 3: mvn release:prepare in second directory.
>>>>
>>>> No errors, but the pom.xml will be sitting there modified, and there
>>>> will
>>>> be a tag pointing to the wrong place.
>>>>
>>>>
>>>>
>>>> On Wed, Sep 10, 2014 at 3:10 PM, Robert Scholte <rf...@apache.org>
>>>> wrote:
>>>>
>>>>  that's just the beginning...
>>>>
>>>>> so: how did you execute it? what did you get? what would you expect?
>>>>>
>>>>> Op Wed, 10 Sep 2014 20:54:49 +0200 schreef Benson Margulies <
>>>>> bimargulies@gmail.com>:
>>>>>
>>>>>
>>>>>  Aha, I have one for you. https://github.com/
>>>>> bimargulies/pom-file-name-tc.
>>>>>
>>>>>  I
>>>>>> attached it to a dup JIRA which I closed, or you can take it as you
>>>>>> see
>>>>>> it.
>>>>>> You may in general find MRELEASE-887 helpful in this respect.
>>>>>>
>>>>>> On Wed, Sep 10, 2014 at 2:53 PM, Robert Scholte <rfscholte@apache.org
>>>>>> >
>>>>>> wrote:
>>>>>>
>>>>>>  Hi,
>>>>>>
>>>>>>
>>>>>>> IIRC I didn't have enough info to make a unittest, i.e. reproduce
>>>>>>> what
>>>>>>> they get right now and what they would expect to be able to fix it.
>>>>>>> That would take me too much time to find out, so I left this one open
>>>>>>> for
>>>>>>> now.
>>>>>>>
>>>>>>> thanks,
>>>>>>> Robert
>>>>>>>
>>>>>>> Op Wed, 10 Sep 2014 20:23:07 +0200 schreef Benson Margulies <
>>>>>>> bimargulies@gmail.com>:
>>>>>>>
>>>>>>>
>>>>>>>  Yes, the remarks which dribbled off pointed to adapting the fix back
>>>>>>> into
>>>>>>>
>>>>>>>  the m-r-p.
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Wed, Sep 10, 2014 at 2:21 PM, Karl Heinz Marbaise <
>>>>>>>> khmarbaise@gmx.de
>>>>>>>> >
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>  Hi Benson,
>>>>>>>>
>>>>>>>>
>>>>>>>>  > Is anyone working on a fix to MRELEASE-875?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>   Based on JIRA it is assigned to Dominik Bartholdi which requested
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>  reviews
>>>>>>>>>>
>>>>>>>>> from others on Github...
>>>>>>>>>
>>>>>>>>> BTW: Not working on that...
>>>>>>>>>
>>>>>>>>> Kind regards
>>>>>>>>> Karl-Heinz Marbaise
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> ------------------------------------------------------------
>>>>>>>>> ---------
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>  ------------------------------------------------------------
>>>>>>>>> ---------
>>>>>>>>>
>>>>>>>>>  To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>>>>
>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>>>
>>>>>>>
>>>>>>>  ------------------------------------------------------------
>>>>>>> ---------
>>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>
>>>>>
>>>>>  ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Re: https://github.com/apache/maven-scm/pull/17

Posted by Robert Scholte <rf...@apache.org>.

I don't want to depend on external systems.
you could add me (rfscholte) but that'll only be for reproducing the issue.
and then I need isolate the problem and translate it to a unittest.


Op Wed, 10 Sep 2014 22:53:38 +0200 schreef Benson Margulies  
<bi...@gmail.com>:

> Well, you'll need to push a clone where you can write, or tell me your
> github ID so I can add you as a collaborator.
>
> On Wed, Sep 10, 2014 at 4:45 PM, Robert Scholte <rf...@apache.org>
> wrote:
>
>> The first step already fails on my machine.
>>
>> mvn release:prepare release:perform -B -DpushChanges=false
>>
>> I'm a bit surprised, because I see:
>> [INFO] Executing: cmd.exe /X /C "git push  
>> git@github.com:bimargulies/pom-file-name-tc.git
>> refs/heads/master:refs/heads/master"
>>
>> Actual failure:
>> [ERROR] Failed to execute goal org.apache.maven.plugins:
>> maven-release-plugin:2.5:prepare (default-cli) on project
>> pom-file-name-tc: Unable to commit files
>> [ERROR] Provider message:
>> [ERROR] The git-push command failed.
>> [ERROR] Command output:
>> [ERROR] Warning: Permanently added the RSA host key for IP address
>> '192.30.252.131' to the list of known hosts.
>> [ERROR] Permission denied (publickey).
>> [ERROR] fatal: Could not read from remote repository.
>> [ERROR]
>> [ERROR] Please make sure you have the correct access rights
>> [ERROR] and the repository exists.
>>
>> As said: I want to create a *unittest*
>> If I'm correct, the status-call has the wrong arguments. So what should  
>> it
>> look like? What's the result of this (so I can mock the consumer) and  
>> what
>> should the next call be?
>>
>> Robert
>>
>> Op Wed, 10 Sep 2014 21:17:10 +0200 schreef Benson Margulies <
>> bimargulies@gmail.com>:
>>
>>
>>  Step 1: in the top level dir of the example, run mvn --batch-mode
>>> release:prepare release:perform. All will be well. A repo will  
>>> populate in
>>> /tmp.
>>>
>>> Step 2: modify pom in 'second' directory to use the just-release parent
>>> pom, commit, push.
>>>
>>> Step 3: mvn release:prepare in second directory.
>>>
>>> No errors, but the pom.xml will be sitting there modified, and there  
>>> will
>>> be a tag pointing to the wrong place.
>>>
>>>
>>>
>>> On Wed, Sep 10, 2014 at 3:10 PM, Robert Scholte <rf...@apache.org>
>>> wrote:
>>>
>>>  that's just the beginning...
>>>> so: how did you execute it? what did you get? what would you expect?
>>>>
>>>> Op Wed, 10 Sep 2014 20:54:49 +0200 schreef Benson Margulies <
>>>> bimargulies@gmail.com>:
>>>>
>>>>
>>>>  Aha, I have one for you. https://github.com/
>>>> bimargulies/pom-file-name-tc.
>>>>
>>>>> I
>>>>> attached it to a dup JIRA which I closed, or you can take it as you  
>>>>> see
>>>>> it.
>>>>> You may in general find MRELEASE-887 helpful in this respect.
>>>>>
>>>>> On Wed, Sep 10, 2014 at 2:53 PM, Robert Scholte  
>>>>> <rf...@apache.org>
>>>>> wrote:
>>>>>
>>>>>  Hi,
>>>>>
>>>>>>
>>>>>> IIRC I didn't have enough info to make a unittest, i.e. reproduce  
>>>>>> what
>>>>>> they get right now and what they would expect to be able to fix it.
>>>>>> That would take me too much time to find out, so I left this one  
>>>>>> open
>>>>>> for
>>>>>> now.
>>>>>>
>>>>>> thanks,
>>>>>> Robert
>>>>>>
>>>>>> Op Wed, 10 Sep 2014 20:23:07 +0200 schreef Benson Margulies <
>>>>>> bimargulies@gmail.com>:
>>>>>>
>>>>>>
>>>>>>  Yes, the remarks which dribbled off pointed to adapting the fix  
>>>>>> back
>>>>>> into
>>>>>>
>>>>>>  the m-r-p.
>>>>>>>
>>>>>>>
>>>>>>> On Wed, Sep 10, 2014 at 2:21 PM, Karl Heinz Marbaise <
>>>>>>> khmarbaise@gmx.de
>>>>>>> >
>>>>>>> wrote:
>>>>>>>
>>>>>>>  Hi Benson,
>>>>>>>
>>>>>>>
>>>>>>>> > Is anyone working on a fix to MRELEASE-875?
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>   Based on JIRA it is assigned to Dominik Bartholdi which  
>>>>>>>> requested
>>>>>>>>>
>>>>>>>>>  reviews
>>>>>>>> from others on Github...
>>>>>>>>
>>>>>>>> BTW: Not working on that...
>>>>>>>>
>>>>>>>> Kind regards
>>>>>>>> Karl-Heinz Marbaise
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> ------------------------------------------------------------
>>>>>>>> ---------
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>>>  ------------------------------------------------------------
>>>>>>>> ---------
>>>>>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>>
>>>>>>
>>>>>>  ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: https://github.com/apache/maven-scm/pull/17

Posted by Benson Margulies <bi...@gmail.com>.

Well, you'll need to push a clone where you can write, or tell me your
github ID so I can add you as a collaborator.

On Wed, Sep 10, 2014 at 4:45 PM, Robert Scholte <rf...@apache.org>
wrote:

> The first step already fails on my machine.
>
> mvn release:prepare release:perform -B -DpushChanges=false
>
> I'm a bit surprised, because I see:
> [INFO] Executing: cmd.exe /X /C "git push git@github.com:bimargulies/pom-file-name-tc.git
> refs/heads/master:refs/heads/master"
>
> Actual failure:
> [ERROR] Failed to execute goal org.apache.maven.plugins:
> maven-release-plugin:2.5:prepare (default-cli) on project
> pom-file-name-tc: Unable to commit files
> [ERROR] Provider message:
> [ERROR] The git-push command failed.
> [ERROR] Command output:
> [ERROR] Warning: Permanently added the RSA host key for IP address
> '192.30.252.131' to the list of known hosts.
> [ERROR] Permission denied (publickey).
> [ERROR] fatal: Could not read from remote repository.
> [ERROR]
> [ERROR] Please make sure you have the correct access rights
> [ERROR] and the repository exists.
>
> As said: I want to create a *unittest*
> If I'm correct, the status-call has the wrong arguments. So what should it
> look like? What's the result of this (so I can mock the consumer) and what
> should the next call be?
>
> Robert
>
> Op Wed, 10 Sep 2014 21:17:10 +0200 schreef Benson Margulies <
> bimargulies@gmail.com>:
>
>
>  Step 1: in the top level dir of the example, run mvn --batch-mode
>> release:prepare release:perform. All will be well. A repo will populate in
>> /tmp.
>>
>> Step 2: modify pom in 'second' directory to use the just-release parent
>> pom, commit, push.
>>
>> Step 3: mvn release:prepare in second directory.
>>
>> No errors, but the pom.xml will be sitting there modified, and there will
>> be a tag pointing to the wrong place.
>>
>>
>>
>> On Wed, Sep 10, 2014 at 3:10 PM, Robert Scholte <rf...@apache.org>
>> wrote:
>>
>>  that's just the beginning...
>>> so: how did you execute it? what did you get? what would you expect?
>>>
>>> Op Wed, 10 Sep 2014 20:54:49 +0200 schreef Benson Margulies <
>>> bimargulies@gmail.com>:
>>>
>>>
>>>  Aha, I have one for you. https://github.com/
>>> bimargulies/pom-file-name-tc.
>>>
>>>> I
>>>> attached it to a dup JIRA which I closed, or you can take it as you see
>>>> it.
>>>> You may in general find MRELEASE-887 helpful in this respect.
>>>>
>>>> On Wed, Sep 10, 2014 at 2:53 PM, Robert Scholte <rf...@apache.org>
>>>> wrote:
>>>>
>>>>  Hi,
>>>>
>>>>>
>>>>> IIRC I didn't have enough info to make a unittest, i.e. reproduce what
>>>>> they get right now and what they would expect to be able to fix it.
>>>>> That would take me too much time to find out, so I left this one open
>>>>> for
>>>>> now.
>>>>>
>>>>> thanks,
>>>>> Robert
>>>>>
>>>>> Op Wed, 10 Sep 2014 20:23:07 +0200 schreef Benson Margulies <
>>>>> bimargulies@gmail.com>:
>>>>>
>>>>>
>>>>>  Yes, the remarks which dribbled off pointed to adapting the fix back
>>>>> into
>>>>>
>>>>>  the m-r-p.
>>>>>>
>>>>>>
>>>>>> On Wed, Sep 10, 2014 at 2:21 PM, Karl Heinz Marbaise <
>>>>>> khmarbaise@gmx.de
>>>>>> >
>>>>>> wrote:
>>>>>>
>>>>>>  Hi Benson,
>>>>>>
>>>>>>
>>>>>>> > Is anyone working on a fix to MRELEASE-875?
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>   Based on JIRA it is assigned to Dominik Bartholdi which requested
>>>>>>>>
>>>>>>>>  reviews
>>>>>>> from others on Github...
>>>>>>>
>>>>>>> BTW: Not working on that...
>>>>>>>
>>>>>>> Kind regards
>>>>>>> Karl-Heinz Marbaise
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ------------------------------------------------------------
>>>>>>> ---------
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>>>
>>>>>>>
>>>>>>>  ------------------------------------------------------------
>>>>>>> ---------
>>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>
>>>>>
>>>>>  ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Re: https://github.com/apache/maven-scm/pull/17

Posted by Benson Margulies <bi...@gmail.com>.

Here is the situation, as I've documented in MRELEASE-875:

Using the trunk of the maven-release-plugin + SCM 1.9.1, and using either
git 1.8.5.2 or git 2.1, the problem is fixed as I see it. The contents of
the pull request suggest that it was not fixed for the person who made the
pull request, but since I can't repro, and since the JIRA does not give a
specific git version or a specific test case, my inclination is to push
ahead with a release of the release plugin that uses 1.9.1. I did look at
the test repo in the SCM pull request, but (a) it seems broken, and (b)
it's the same as my test repo, structurally.

Re: https://github.com/apache/maven-scm/pull/17

Posted by Robert Scholte <rf...@apache.org>.

The first step already fails on my machine.

mvn release:prepare release:perform -B -DpushChanges=false

I'm a bit surprised, because I see:
[INFO] Executing: cmd.exe /X /C "git push  
git@github.com:bimargulies/pom-file-name-tc.git  
refs/heads/master:refs/heads/master"

Actual failure:
[ERROR] Failed to execute goal  
org.apache.maven.plugins:maven-release-plugin:2.5:prepare (default-cli) on  
project pom-file-name-tc: Unable to commit files
[ERROR] Provider message:
[ERROR] The git-push command failed.
[ERROR] Command output:
[ERROR] Warning: Permanently added the RSA host key for IP address  
'192.30.252.131' to the list of known hosts.
[ERROR] Permission denied (publickey).
[ERROR] fatal: Could not read from remote repository.
[ERROR]
[ERROR] Please make sure you have the correct access rights
[ERROR] and the repository exists.

As said: I want to create a *unittest*
If I'm correct, the status-call has the wrong arguments. So what should it  
look like? What's the result of this (so I can mock the consumer) and what  
should the next call be?

Robert

Op Wed, 10 Sep 2014 21:17:10 +0200 schreef Benson Margulies  
<bi...@gmail.com>:

> Step 1: in the top level dir of the example, run mvn --batch-mode
> release:prepare release:perform. All will be well. A repo will populate  
> in
> /tmp.
>
> Step 2: modify pom in 'second' directory to use the just-release parent
> pom, commit, push.
>
> Step 3: mvn release:prepare in second directory.
>
> No errors, but the pom.xml will be sitting there modified, and there will
> be a tag pointing to the wrong place.
>
>
>
> On Wed, Sep 10, 2014 at 3:10 PM, Robert Scholte <rf...@apache.org>
> wrote:
>
>> that's just the beginning...
>> so: how did you execute it? what did you get? what would you expect?
>>
>> Op Wed, 10 Sep 2014 20:54:49 +0200 schreef Benson Margulies <
>> bimargulies@gmail.com>:
>>
>>
>>  Aha, I have one for you.  
>> https://github.com/bimargulies/pom-file-name-tc.
>>> I
>>> attached it to a dup JIRA which I closed, or you can take it as you see
>>> it.
>>> You may in general find MRELEASE-887 helpful in this respect.
>>>
>>> On Wed, Sep 10, 2014 at 2:53 PM, Robert Scholte <rf...@apache.org>
>>> wrote:
>>>
>>>  Hi,
>>>>
>>>> IIRC I didn't have enough info to make a unittest, i.e. reproduce what
>>>> they get right now and what they would expect to be able to fix it.
>>>> That would take me too much time to find out, so I left this one open  
>>>> for
>>>> now.
>>>>
>>>> thanks,
>>>> Robert
>>>>
>>>> Op Wed, 10 Sep 2014 20:23:07 +0200 schreef Benson Margulies <
>>>> bimargulies@gmail.com>:
>>>>
>>>>
>>>>  Yes, the remarks which dribbled off pointed to adapting the fix back
>>>> into
>>>>
>>>>> the m-r-p.
>>>>>
>>>>>
>>>>> On Wed, Sep 10, 2014 at 2:21 PM, Karl Heinz Marbaise  
>>>>> <khmarbaise@gmx.de
>>>>> >
>>>>> wrote:
>>>>>
>>>>>  Hi Benson,
>>>>>
>>>>>>
>>>>>> > Is anyone working on a fix to MRELEASE-875?
>>>>>>
>>>>>>
>>>>>>
>>>>>>>  Based on JIRA it is assigned to Dominik Bartholdi which requested
>>>>>>>
>>>>>> reviews
>>>>>> from others on Github...
>>>>>>
>>>>>> BTW: Not working on that...
>>>>>>
>>>>>> Kind regards
>>>>>> Karl-Heinz Marbaise
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>>
>>>>>>
>>>>>>  ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: https://github.com/apache/maven-scm/pull/17

Posted by Benson Margulies <bi...@gmail.com>.

Step 1: in the top level dir of the example, run mvn --batch-mode
release:prepare release:perform. All will be well. A repo will populate in
/tmp.

Step 2: modify pom in 'second' directory to use the just-release parent
pom, commit, push.

Step 3: mvn release:prepare in second directory.

No errors, but the pom.xml will be sitting there modified, and there will
be a tag pointing to the wrong place.



On Wed, Sep 10, 2014 at 3:10 PM, Robert Scholte <rf...@apache.org>
wrote:

> that's just the beginning...
> so: how did you execute it? what did you get? what would you expect?
>
> Op Wed, 10 Sep 2014 20:54:49 +0200 schreef Benson Margulies <
> bimargulies@gmail.com>:
>
>
>  Aha, I have one for you. https://github.com/bimargulies/pom-file-name-tc.
>> I
>> attached it to a dup JIRA which I closed, or you can take it as you see
>> it.
>> You may in general find MRELEASE-887 helpful in this respect.
>>
>> On Wed, Sep 10, 2014 at 2:53 PM, Robert Scholte <rf...@apache.org>
>> wrote:
>>
>>  Hi,
>>>
>>> IIRC I didn't have enough info to make a unittest, i.e. reproduce what
>>> they get right now and what they would expect to be able to fix it.
>>> That would take me too much time to find out, so I left this one open for
>>> now.
>>>
>>> thanks,
>>> Robert
>>>
>>> Op Wed, 10 Sep 2014 20:23:07 +0200 schreef Benson Margulies <
>>> bimargulies@gmail.com>:
>>>
>>>
>>>  Yes, the remarks which dribbled off pointed to adapting the fix back
>>> into
>>>
>>>> the m-r-p.
>>>>
>>>>
>>>> On Wed, Sep 10, 2014 at 2:21 PM, Karl Heinz Marbaise <khmarbaise@gmx.de
>>>> >
>>>> wrote:
>>>>
>>>>  Hi Benson,
>>>>
>>>>>
>>>>> > Is anyone working on a fix to MRELEASE-875?
>>>>>
>>>>>
>>>>>
>>>>>>  Based on JIRA it is assigned to Dominik Bartholdi which requested
>>>>>>
>>>>> reviews
>>>>> from others on Github...
>>>>>
>>>>> BTW: Not working on that...
>>>>>
>>>>> Kind regards
>>>>> Karl-Heinz Marbaise
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>
>>>>>
>>>>>  ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Re: https://github.com/apache/maven-scm/pull/17

Posted by Robert Scholte <rf...@apache.org>.

that's just the beginning...
so: how did you execute it? what did you get? what would you expect?

Op Wed, 10 Sep 2014 20:54:49 +0200 schreef Benson Margulies  
<bi...@gmail.com>:

> Aha, I have one for you.  
> https://github.com/bimargulies/pom-file-name-tc. I
> attached it to a dup JIRA which I closed, or you can take it as you see  
> it.
> You may in general find MRELEASE-887 helpful in this respect.
>
> On Wed, Sep 10, 2014 at 2:53 PM, Robert Scholte <rf...@apache.org>
> wrote:
>
>> Hi,
>>
>> IIRC I didn't have enough info to make a unittest, i.e. reproduce what
>> they get right now and what they would expect to be able to fix it.
>> That would take me too much time to find out, so I left this one open  
>> for
>> now.
>>
>> thanks,
>> Robert
>>
>> Op Wed, 10 Sep 2014 20:23:07 +0200 schreef Benson Margulies <
>> bimargulies@gmail.com>:
>>
>>
>>  Yes, the remarks which dribbled off pointed to adapting the fix back  
>> into
>>> the m-r-p.
>>>
>>>
>>> On Wed, Sep 10, 2014 at 2:21 PM, Karl Heinz Marbaise  
>>> <kh...@gmx.de>
>>> wrote:
>>>
>>>  Hi Benson,
>>>>
>>>> > Is anyone working on a fix to MRELEASE-875?
>>>>
>>>>
>>>>>
>>>>>  Based on JIRA it is assigned to Dominik Bartholdi which requested
>>>> reviews
>>>> from others on Github...
>>>>
>>>> BTW: Not working on that...
>>>>
>>>> Kind regards
>>>> Karl-Heinz Marbaise
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: https://github.com/apache/maven-scm/pull/17

Posted by Benson Margulies <bi...@gmail.com>.

Aha, I have one for you. https://github.com/bimargulies/pom-file-name-tc. I
attached it to a dup JIRA which I closed, or you can take it as you see it.
You may in general find MRELEASE-887 helpful in this respect.

On Wed, Sep 10, 2014 at 2:53 PM, Robert Scholte <rf...@apache.org>
wrote:

> Hi,
>
> IIRC I didn't have enough info to make a unittest, i.e. reproduce what
> they get right now and what they would expect to be able to fix it.
> That would take me too much time to find out, so I left this one open for
> now.
>
> thanks,
> Robert
>
> Op Wed, 10 Sep 2014 20:23:07 +0200 schreef Benson Margulies <
> bimargulies@gmail.com>:
>
>
>  Yes, the remarks which dribbled off pointed to adapting the fix back into
>> the m-r-p.
>>
>>
>> On Wed, Sep 10, 2014 at 2:21 PM, Karl Heinz Marbaise <kh...@gmx.de>
>> wrote:
>>
>>  Hi Benson,
>>>
>>> > Is anyone working on a fix to MRELEASE-875?
>>>
>>>
>>>>
>>>>  Based on JIRA it is assigned to Dominik Bartholdi which requested
>>> reviews
>>> from others on Github...
>>>
>>> BTW: Not working on that...
>>>
>>> Kind regards
>>> Karl-Heinz Marbaise
>>>
>>>
>>>
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Re: https://github.com/apache/maven-scm/pull/17

Posted by Robert Scholte <rf...@apache.org>.

Hi,

IIRC I didn't have enough info to make a unittest, i.e. reproduce what  
they get right now and what they would expect to be able to fix it.
That would take me too much time to find out, so I left this one open for  
now.

thanks,
Robert

Op Wed, 10 Sep 2014 20:23:07 +0200 schreef Benson Margulies  
<bi...@gmail.com>:

> Yes, the remarks which dribbled off pointed to adapting the fix back into
> the m-r-p.
>
>
> On Wed, Sep 10, 2014 at 2:21 PM, Karl Heinz Marbaise <kh...@gmx.de>
> wrote:
>
>> Hi Benson,
>>
>> > Is anyone working on a fix to MRELEASE-875?
>>
>>>
>>>
>> Based on JIRA it is assigned to Dominik Bartholdi which requested  
>> reviews
>> from others on Github...
>>
>> BTW: Not working on that...
>>
>> Kind regards
>> Karl-Heinz Marbaise
>>
>>
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: https://github.com/apache/maven-scm/pull/17

Posted by Benson Margulies <bi...@gmail.com>.

Yes, the remarks which dribbled off pointed to adapting the fix back into
the m-r-p.


On Wed, Sep 10, 2014 at 2:21 PM, Karl Heinz Marbaise <kh...@gmx.de>
wrote:

> Hi Benson,
>
> > Is anyone working on a fix to MRELEASE-875?
>
>>
>>
> Based on JIRA it is assigned to Dominik Bartholdi which requested reviews
> from others on Github...
>
> BTW: Not working on that...
>
> Kind regards
> Karl-Heinz Marbaise
>
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Re: https://github.com/apache/maven-scm/pull/17

Posted by Karl Heinz Marbaise <kh...@gmx.de>.

Hi Benson,

 > Is anyone working on a fix to MRELEASE-875?
>

Based on JIRA it is assigned to Dominik Bartholdi which requested 
reviews from others on Github...

BTW: Not working on that...

Kind regards
Karl-Heinz Marbaise






---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org