You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2025/01/30 07:25:11 UTC
(spark) branch branch-3.5 updated: [SPARK-51039][BUILD] Fix `hive-llap-common` dependency to use `hive.llap.scope` in root `pom.xml`
This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-3.5
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-3.5 by this push:
new 1966d574f0e3 [SPARK-51039][BUILD] Fix `hive-llap-common` dependency to use `hive.llap.scope` in root `pom.xml`
1966d574f0e3 is described below
commit 1966d574f0e3a2db26bdc75da6e4f92870b494d7
Author: Dongjoon Hyun <do...@apache.org>
AuthorDate: Wed Jan 29 23:23:04 2025 -0800
[SPARK-51039][BUILD] Fix `hive-llap-common` dependency to use `hive.llap.scope` in root `pom.xml`
This PR aims to fix `hive-llap-common` dependency to use `hive.llap.scope` in root pom for Apache Spark 3.5 and 4.0.
Apache Spark has been supposed to use `hive.llap.scope` for `hive-llap-common` dependency and `hive` module do it correctly.
https://github.com/apache/spark/blob/a1b0f256c04e5b632075358d1e2f946e64588da6/sql/hive/pom.xml#L119-L123
Since Apache Spark 3.0.0 (SPARK-27176), the root `pom.xml` file has been using a wrong scope mistakenly. Probably, it's due to `-Phive-provided` support. This causes a confusion to other external systems and the users. We had better fix the root `pom.xml` to use `hive.llap.scope` correctly.
- #23788
No, there is no change technically because `hive` module has been using a correct scope.
Pass the CIs.
No.
Closes #49733 from dongjoon-hyun/SPARK-51039.
Authored-by: Dongjoon Hyun <do...@apache.org>
Signed-off-by: Dongjoon Hyun <do...@apache.org>
(cherry picked from commit 7243de6fe7162ac491e73d110425b15ef397ec88)
Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
assembly/pom.xml | 1 +
pom.xml | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/assembly/pom.xml b/assembly/pom.xml
index ee2e7b48871e..b858926fd766 100644
--- a/assembly/pom.xml
+++ b/assembly/pom.xml
@@ -260,6 +260,7 @@
<id>hive-provided</id>
<properties>
<hive.deps.scope>provided</hive.deps.scope>
+ <hive.llap.scope>provided</hive.llap.scope>
</properties>
</profile>
<profile>
diff --git a/pom.xml b/pom.xml
index e427f4d4ce68..6c3c6c7c2108 100644
--- a/pom.xml
+++ b/pom.xml
@@ -2524,7 +2524,7 @@
<groupId>org.apache.hive</groupId>
<artifactId>hive-llap-common</artifactId>
<version>${hive23.version}</version>
- <scope>${hive.deps.scope}</scope>
+ <scope>${hive.llap.scope}</scope>
<exclusions>
<exclusion>
<groupId>org.apache.hive</groupId>
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org