You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "bowenli86 (via GitHub)" <gi...@apache.org> on 2026/06/24 18:44:35 UTC
[PR] [FLINK-39979] DynamicKafkaSource does not mark reader idle when metadata removal leaves a subtask with no active subreaders [flink-connector-kafka]
bowenli86 opened a new pull request, #276:
URL: https://github.com/apache/flink-connector-kafka/pull/276
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39979] DynamicKafkaSource should mark reader idle when metadata removal leaves a subtask with no active subreaders [flink-connector-kafka]
Posted by "bowenli86 (via GitHub)" <gi...@apache.org>.
bowenli86 merged PR #276:
URL: https://github.com/apache/flink-connector-kafka/pull/276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39979] DynamicKafkaSource should mark reader idle when metadata removal leaves a subtask with no active subreaders [flink-connector-kafka]
Posted by "lnbest0707 (via GitHub)" <gi...@apache.org>.
lnbest0707 commented on code in PR #276:
URL: https://github.com/apache/flink-connector-kafka/pull/276#discussion_r3470492923
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/dynamic/source/reader/DynamicKafkaSourceReader.java:
##########
@@ -592,6 +595,12 @@ private void completeAndResetAvailabilityHelper() {
this.availabilityHelperSize = clusterReaderMap.size());
syncAvailabilityHelperWithReaders();
+ if (clusterReaderMap.isEmpty()) {
Review Comment:
Checking only `clusterReaderMap.isEmpty()` may not be sufficient. IIUC, the sub-readers map is always created as long as the kafka metadata map is not empty.
The failing case described in the ticket is more related the number of active assigned splits. When the last active assigned split is removed from the reader, we should mark it idle. While in such case, this `clusterReaderMap` may not be empty and code would not fall in this branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39979] DynamicKafkaSource should mark reader idle when metadata removal leaves a subtask with no active subreaders [flink-connector-kafka]
Posted by "bowenli86 (via GitHub)" <gi...@apache.org>.
bowenli86 commented on PR #276:
URL: https://github.com/apache/flink-connector-kafka/pull/276#issuecomment-4811284002
thanks for the review, addressed comments
merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org