[GitHub] [superset] ad-m commented on a change in pull request #18054: Skip CI for frontend test

[GitBox <gi...@apache.org>]

ad-m commented on a change in pull request #18054:
URL: https://github.com/apache/superset/pull/18054#discussion_r788592235



##########
File path: .github/workflows/superset-frontend.yml
##########
@@ -13,55 +13,64 @@ jobs:
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-20.04
     steps:
+      - uses: dorny/paths-filter@v2

Review comment:
       Why do you need actions for that? Could we use build-in GitHub Actions path filtering?
   
   See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore :
   > `on.<push|pull_request|pull_request_target>.<paths|paths-ignore>`
   > When using the push and pull_request events, you can configure a workflow to run based on what file paths are changed. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org