You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/16 06:45:15 UTC
[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #2309: Fix armv7-a L2CC and apply the code to the sabre-6quad board
masayuki2009 opened a new pull request #2309:
URL: https://github.com/apache/incubator-nuttx/pull/2309
## Summary
- This PR fixes style warnings and compile erros in arm_l2cc_pl310.c and l2cc_pl310.h
- Then I applied the code to the sabre-6quad board
- Also, I removed unnecessary d-cache operation to make boot fast
## Impact
- armv7-a with L2CC
- sabre-6quad:nsh and sabre-6quad:smp
## Testing
- Tested with sabre-6quad:smp (QEMU and dev board)
- Tested with sabre-6quad:nsh (QEMU and dev board)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2309: Fix armv7-a L2CC and apply the code to the sabre-6quad board
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2309:
URL: https://github.com/apache/incubator-nuttx/pull/2309
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2309: Fix armv7-a L2CC and apply the code to the sabre-6quad board
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2309:
URL: https://github.com/apache/incubator-nuttx/pull/2309#issuecomment-729294997
> @btashton
> Could you backport this PR to the 10.0 branch?
>
Sure I'll go through these tonight there are a few more as well. I already did this for these two, but if you add the label they will show up in my query so I won't miss them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #2309: Fix armv7-a L2CC and apply the code to the sabre-6quad board
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #2309:
URL: https://github.com/apache/incubator-nuttx/pull/2309#issuecomment-727788989
@masayuki2009 https://github.com/apache/incubator-nuttx-apps/pull/479
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2309: Fix armv7-a L2CC and apply the code to the sabre-6quad board
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #2309:
URL: https://github.com/apache/incubator-nuttx/pull/2309#issuecomment-727788390
Hmmm, the following error happenned but the error does not relate to this PR.
```
====================================================================================
Configuration/Tool: stm32f429i-disco/nxwm,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Disabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
Building NuttX...
src/chexcalculator.cxx: In member function 'void NxWM::CHexCalculator::updateText()':
Error: src/chexcalculator.cxx:676:38: error: expected ')' before 'PRI64X'
676 | std::snprintf(buffer, 24, "%16" PRI64X, m_accum);
| ~ ^~~~~~~
| )
Error: src/chexcalculator.cxx:680:36: error: expected ')' before 'PRI64d'
680 | std::snprintf(buffer, 24, "%" PRI64d, m_accum);
| ~ ^~~~~~~
| )
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2309: Fix armv7-a L2CC and apply the code to the sabre-6quad board
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #2309:
URL: https://github.com/apache/incubator-nuttx/pull/2309#issuecomment-729299783
> > @btashton
> > Could you backport this PR to the 10.0 branch?
>
> Sure I'll go through these tonight there are a few more as well. I already did this for these two, but if you add the label they will show up in my query so I won't miss them.
@btashton
Ok, got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #2309: Fix armv7-a L2CC and apply the code to the sabre-6quad board
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #2309:
URL: https://github.com/apache/incubator-nuttx/pull/2309#issuecomment-727808695
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2309: Fix armv7-a L2CC and apply the code to the sabre-6quad board
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #2309:
URL: https://github.com/apache/incubator-nuttx/pull/2309#issuecomment-729280432
@btashton
Could you backport this PR to the 10.0 branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2309: Fix armv7-a L2CC and apply the code to the sabre-6quad board
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #2309:
URL: https://github.com/apache/incubator-nuttx/pull/2309#issuecomment-727789408
> @masayuki2009 [apache/incubator-nuttx-apps#479](https://github.com/apache/incubator-nuttx-apps/pull/479)
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org