You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/16 11:32:52 UTC

[GitHub] [camel-website] jyotiattri opened a new pull request #224: Sidebar menu hover effect

jyotiattri opened a new pull request #224: Sidebar menu hover effect
URL: https://github.com/apache/camel-website/pull/224
 
 
   In this PR I have added some changes to the Sidebar menu to make it look like a part of the current theme.
   Previous hover:
   ![sidebar-hover](https://user-images.githubusercontent.com/36660186/76754279-d8a34700-67a7-11ea-9e43-ede39f446f64.png)
   After change Hover:
   ![sidebar-new-hover](https://user-images.githubusercontent.com/36660186/76754319-ee187100-67a7-11ea-8efd-0c6b98e0fb0b.png)
   
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] jyotiattri commented on issue #224: Sidebar menu hover effect

Posted by GitBox <gi...@apache.org>.
jyotiattri commented on issue #224: Sidebar menu hover effect
URL: https://github.com/apache/camel-website/pull/224#issuecomment-600405338
 
 
   Hi, @zregvart 
   Please let me know is there something to do in this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] jyotiattri commented on a change in pull request #224: Sidebar menu hover effect

Posted by GitBox <gi...@apache.org>.
jyotiattri commented on a change in pull request #224: Sidebar menu hover effect
URL: https://github.com/apache/camel-website/pull/224#discussion_r397058367
 
 

 ##########
 File path: antora-ui-camel/src/css/nav.css
 ##########
 @@ -294,3 +294,10 @@ html.is-clipped--nav {
   background-position-y: 10px;
   width: 11rem;
 }
+
+aside.nav .nav-menu li a:hover,
+aside.nav .nav-menu .nav-text:hover {
+  color: #ed8225 !important;
+  text-decoration: underline;
+  text-decoration-color: #ed8225 !important;
+}
 
 Review comment:
   Ok, thanks for the input.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart closed pull request #224: Sidebar menu hover effect

Posted by GitBox <gi...@apache.org>.
zregvart closed pull request #224: Sidebar menu hover effect
URL: https://github.com/apache/camel-website/pull/224
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on issue #224: Sidebar menu hover effect

Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #224: Sidebar menu hover effect
URL: https://github.com/apache/camel-website/pull/224#issuecomment-604335878
 
 
   @jyotiattri is there more work to be done here or are we going to close this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] jyotiattri commented on a change in pull request #224: Sidebar menu hover effect

Posted by GitBox <gi...@apache.org>.
jyotiattri commented on a change in pull request #224: Sidebar menu hover effect
URL: https://github.com/apache/camel-website/pull/224#discussion_r397058367
 
 

 ##########
 File path: antora-ui-camel/src/css/nav.css
 ##########
 @@ -294,3 +294,10 @@ html.is-clipped--nav {
   background-position-y: 10px;
   width: 11rem;
 }
+
+aside.nav .nav-menu li a:hover,
+aside.nav .nav-menu .nav-text:hover {
+  color: #ed8225 !important;
+  text-decoration: underline;
+  text-decoration-color: #ed8225 !important;
+}
 
 Review comment:
   Ok, thanks for the input. I will fix it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on a change in pull request #224: Sidebar menu hover effect

Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #224: Sidebar menu hover effect
URL: https://github.com/apache/camel-website/pull/224#discussion_r397032479
 
 

 ##########
 File path: antora-ui-camel/src/css/nav.css
 ##########
 @@ -294,3 +294,10 @@ html.is-clipped--nav {
   background-position-y: 10px;
   width: 11rem;
 }
+
+aside.nav .nav-menu li a:hover,
+aside.nav .nav-menu .nav-text:hover {
+  color: #ed8225 !important;
+  text-decoration: underline;
+  text-decoration-color: #ed8225 !important;
+}
 
 Review comment:
   This needs to be next to the .nav-menu on lines 118-146, needs to use the CSS variables we have for colors and needs to be without the `!important`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] jyotiattri commented on issue #224: Sidebar menu hover effect

Posted by GitBox <gi...@apache.org>.
jyotiattri commented on issue #224: Sidebar menu hover effect
URL: https://github.com/apache/camel-website/pull/224#issuecomment-604337040
 
 
   Please Close this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services