You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Jason Kenny <jk...@yahoo-inc.com.INVALID> on 2016/01/28 18:23:24 UTC

clang format


Hi,

I was updating a patch by running clang-format. However when I ran this I noticed that I have a lot of files that are now different (50+ files). Should this be happening. I ran this on fedora 23. I would have thought I should only see changes in the one file I modified, ie taffic_via.cc.

Thanks for any advice.

Jason

Re: clang format

Posted by Jason Kenny <jk...@yahoo-inc.com.INVALID>.
Yep that did the trick

Jason


----- Original Message -----
From: Jason Kenny <jk...@yahoo-inc.com.INVALID>
To: "dev@trafficserver.apache.org" <de...@trafficserver.apache.org>; Alan Carroll <so...@yahoo-inc.com>
Sent: Thursday, January 28, 2016 11:34 AM
Subject: Re: clang format

Ahh.. I did not use the magic version. Let me try to get this on my system correctly.

Thanks
Jason




----- Original Message -----
From: Alan Carroll <so...@yahoo-inc.com.INVALID>
To: "dev@trafficserver.apache.org" <de...@trafficserver.apache.org>
Sent: Thursday, January 28, 2016 11:32 AM
Subject: Re: clang format

Did you use Leif's magic clang[1]? Unfortunately clang apparently changes its formatting frequently and without recourse so you must use that precise version to be consistent. In general you should not see that many files changed.


[1] https://bintray.com/apache/trafficserver/clang-format-tools/view





On Thursday, January 28, 2016 11:24 AM, Jason Kenny <jk...@yahoo-inc.com.INVALID> wrote:


Hi,

I was updating a patch by running clang-format. However when I ran this I noticed that I have a lot of files that are now different (50+ files). Should this be happening. I ran this on fedora 23. I would have thought I should only see changes in the one file I modified, ie taffic_via.cc.

Thanks for any advice.

Jason

Re: clang format

Posted by Jason Kenny <jk...@yahoo-inc.com.INVALID>.
Ahh.. I did not use the magic version. Let me try to get this on my system correctly.

Thanks
Jason



----- Original Message -----
From: Alan Carroll <so...@yahoo-inc.com.INVALID>
To: "dev@trafficserver.apache.org" <de...@trafficserver.apache.org>
Sent: Thursday, January 28, 2016 11:32 AM
Subject: Re: clang format

Did you use Leif's magic clang[1]? Unfortunately clang apparently changes its formatting frequently and without recourse so you must use that precise version to be consistent. In general you should not see that many files changed.


[1] https://bintray.com/apache/trafficserver/clang-format-tools/view





On Thursday, January 28, 2016 11:24 AM, Jason Kenny <jk...@yahoo-inc.com.INVALID> wrote:


Hi,

I was updating a patch by running clang-format. However when I ran this I noticed that I have a lot of files that are now different (50+ files). Should this be happening. I ran this on fedora 23. I would have thought I should only see changes in the one file I modified, ie taffic_via.cc.

Thanks for any advice.

Jason

Re: clang format

Posted by Alan Carroll <so...@yahoo-inc.com.INVALID>.
Did you use Leif's magic clang[1]? Unfortunately clang apparently changes its formatting frequently and without recourse so you must use that precise version to be consistent. In general you should not see that many files changed.


[1] https://bintray.com/apache/trafficserver/clang-format-tools/view




On Thursday, January 28, 2016 11:24 AM, Jason Kenny <jk...@yahoo-inc.com.INVALID> wrote:


Hi,

I was updating a patch by running clang-format. However when I ran this I noticed that I have a lot of files that are now different (50+ files). Should this be happening. I ran this on fedora 23. I would have thought I should only see changes in the one file I modified, ie taffic_via.cc.

Thanks for any advice.

Jason