You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/02/16 16:34:13 UTC
[GitHub] [ozone] mukul1987 opened a new pull request #1925: HDDS-4829. Rename MiniOzoneHACluster to MiniOzoneOMHACluster.
mukul1987 opened a new pull request #1925:
URL: https://github.com/apache/ozone/pull/1925
## What changes were proposed in this pull request?
Rename MiniOzoneHACluster to MiniOzoneOMHACluster
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4829
## How was this patch tested?
Simple refactoring change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on a change in pull request #1925: HDDS-4829. Rename MiniOzoneHACluster to MiniOzoneOMHACluster.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #1925:
URL: https://github.com/apache/ozone/pull/1925#discussion_r577047896
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneOMHAClusterImpl.java
##########
@@ -54,10 +54,10 @@
* with OM HA suitable for running tests. The cluster consists of a set of
* OzoneManagers, StorageContainerManager and multiple DataNodes.
*/
-public class MiniOzoneHAClusterImpl extends MiniOzoneClusterImpl {
Review comment:
Comments need to be updated witth MiniOzoneHAClusterImpl -> MiniOzoneOMHAClusterImpl
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/recon/TestReconWithOzoneManagerHA.java
##########
@@ -55,7 +55,7 @@
@Rule
public Timeout timeout = new Timeout(300_000);
- private MiniOzoneHAClusterImpl cluster;
+ private MiniOzoneOMHAClusterImpl cluster;
Review comment:
Same here comments need to be updated
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestMiniOzoneOMHACluster.java
##########
@@ -41,9 +41,9 @@
/**
* This class tests MiniOzoneHAClusterImpl.
Review comment:
same here comments need to be updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant edited a comment on pull request #1925: HDDS-4829. Rename MiniOzoneHACluster to MiniOzoneOMHACluster.
Posted by GitBox <gi...@apache.org>.
bshashikant edited a comment on pull request #1925:
URL: https://github.com/apache/ozone/pull/1925#issuecomment-780281016
> Question:
> Do you need to overwrite `waitForClusterToBeReady` in `MiniOzoneOMHACluster` (e.g. to wait OM elects a leader)?
I think, Leader election should be handled within safe mode itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant commented on pull request #1925: HDDS-4829. Rename MiniOzoneHACluster to MiniOzoneOMHACluster.
Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #1925:
URL: https://github.com/apache/ozone/pull/1925#issuecomment-780281149
> > Question:
> > Do you need to overwrite `waitForClusterToBeReady` in `MiniOzoneOMHACluster` (e.g. to wait OM elects a leader)?
> > Leader election should be handled within safe mode itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant closed pull request #1925: HDDS-4829. Rename MiniOzoneHACluster to MiniOzoneOMHACluster.
Posted by GitBox <gi...@apache.org>.
bshashikant closed pull request #1925:
URL: https://github.com/apache/ozone/pull/1925
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] mukul1987 merged pull request #1925: HDDS-4829. Rename MiniOzoneHACluster to MiniOzoneOMHACluster.
Posted by GitBox <gi...@apache.org>.
mukul1987 merged pull request #1925:
URL: https://github.com/apache/ozone/pull/1925
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant removed a comment on pull request #1925: HDDS-4829. Rename MiniOzoneHACluster to MiniOzoneOMHACluster.
Posted by GitBox <gi...@apache.org>.
bshashikant removed a comment on pull request #1925:
URL: https://github.com/apache/ozone/pull/1925#issuecomment-780281149
> > Question:
> > Do you need to overwrite `waitForClusterToBeReady` in `MiniOzoneOMHACluster` (e.g. to wait OM elects a leader)?
> > Leader election should be handled within safe mode itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant commented on pull request #1925: HDDS-4829. Rename MiniOzoneHACluster to MiniOzoneOMHACluster.
Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #1925:
URL: https://github.com/apache/ozone/pull/1925#issuecomment-780281016
> Question:
> Do you need to overwrite `waitForClusterToBeReady` in `MiniOzoneOMHACluster` (e.g. to wait OM elects a leader)?
Leader election should be handled within safe mode itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on pull request #1925: HDDS-4829. Rename MiniOzoneHACluster to MiniOzoneOMHACluster.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1925:
URL: https://github.com/apache/ozone/pull/1925#issuecomment-780129766
Question:
Do you need to overwrite `waitForClusterToBeReady` in `MiniOzoneOMHACluster` (e.g. to wait OM elects a leader)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on pull request #1925: HDDS-4829. Rename MiniOzoneHACluster to MiniOzoneOMHACluster.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1925:
URL: https://github.com/apache/ozone/pull/1925#issuecomment-780128349
+1 this is a good step for supporting MiniOzoneSCMHACluster
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org