You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/12/10 17:45:19 UTC
[kudu-CR] [util] introduce WaitFor{Tcp,Udp}BindAtPort()
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19337
Change subject: [util] introduce WaitFor{Tcp,Udp}BindAtPort()
......................................................................
[util] introduce WaitFor{Tcp,Udp}BindAtPort()
This patch introduces a new utility functions to be used in tests:
* WaitForTcpBindAtPort()
* WaitForUdpBindAtPort()
They are similar to already existing WaitFor{Tcp,Udp}Bind(), but have
semantics of waiting while some process binds to the specified port.
The difference that in these new cases the port number is known
beforehand, and it doesn't matter which process binds to the port.
This functionality will be used in a follow-up patch.
Change-Id: Ia466bf20040b35359d95fd66971e4af668d081e7
---
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
2 files changed, 90 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/19337/1
--
To view, visit http://gerrit.cloudera.org:8080/19337
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia466bf20040b35359d95fd66971e4af668d081e7
Gerrit-Change-Number: 19337
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [util] introduce WaitFor{Tcp,Udp}BindAtPort()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19337 )
Change subject: [util] introduce WaitFor{Tcp,Udp}BindAtPort()
......................................................................
[util] introduce WaitFor{Tcp,Udp}BindAtPort()
This patch introduces a new utility functions to be used in tests:
* WaitForTcpBindAtPort()
* WaitForUdpBindAtPort()
They are similar to already existing WaitFor{Tcp,Udp}Bind(), but have
semantics of waiting while some process binds to the specified port.
The difference that in these new cases the port number is known
beforehand, and it doesn't matter which process binds to the port.
This functionality will be used in a follow-up patch.
Change-Id: Ia466bf20040b35359d95fd66971e4af668d081e7
Reviewed-on: http://gerrit.cloudera.org:8080/19337
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Yifan Zhang <ch...@163.com>
---
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
2 files changed, 90 insertions(+), 2 deletions(-)
Approvals:
Alexey Serbin: Verified
Yifan Zhang: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19337
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia466bf20040b35359d95fd66971e4af668d081e7
Gerrit-Change-Number: 19337
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [util] introduce WaitFor{Tcp,Udp}BindAtPort()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19337 )
Change subject: [util] introduce WaitFor{Tcp,Udp}BindAtPort()
......................................................................
Patch Set 1: Verified+1
unrelated test failure in RebalanceParamTest.Rebalance/2
--
To view, visit http://gerrit.cloudera.org:8080/19337
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia466bf20040b35359d95fd66971e4af668d081e7
Gerrit-Change-Number: 19337
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Sat, 10 Dec 2022 19:55:36 +0000
Gerrit-HasComments: No
[kudu-CR] [util] introduce WaitFor{Tcp,Udp}BindAtPort()
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19337 )
Change subject: [util] introduce WaitFor{Tcp,Udp}BindAtPort()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19337
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia466bf20040b35359d95fd66971e4af668d081e7
Gerrit-Change-Number: 19337
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Mon, 12 Dec 2022 13:28:56 +0000
Gerrit-HasComments: No
[kudu-CR] [util] introduce WaitFor{Tcp,Udp}BindAtPort()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [util] introduce WaitFor{Tcp,Udp}BindAtPort()
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19337
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia466bf20040b35359d95fd66971e4af668d081e7
Gerrit-Change-Number: 19337
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>