You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Xianqing He (Code Review)" <ge...@cloudera.org> on 2022/01/29 06:29:50 UTC
[Impala-ASF-CR] IMPALA-10982: fix unable to explain the set operation statement
Xianqing He has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18179
Change subject: IMPALA-10982: fix unable to explain the set operation statement
......................................................................
IMPALA-10982: fix unable to explain the set operation statement
For SetOperationStmt we will replace the query statement with the
rewritten version, but we haven’t set the explain flag if the
original is explain statement.
Tests:
-- Using impala-shell to test the explain statement of set operation.
Change-Id: I19264dfa794ffd5ed7355acfef0ac35f17c809d3
---
M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/18179/2
--
To view, visit http://gerrit.cloudera.org:8080/18179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I19264dfa794ffd5ed7355acfef0ac35f17c809d3
Gerrit-Change-Number: 18179
Gerrit-PatchSet: 2
Gerrit-Owner: Xianqing He <he...@126.com>
[Impala-ASF-CR] IMPALA-10982: fix unable to explain the set operation statement
Posted by "Xianqing He (Code Review)" <ge...@cloudera.org>.
Xianqing He has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/18179 )
Change subject: IMPALA-10982: fix unable to explain the set operation statement
......................................................................
IMPALA-10982: fix unable to explain the set operation statement
For SetOperationStmt we will replace the query statement with the
rewritten version, but we haven’t set the explain flag if the
original is explain statement.
Tests:
-- Using impala-shell to test the explain statement of set operation.
-- Add new test case in the explain_level tests
Change-Id: I19264dfa794ffd5ed7355acfef0ac35f17c809d3
---
M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java
M testdata/workloads/functional-query/queries/QueryTest/explain-level0.test
M testdata/workloads/functional-query/queries/QueryTest/explain-level1.test
M testdata/workloads/functional-query/queries/QueryTest/explain-level2.test
4 files changed, 29 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/18179/4
--
To view, visit http://gerrit.cloudera.org:8080/18179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I19264dfa794ffd5ed7355acfef0ac35f17c809d3
Gerrit-Change-Number: 18179
Gerrit-PatchSet: 4
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>
[Impala-ASF-CR] IMPALA-10982: fix unable to explain the set operation statement
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18179 )
Change subject: IMPALA-10982: fix unable to explain the set operation statement
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10141/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19264dfa794ffd5ed7355acfef0ac35f17c809d3
Gerrit-Change-Number: 18179
Gerrit-PatchSet: 4
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>
Gerrit-Comment-Date: Fri, 11 Feb 2022 14:37:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10982: fix unable to explain the set operation statement
Posted by "Xianqing He (Code Review)" <ge...@cloudera.org>.
Xianqing He has posted comments on this change. ( http://gerrit.cloudera.org:8080/18179 )
Change subject: IMPALA-10982: fix unable to explain the set operation statement
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18179/2/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java
File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java:
http://gerrit.cloudera.org:8080/#/c/18179/2/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@567
PS2, Line 567: isExplain
> nit. May refer to 'analysisResult_.isExplainStmt()' directly here as it is
The statement type is getted from the AnalysisResult_.stmt_, so we need use 'isExplain' to record the original statement type. Here 'analysisResult_.isExplainStmt()' gets the rewritten version statement type
--
To view, visit http://gerrit.cloudera.org:8080/18179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19264dfa794ffd5ed7355acfef0ac35f17c809d3
Gerrit-Change-Number: 18179
Gerrit-PatchSet: 2
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>
Gerrit-Comment-Date: Sat, 05 Feb 2022 15:45:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10982: fix unable to explain the set operation statement
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18179 )
Change subject: IMPALA-10982: fix unable to explain the set operation statement
......................................................................
IMPALA-10982: fix unable to explain the set operation statement
For SetOperationStmt we will replace the query statement with the
rewritten version, but we haven’t set the explain flag if the
original is explain statement.
Tests:
-- Using impala-shell to test the explain statement of set operation.
-- Add new test case in the explain_level tests
Change-Id: I19264dfa794ffd5ed7355acfef0ac35f17c809d3
Reviewed-on: http://gerrit.cloudera.org:8080/18179
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java
M testdata/workloads/functional-query/queries/QueryTest/explain-level0.test
M testdata/workloads/functional-query/queries/QueryTest/explain-level1.test
M testdata/workloads/functional-query/queries/QueryTest/explain-level2.test
4 files changed, 29 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I19264dfa794ffd5ed7355acfef0ac35f17c809d3
Gerrit-Change-Number: 18179
Gerrit-PatchSet: 6
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>
[Impala-ASF-CR] IMPALA-10982: fix unable to explain the set operation statement
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18179 )
Change subject: IMPALA-10982: fix unable to explain the set operation statement
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7836/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19264dfa794ffd5ed7355acfef0ac35f17c809d3
Gerrit-Change-Number: 18179
Gerrit-PatchSet: 5
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>
Gerrit-Comment-Date: Fri, 11 Feb 2022 23:43:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10982: fix unable to explain the set operation statement
Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/18179 )
Change subject: IMPALA-10982: fix unable to explain the set operation statement
......................................................................
Patch Set 2:
(1 comment)
Looks good!
http://gerrit.cloudera.org:8080/#/c/18179/2/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java
File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java:
http://gerrit.cloudera.org:8080/#/c/18179/2/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@567
PS2, Line 567: isExplain
nit. May refer to 'analysisResult_.isExplainStmt()' directly here as it is used only once.
--
To view, visit http://gerrit.cloudera.org:8080/18179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19264dfa794ffd5ed7355acfef0ac35f17c809d3
Gerrit-Change-Number: 18179
Gerrit-PatchSet: 2
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Feb 2022 18:10:55 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10982: fix unable to explain the set operation statement
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18179 )
Change subject: IMPALA-10982: fix unable to explain the set operation statement
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7813/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19264dfa794ffd5ed7355acfef0ac35f17c809d3
Gerrit-Change-Number: 18179
Gerrit-PatchSet: 2
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>
Gerrit-Comment-Date: Mon, 07 Feb 2022 04:08:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10982: fix unable to explain the set operation statement
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18179 )
Change subject: IMPALA-10982: fix unable to explain the set operation statement
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19264dfa794ffd5ed7355acfef0ac35f17c809d3
Gerrit-Change-Number: 18179
Gerrit-PatchSet: 4
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>
Gerrit-Comment-Date: Fri, 11 Feb 2022 23:43:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10982: fix unable to explain the set operation statement
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18179 )
Change subject: IMPALA-10982: fix unable to explain the set operation statement
......................................................................
Patch Set 3:
Thanks for fixing this! Could you add some tests?
We already have planner tests in PlannerTest#testSetOperationRewrite(). Probably we need end-to-end tests to reveal this bug.
--
To view, visit http://gerrit.cloudera.org:8080/18179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19264dfa794ffd5ed7355acfef0ac35f17c809d3
Gerrit-Change-Number: 18179
Gerrit-PatchSet: 3
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>
Gerrit-Comment-Date: Fri, 11 Feb 2022 10:40:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10982: fix unable to explain the set operation statement
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18179 )
Change subject: IMPALA-10982: fix unable to explain the set operation statement
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10073/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19264dfa794ffd5ed7355acfef0ac35f17c809d3
Gerrit-Change-Number: 18179
Gerrit-PatchSet: 2
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 29 Jan 2022 06:53:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10982: fix unable to explain the set operation statement
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18179 )
Change subject: IMPALA-10982: fix unable to explain the set operation statement
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7813/
--
To view, visit http://gerrit.cloudera.org:8080/18179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19264dfa794ffd5ed7355acfef0ac35f17c809d3
Gerrit-Change-Number: 18179
Gerrit-PatchSet: 2
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>
Gerrit-Comment-Date: Mon, 07 Feb 2022 10:48:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10982: fix unable to explain the set operation statement
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18179 )
Change subject: IMPALA-10982: fix unable to explain the set operation statement
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19264dfa794ffd5ed7355acfef0ac35f17c809d3
Gerrit-Change-Number: 18179
Gerrit-PatchSet: 5
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>
Gerrit-Comment-Date: Sat, 12 Feb 2022 06:09:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10982: fix unable to explain the set operation statement
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18179 )
Change subject: IMPALA-10982: fix unable to explain the set operation statement
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19264dfa794ffd5ed7355acfef0ac35f17c809d3
Gerrit-Change-Number: 18179
Gerrit-PatchSet: 5
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>
Gerrit-Comment-Date: Fri, 11 Feb 2022 23:43:58 +0000
Gerrit-HasComments: No