You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/09/26 20:01:42 UTC
Review Request: Added a test that expects a _contending_ MasterDetector
instance will send a NoMasterDetected message to the listening PID.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7293/
-----------------------------------------------------------
Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler.
Description
-------
See summary (5 of 7).
Diffs
-----
src/tests/utils.hpp fc2023b
src/tests/zookeeper_tests.cpp 2e04069
Diff: https://reviews.apache.org/r/7293/diff/
Testing
-------
This added test is EXPECTED to fail.
Thanks,
Benjamin Hindman
Re: Review Request: Added a test that expects a _contending_ MasterDetector
instance will send a NoMasterDetected message to the listening PID.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Sept. 26, 2012, 8:37 p.m., Vinod Kone wrote:
> > src/tests/zookeeper_tests.cpp, line 208
> > <https://reviews.apache.org/r/7293/diff/1/?file=160214#file160214line208>
> >
> > curious, why you did MicroSeconds(10000).secs() instead of Seconds(10).secs()?
> >
> > On a side note, Clock should accept duration (don't remember if you already have a TODO for that)
Changed. And I agree, advance needs to take a duration (for a future review).
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7293/#review11942
-----------------------------------------------------------
On Sept. 26, 2012, 6:01 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7293/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2012, 6:01 p.m.)
>
>
> Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> See summary (5 of 7).
>
>
> Diffs
> -----
>
> src/tests/utils.hpp fc2023b
> src/tests/zookeeper_tests.cpp 2e04069
>
> Diff: https://reviews.apache.org/r/7293/diff/
>
>
> Testing
> -------
>
> This added test is EXPECTED to fail.
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added a test that expects a _contending_ MasterDetector
instance will send a NoMasterDetected message to the listening PID.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7293/#review11942
-----------------------------------------------------------
Ship it!
src/tests/zookeeper_tests.cpp
<https://reviews.apache.org/r/7293/#comment25477>
curious, why you did MicroSeconds(10000).secs() instead of Seconds(10).secs()?
On a side note, Clock should accept duration (don't remember if you already have a TODO for that)
- Vinod Kone
On Sept. 26, 2012, 6:01 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7293/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2012, 6:01 p.m.)
>
>
> Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> See summary (5 of 7).
>
>
> Diffs
> -----
>
> src/tests/utils.hpp fc2023b
> src/tests/zookeeper_tests.cpp 2e04069
>
> Diff: https://reviews.apache.org/r/7293/diff/
>
>
> Testing
> -------
>
> This added test is EXPECTED to fail.
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added a test that expects a _contending_ MasterDetector
instance will send a NoMasterDetected message to the listening PID.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Sept. 27, 2012, 9:45 p.m., Ben Mahler wrote:
> > src/tests/utils.hpp, line 628
> > <https://reviews.apache.org/r/7293/diff/1/?file=160213#file160213line628>
> >
> > fits on one line
Done.
> On Sept. 27, 2012, 9:45 p.m., Ben Mahler wrote:
> > src/tests/utils.hpp, line 634
> > <https://reviews.apache.org/r/7293/diff/1/?file=160213#file160213line634>
> >
> > can we kill the outside do-while(false) and just replace it with braces?
Using the do while () makes this a statement rather than just a block, so it can be used in more places.
> On Sept. 27, 2012, 9:45 p.m., Ben Mahler wrote:
> > src/tests/utils.hpp, line 638
> > <https://reviews.apache.org/r/7293/diff/1/?file=160213#file160213line638>
> >
> > let's use braces here for consistency?
Great, thanks!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7293/#review12004
-----------------------------------------------------------
On Sept. 26, 2012, 6:01 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7293/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2012, 6:01 p.m.)
>
>
> Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> See summary (5 of 7).
>
>
> Diffs
> -----
>
> src/tests/utils.hpp fc2023b
> src/tests/zookeeper_tests.cpp 2e04069
>
> Diff: https://reviews.apache.org/r/7293/diff/
>
>
> Testing
> -------
>
> This added test is EXPECTED to fail.
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added a test that expects a _contending_ MasterDetector
instance will send a NoMasterDetected message to the listening PID.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7293/#review12004
-----------------------------------------------------------
src/tests/utils.hpp
<https://reviews.apache.org/r/7293/#comment25575>
fits on one line
src/tests/utils.hpp
<https://reviews.apache.org/r/7293/#comment25581>
can we kill the outside do-while(false) and just replace it with braces?
src/tests/utils.hpp
<https://reviews.apache.org/r/7293/#comment25578>
make sleeps unsigned?
src/tests/utils.hpp
<https://reviews.apache.org/r/7293/#comment25579>
let's use braces here for consistency?
src/tests/utils.hpp
<https://reviews.apache.org/r/7293/#comment25576>
this file should include <unistd.h> for usleep
- Ben Mahler
On Sept. 26, 2012, 6:01 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7293/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2012, 6:01 p.m.)
>
>
> Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> See summary (5 of 7).
>
>
> Diffs
> -----
>
> src/tests/utils.hpp fc2023b
> src/tests/zookeeper_tests.cpp 2e04069
>
> Diff: https://reviews.apache.org/r/7293/diff/
>
>
> Testing
> -------
>
> This added test is EXPECTED to fail.
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added a test that expects a _contending_ MasterDetector
instance will send a NoMasterDetected message to the listening PID.
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7293/#review11955
-----------------------------------------------------------
Ship it!
Ship It!
- John Sirois
On Sept. 26, 2012, 6:01 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7293/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2012, 6:01 p.m.)
>
>
> Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> See summary (5 of 7).
>
>
> Diffs
> -----
>
> src/tests/utils.hpp fc2023b
> src/tests/zookeeper_tests.cpp 2e04069
>
> Diff: https://reviews.apache.org/r/7293/diff/
>
>
> Testing
> -------
>
> This added test is EXPECTED to fail.
>
>
> Thanks,
>
> Benjamin Hindman
>
>