You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by GitBox <gi...@apache.org> on 2020/04/20 18:14:51 UTC

[GitHub] [geode] jhuynh1 commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

jhuynh1 commented on a change in pull request #4928:
URL: https://github.com/apache/geode/pull/4928#discussion_r411587074



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderQueue.java
##########
@@ -410,6 +441,53 @@ public Object peek() throws CacheException {
     // so no need to worry about off-heap refCount.
   }
 
+  private void peekEventsFromIncompleteTransactions(List<AsyncEvent> batch,

Review comment:
       This looks similar to the other peekEventsFromIncompleteTransactions, is there a way to reuse the code?  Although the classes probably already do a lot of duplication ...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org