[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1477: [CELEBORN-573] Guarantee resource/app/worker change persistent to raft in Ha Mode.

["waitinfuture (via GitHub)" <gi...@apache.org>]

waitinfuture commented on code in PR #1477:
URL: https://github.com/apache/incubator-celeborn/pull/1477#discussion_r1186992466


##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala:
##########
@@ -510,16 +510,21 @@ private[celeborn] class Worker(
           // During graceful shutdown, to avoid allocate slots in this worker,
           // add this worker to master's blacklist. When restart, register worker will
           // make master remove this worker from blacklist.
-          rssHARetryClient.send(ReportWorkerUnavailable(List(workerInfo).asJava))
-          val interval = conf.checkSlotsFinishedInterval
           val timeout = conf.checkSlotsFinishedTimeoutMs
-          var waitTimes = 0
-
-          def waitTime: Long = waitTimes * interval
+          val startTime = System.currentTimeMillis()
+          def waitTime: Long = System.currentTimeMillis() - startTime
+          while (waitTime < timeout) {
+            try {
+              rssHARetryClient.send(ReportWorkerUnavailable(List(workerInfo).asJava))

Review Comment:
   Seems rssHARetryClient.send will not throw Exception



##########
common/src/main/scala/org/apache/celeborn/common/exception/CelebornServiceException.scala:
##########
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.celeborn.common.exception
+
+class CelebornServiceException(message: String, cause: Throwable)

Review Comment:
   Is it possible to reuse CelebornException instead of introducing a new one?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org